[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1108893: marked as done (unblock: node-superagent/9.0.1-2)



Your message dated Tue, 08 Jul 2025 05:58:16 +0000
with message-id <E1uZ1LM-00BX0N-1m@respighi.debian.org>
and subject line unblock node-superagent
has caused the Debian Bug report #1108893,
regarding unblock: node-superagent/9.0.1-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1108893: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108893
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: node-superagent@packages.debian.org, kapouer@debian.org, yadd@debian.org
Control: affects -1 + src:node-superagent
User: release.debian.org@packages.debian.org
Usertags: unblock

[ Reason ]
Due to nodejs changes, node-superagent autopkgtest started to fail
because nodejs changed the http query method.

[ Impact ]
Bad management of the HTTP QUERY method

[ Tests ]
Test passed with the patch (which fixes FTBFS #1108818)

[ Risks ]
No risk, patch is trivial

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]
Patch is taken from upstream

Best regards,
Xavier

unblock node-superagent/9.0.1-2
diff --git a/debian/changelog b/debian/changelog
index 6af31b2..16049a2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+node-superagent (9.0.1-2) unstable; urgency=medium
+
+  * Team upload
+  * patch: fix query method overwrite. Closes: #1108818.
+
+ -- Jérémy Lal <kapouer@melix.org>  Sun, 06 Jul 2025 20:38:43 +0200
+
 node-superagent (9.0.1-1) unstable; urgency=medium
 
   * Team upload
diff --git a/debian/patches/fix-query-method.patch b/debian/patches/fix-query-method.patch
new file mode 100644
index 0000000..1905394
--- /dev/null
+++ b/debian/patches/fix-query-method.patch
@@ -0,0 +1,20 @@
+From 05acc1a664880a0a65bd30b9d1cb78eb11bc5fa5 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Lal?= <kapouer@melix.org>
+Date: Sun, 6 Jul 2025 17:40:21 +0200
+Subject: [PATCH] node agent: ignore query http method
+
+This is needed with newer node versions having QUERY in http.METHODS.
+---
+ src/node/agent.js | 1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/src/node/agent.js
++++ b/src/node/agent.js
+@@ -80,6 +80,7 @@
+ 
+ for (const name of methods) {
+   const method = name.toUpperCase();
++  if (method === "QUERY") continue;
+   Agent.prototype[name] = function (url, fn) {
+     const request_ = new request.Request(method, url);
+ 
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..0362bbd
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix-query-method.patch

--- End Message ---
--- Begin Message ---
Unblocked.

--- End Message ---

Reply to: