[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1108873: marked as done (unblock: node-supertest/7.0.0+~6.0.2-2)

Your message dated Sun, 06 Jul 2025 18:03:20 +0000
with message-id <E1uYThw-009kVg-1m@respighi.debian.org>
and subject line unblock node-supertest
has caused the Debian Bug report #1108873,
regarding unblock: node-supertest/7.0.0+~6.0.2-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1108873: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108873
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: node-supertest@packages.debian.org, yadd@debian.org
Control: affects -1 + src:node-supertest
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package node-supertest

[ Reason ]
Due to Node.js changes, node-supertest test failed (FTBFS #1108816)

[ Impact ]
FTBFS

[ Tests ]
Of course

[ Risks ]
No risk, just a test change

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

Best regards,
Xavier

unblock node-supertest/7.0.0+~6.0.2-2

diff --git a/debian/changelog b/debian/changelog
index 9d4919d..0ec48ee 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+node-supertest (7.0.0+~6.0.2-2) unstable; urgency=medium
+
+  * Team upload
+  * Update test to not query nodejs "http" error strings which may change
+    (Closes: #1108816)
+
+ -- Yadd <yadd@debian.org>  Sun, 06 Jul 2025 08:23:01 +0200
+
 node-supertest (7.0.0+~6.0.2-1) unstable; urgency=medium
 
   * Team upload
diff --git a/debian/patches/fix-tests.patch b/debian/patches/fix-tests.patch
new file mode 100644
index 0000000..f228735
--- /dev/null
+++ b/debian/patches/fix-tests.patch
@@ -0,0 +1,17 @@
+Description: don't test message string since it may change depending on Node.js versions
+Author: Yadd <yadd@debian.org>
+Bug-Debian: https://bugs.debian.org/1108816
+Forwarded: no
+Last-Update: 2025-07-06
+
+--- a/test/supertest.js
++++ b/test/supertest.js
+@@ -387,7 +387,7 @@
+         .get('/')
+         .expect(200)
+         .end(function (err, res) {
+-          err.message.should.equal('ECONNREFUSED: Connection refused');
++          err.should.be.ok();
+           done();
+         });
+     });
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..d04b329
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix-tests.patch

--- End Message ---
--- Begin Message --- 
Unblocked node-supertest.

--- End Message ---
Reply to: