--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: ufo-filters@packages.debian.org
Control: affects -1 + src:ufo-filters
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package ufo-filters
Hello, here a 2 liners patch of ufo-filters, which cause a segfault in the transpose filter.
This was reposted by one of our user at the CAnadial light source.
[ Reason ]
In order to have a fully working ufo-filters.
Without this patch the tofu (gui on top of ufo-filters) will fail to work.
It introspect al filters in order to present the parameters to the users.
due to the segfault it is not possible to use the gui interface.
[ Impact ]
The impossibility to use the gui interface. It does not make the code completly un-usable for expert, but allowing non expert users seems to me important.
[ Tests ]
We tuned the autopkgtest in order to verify thaht the segfault is no more an issue.
[ Risks ]
I see no risk, it is already used by one of our expert user (this is why we did not saw the issue initially...).
The fix is trivial and already fixed in the upstream code.
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
[ Other info ]
no
unblock ufo-filters/0.17.0.76.g691aa0e+dfsg1-2
diff -Nru ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/changelog ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/changelog
--- ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/changelog 2025-05-20 02:51:22.000000000 +0200
+++ ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/changelog 2025-06-30 13:41:19.000000000 +0200
@@ -1,3 +1,13 @@
+ufo-filters (0.17.0.76.g691aa0e+dfsg1-2) unstable; urgency=medium
+
+ * d/t/no-ocl: Upgraded test of task introspection
+ * Bug fix: "Transpose task missing properties", thanks to Stuart Read
+ (Closes: #1108226).
+ * Bug fix: "Fails to build source after successful build", thanks to
+ Lucas Nussbaum (Closes: #1048701).
+
+ -- Serge Cohen <serge1cohen@free.fr> Mon, 30 Jun 2025 13:41:19 +0200
+
ufo-filters (0.17.0.76.g691aa0e+dfsg1-1) unstable; urgency=medium
* New upstream version 0.17.0.76.g691aa0e+dfsg1
diff -Nru ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/0003-re-Fixing-segfault-in-ufo-query-p-transpose.patch ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/0003-re-Fixing-segfault-in-ufo-query-p-transpose.patch
--- ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/0003-re-Fixing-segfault-in-ufo-query-p-transpose.patch 1970-01-01 01:00:00.000000000 +0100
+++ ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/0003-re-Fixing-segfault-in-ufo-query-p-transpose.patch 2025-06-30 13:41:19.000000000 +0200
@@ -0,0 +1,34 @@
+From: Serge Cohen <serge.cohen@cnrs.fr>
+Date: Mon, 30 Jun 2025 11:29:06 +0200
+Subject: (re-)Fixing segfault in ufo-query -p transpose
+
+---
+ src/ufo-transpose-task.c | 1 +
+ src/ufo-transpose-task.h | 2 +-
+ 2 files changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/ufo-transpose-task.c b/src/ufo-transpose-task.c
+index 593e504..1d288be 100644
+--- a/src/ufo-transpose-task.c
++++ b/src/ufo-transpose-task.c
+@@ -171,6 +171,7 @@ ufo_transpose_task_class_init (UfoTransposeTaskClass *klass)
+ GObjectClass *oclass = G_OBJECT_CLASS (klass);
+
+ oclass->finalize = ufo_transpose_task_finalize;
++ g_type_class_add_private (oclass, sizeof(UfoTransposeTaskPrivate));
+ }
+
+ static void
+diff --git a/src/ufo-transpose-task.h b/src/ufo-transpose-task.h
+index fab9fdb..612efee 100644
+--- a/src/ufo-transpose-task.h
++++ b/src/ufo-transpose-task.h
+@@ -54,7 +54,7 @@ struct _UfoTransposeTask {
+ struct _UfoTransposeTaskClass {
+ /*< private >*/
+ UfoTaskNodeClass parent_class;
+- UfoTransposeTaskPrivate *priv;
++ UfoTransposeTaskPrivate *priv;
+ };
+
+ UfoNode *ufo_transpose_task_new (void);
diff -Nru ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/patch-conf.py-in-order-to-use-the-locall ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/patch-conf.py-in-order-to-use-the-locall
--- ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/patch-conf.py-in-order-to-use-the-locall 2025-05-20 02:51:22.000000000 +0200
+++ ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/patch-conf.py-in-order-to-use-the-locall 2025-06-30 13:41:19.000000000 +0200
@@ -7,11 +7,11 @@
1 file changed, 2 insertions(+)
diff --git a/docs/conf.py b/docs/conf.py
-index e088d7b..a9cddaf 100644
+index 52c67de..8f2929b 100644
--- a/docs/conf.py
+++ b/docs/conf.py
-@@ -64,3 +64,5 @@
-
+@@ -64,3 +64,5 @@ latex_documents = [
+
bibtex_bibfiles = ['refs.bib']
bibtex_reference_style = 'author_year'
+
diff -Nru ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/series ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/series
--- ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/series 2025-05-20 02:51:22.000000000 +0200
+++ ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/patches/series 2025-06-30 13:41:19.000000000 +0200
@@ -1,2 +1,3 @@
patch-conf.py-in-order-to-use-the-locall
0001-sphinx-Fix-Directive-import-to-work-with-Sphinx-1.8.patch
+0003-re-Fixing-segfault-in-ufo-query-p-transpose.patch
diff -Nru ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/tests/no-ocl ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/tests/no-ocl
--- ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/tests/no-ocl 2025-05-20 02:51:22.000000000 +0200
+++ ufo-filters-0.17.0.76.g691aa0e+dfsg1/debian/tests/no-ocl 2025-06-30 13:41:19.000000000 +0200
@@ -1,4 +1,4 @@
-#!/bin/sh -e
+#!/bin/bash
## We will work in the tmp directory :
cd $AUTOPKGTEST_TMP
@@ -13,14 +13,34 @@
## zmq-pub expected-subscribers=0
## # write filename=sino-810x1562-4_binx8.tiff
-for t in $(ufo-query -l) ; do
- echo ===============================
- echo Parameters for task $t \(ufo-query\)
- echo ------------------------------
- if [ "$t" != "transpose" ] ; then
- ufo-query -pv $t
+let nb_failed=0
+let nb_worked=0
+
+tl=$(ufo-query -l)
+
+ta=($tl)
+
+echo "Found ${#ta[@]} filters in ufo-filters"
+
+for t in $tl; do
+ ## echo ===============================
+ ## echo Parameters for task $t \(ufo-query\)
+ ## echo ------------------------------
+ echo -n "Testing $t : "
+ ufo-query -pv $t 1> /dev/null
+ es=$?
+ if [ $es -eq 0 ] ; then
+ echo '[OK]'
+ let nb_worked=1+$nb_worked
else
- echo "!! Task transpose is producing a SegFault on ufo-query !!"
+ echo '[FAILED]'
+ let nb_failed=1+$nb_failed
fi
- echo
done
+
+echo "$nb_worked filters could be introspected"
+echo "$nb_failed filters could NOT be introspected"
+
+if [ $nb_failed -ne 0 ] ; then
+ exit -1
+fi
--- End Message ---