Bug#1107434: unblock gimp/3.0.4-2
Control: tags -1 -moreinfo
On Thu, Jun 26, 2025 at 2:09 PM Paul Gevers <elbrus@debian.org> wrote:
> 267 files changed, 29797 insertions(+), 26931 deletions(-)
>
> Can you please check our FAQ [1] and answer the questions in the
> new-upstream section?
> 1. Is this a targeted bug fix release, and how does that show?
Yes. There are no new "features" in this update. There were a few UI
fixes but those were limited to either fix regressions or fix
inconsistencies. If the release were not a targeted bug fix release, I
would expect a LOT more UI changes and multiple features.
You can compare with gimp 3.1.2 which was released recently and is
**not** a targeted bug fix release. [1] [2]
> 2. What are the risks of the changes for the quality of the Debian release?
The GIMP maintainers are happy enough with 3.0.4 that they do not
intend to do another 3.0.x release.
> 3. Is there a policy that describes what upstream considers acceptable for this upstream release?
Quoting from the release announcement [1]: "Micro releases like 3.0.4
are focused on fixing bugs and regressions, so there are no major new
features to announce (though we continue to work on those! Just on
separate feature branches for GIMP 3.2)"
> 4. Does that policy align with our bug severity important or higher?
I think so.
I reviewed the commit messages [3] in this update. It's a judgment
call but it's my opinion that these commits (excluding translation and
documentation updates) would classify as severity important or higher.
I have difficulty finding a commit that wouldn't qualify.
> 5. Does upstream test thoroughly?
There is a build test suite which is run as part of the CI for new
commits and merge requests. (It's also run by dh_auto_test in Debian
and failures would fail the build.). I expect it's far from
comprehensive for an app as complex and old as gimp, but it does look
expanded since the 2.10.x series and there were test additions in this
new release.
> 6. Has this package seen new upstream version uploads to stable in the past to facilitate security support?
No
> 7. Look at the diff. If it's long (TODO should we put a number here?), you probably need a targeted fix.
> 8. Look at the diff. If there's a number of changes not relevant for Debian, you probably need a targeted fix.
> 9. Look at the diff. If there something in there that is difficult to explain, but not directly related to the (RC or important) bugs you are fixing, you probably need a targeted fix.
There are significant fixes in the new version. Some examples:
- fix the app icon for KDE on Wayland
- many crash fixes
- many targeted UI fixes, some fix regressions compared to gimp 2
The number of fixes is way too high for the Debian GNOME team to
attempt to cherrypick individual bug fixes. It would still probably be
too much for a person to practically review.
90% of the lines in the massive debdiff are translation updates.
A high percentage of the remaining commits are for build fixes, many
of which are for platforms other than Debian (Windows, AppImage,
Flatpak, macOS).
I apologize for not initially uploading this to experimental and
filing an unblock from there. I misinterpreted the acceptance of the
babl [4] and gegl [5] unblock requests where I explicitly mentioned my
goal of trying to get gimp 3.0.4 into trixie. Clearly, those
acceptances were not the same as a gimp preapproval. I also figured
that my gimp upload and unblock were early enough in the Hard Freeze
that larger omnibus upstream bug fix updates were still reasonable to
take. I will be more careful with my unstable uploads until after
trixie is released.
One final note: the fix for CVE-2025-2760 did not work for 32-bit
platforms [6] [7] so we'll need to do an additional security update. I
guess that's what testing-proposed-updates is for but it could be nice
to use unstable instead.
[1] https://www.gimp.org/news/2025/05/18/gimp-3-0-4-released/
[2] https://www.gimp.org/news/2025/06/23/gimp-3-1-2-released/
[3] https://gitlab.gnome.org/GNOME/gimp/-/commits/GIMP_3_0_4 through March 24
[4] https://bugs.debian.org/1106810
[5] https://bugs.debian.org/1106812
[6] https://bugs.debian.org/1107758
[7] https://gitlab.gnome.org/GNOME/gimp/-/merge_requests/2323
Thank you,
Jeremy Bícha
Reply to: