Bug#1107833: unblock (pre-approval): steam-installer/1:1.0.0.83~ds-3
Control: tags -1 moreinfo confirmed
On 2025-06-15 12:52:32 +0100, Simon McVittie wrote:
> Package: release.debian.org
> Severity: normal
> X-Debbugs-Cc: steam-installer@packages.debian.org
> Control: affects -1 + src:steam-installer
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> Would the release team accept an update to steam-installer? It's a leaf
> package in contrib for users of proprietary software.
Please go ahead. After the upload is available in unstable, please
remove the moreinfo tag.
Cheers
>
> [ Reason ]
> Add a missing dependency, fix AppStream metadata syntax issues, update
> proprietary binaries to upstream's latest stable release
>
> [ Impact ]
> If users install older steam-installer without its transitive Recommends
> (steam-installer -D-> steam-libs-* -D-> libglib2.0-0t64 -R-> xdg-user-dirs)
> then it will log lots of warnings and some functionality will likely not
> work.
>
> In AppStream-based app-store UIs, the developer name won't necessarily
> show up correctly before this version.
>
> Dropping the obsolete alternative dependencies on libc6 (<< 2.29-4) and
> libgcc1 might help apt to find an upgrade path.
>
> [ Tests ]
> The proposed version is in experimental already, and runs successfully.
>
> [ Risks ]
> Low risk, this is a leaf package in contrib and its users will already
> be running the equivalent of this version in practice (see below).
>
> buildutils/add-client-files.py is not actually used in Debian and its
> diff can be ignored. I included it in the source package to illustrate
> where the proprietary files come from, and because it's so permissively
> licensed that there's no reason not to.
>
> [ Checklist ]
> [x] all changes are documented in the d/changelog
> [x] I reviewed all changes and I approve them
> [x] attach debdiff against the package in testing
> - the attached debdiff is testing vs. experimental, an upload to
> unstable would differ from experimental only in the changelog
>
> [ Other info ]
> steam-installer downloads proprietary binaries when it is launched for
> the first time (it doesn't actually contain them, only their URL and
> sha256), and the proprietary binaries are self-updating, so any active
> user of Steam will already have received the new version. The proprietary
> binaries in this particular release have been Valve's stable release
> since 2025-04-02.
>
> However, the self-updating proprietary binaries can't update the
> AppStream metadata in /usr or the package's dependencies, and don't
> currently update the .desktop file either; those are only changed by
> updating steam-installer.
>
> If the release team would prefer a smaller update, I could prepare a
> version targeting trixie that only adds the xdg-user-dirs dependency.
>
> unblock steam-installer/1:1.0.0.83~ds-3
> diffstat for steam-installer-1.0.0.82~ds steam-installer-1.0.0.83~ds
>
> buildutils/add-client-files.py | 6 +++++-
> com.valvesoftware.Steam.metainfo.xml | 7 +++++--
> debian/changelog | 21 +++++++++++++++++++++
> debian/control | 5 +++--
> debian/scripts/steam.in | 10 +++-------
> 5 files changed, 37 insertions(+), 12 deletions(-)
>
> diff -Nru steam-installer-1.0.0.82~ds/buildutils/add-client-files.py steam-installer-1.0.0.83~ds/buildutils/add-client-files.py
> --- steam-installer-1.0.0.82~ds/buildutils/add-client-files.py 2024-10-03 18:47:21.000000000 +0100
> +++ steam-installer-1.0.0.83~ds/buildutils/add-client-files.py 2025-04-24 10:56:50.000000000 +0100
> @@ -54,6 +54,7 @@
> 'steam-runtime-check-requirements', # run by steam.sh
> 'steam-runtime-identify-library-abi', # run by setup.sh
> 'steam-runtime-launch-client', # run by s-r-check-requirements
> + 'steam-runtime-supervisor', # run by steam.sh
> 'srt-logger', # (symlink) run by steam.sh
> )
> BOOTSTRAP_RUNTIME_AMD64_SONAMES = (
> @@ -328,6 +329,7 @@
> rel: str,
> dest: str,
> executable: bool = False,
> + missing_ok: bool = False,
> ) -> None:
> for d in dirs:
> if not d:
> @@ -339,7 +341,8 @@
> self.install(src, dest, executable=executable)
> return
>
> - raise RuntimeError(f'{rel} not found in {dirs}')
> + if not missing_ok:
> + raise RuntimeError(f'{rel} not found in {dirs}')
>
> def _normalize_tar_entry(
> self,
> @@ -468,6 +471,7 @@
> 'steamdeps.txt',
> os.path.join(tmpdir, 'bootstrap', ''),
> executable=False,
> + missing_ok=True,
> )
> self.install_search(
> (self.client_overlay, client_dir),
> diff -Nru steam-installer-1.0.0.82~ds/com.valvesoftware.Steam.metainfo.xml steam-installer-1.0.0.83~ds/com.valvesoftware.Steam.metainfo.xml
> --- steam-installer-1.0.0.82~ds/com.valvesoftware.Steam.metainfo.xml 2025-06-03 10:04:51.000000000 +0100
> +++ steam-installer-1.0.0.83~ds/com.valvesoftware.Steam.metainfo.xml 2025-06-03 10:04:51.000000000 +0100
> @@ -23,10 +23,12 @@
> <category>Game</category>
> <category>PackageManager</category>
> </categories>
> - <url type="homepage">https://store.steampowered.com</url>
> + <url type="homepage">https://store.steampowered.com/</url>
> <url type="bugtracker">https://github.com/ValveSoftware/steam-for-linux/issues</url>
> <project_license>LicenseRef-proprietary</project_license>
> - <developer_name>Valve Corporation</developer_name>
> + <developer id="com.valvesoftware">
> + <name>Valve Corporation</name>
> + </developer>
> <screenshots>
> <screenshot>
> <image type="source" width="1200" height="1026">https://steamcdn-a.akamaihd.net/steamcommunity/public/images/clans/27766192/27b935179076c418c2f62f9440aba9c06161e4c0.jpg</image>
> @@ -40,6 +42,7 @@
> </screenshots>
> <launchable type="desktop-id">steam.desktop</launchable>
> <releases>
> + <release version="1.0.0.83" date="2025-04-24"/>
> <release version="1.0.0.82" date="2024-10-03"/>
> <release version="1.0.0.81" date="2024-08-15"/>
> <release version="1.0.0.80" date="2024-04-22"/>
> diff -Nru steam-installer-1.0.0.82~ds/debian/changelog steam-installer-1.0.0.83~ds/debian/changelog
> --- steam-installer-1.0.0.82~ds/debian/changelog 2025-04-24 13:35:59.000000000 +0100
> +++ steam-installer-1.0.0.83~ds/debian/changelog 2025-06-02 19:23:09.000000000 +0100
> @@ -1,3 +1,24 @@
> +steam-installer (1:1.0.0.83~ds-2) experimental; urgency=medium
> +
> + * steam-installer: Add Depends on xdg-user-dirs.
> + Steam uses xdg-user-dir(1) internally. (Closes: #1106489)
> +
> + -- Simon McVittie <smcv@debian.org> Mon, 02 Jun 2025 19:23:09 +0100
> +
> +steam-installer (1:1.0.0.83~ds-1) experimental; urgency=medium
> +
> + * New upstream beta release
> + - Updated Steam client binary, build 1743554648 (2025-04-02)
> + - Updated Steam Runtime, build 1.0.20250307.120442
> + - Syntactic fixes in AppStream metadata
> + * Revert "d/scripts/steam.in: Adjust URLs used for Desktop Actions in
> + steam.desktop".
> + These have their correct values in the upstream .desktop file now,
> + so we no longer need to hotfix them.
> + * d/control: Drop pre-bookworm alternative dependencies
> +
> + -- Simon McVittie <smcv@debian.org> Thu, 24 Apr 2025 14:30:08 +0100
> +
> steam-installer (1:1.0.0.82~ds-4) unstable; urgency=medium
>
> [ Simon McVittie ]
> diff -Nru steam-installer-1.0.0.82~ds/debian/control steam-installer-1.0.0.83~ds/debian/control
> --- steam-installer-1.0.0.82~ds/debian/control 2025-04-24 13:35:59.000000000 +0100
> +++ steam-installer-1.0.0.83~ds/debian/control 2025-06-02 19:23:09.000000000 +0100
> @@ -30,6 +30,7 @@
> lsof,
> steam-libs (= ${binary:Version}),
> steam-libs-i386 (= ${binary:Version}),
> + xdg-user-dirs,
> zenity | yad,
> ${misc:Depends},
> ${shlibs:Depends},
> @@ -92,9 +93,9 @@
> curl,
> file,
> libcap2 [!i386],
> - libcrypt1 | libc6 (<< 2.29-4),
> + libcrypt1,
> libelf1t64 [!i386] | libelf1 [!i386],
> - libgcc-s1 | libgcc1,
> + libgcc-s1,
> libgl1-mesa-dri,
> libgl1,
> libgpg-error0,
> diff -Nru steam-installer-1.0.0.82~ds/debian/scripts/steam.in steam-installer-1.0.0.83~ds/debian/scripts/steam.in
> --- steam-installer-1.0.0.82~ds/debian/scripts/steam.in 2025-04-24 13:35:59.000000000 +0100
> +++ steam-installer-1.0.0.83~ds/debian/scripts/steam.in 2025-06-02 19:23:09.000000000 +0100
> @@ -88,11 +88,11 @@
> ln -fns "$STEAMDIR" "$STEAMCONFIG/root"
> fi
>
> -version="1.0.0.82"
> +version="1.0.0.83"
> # This only needs to differ from ${version} or be incremented when the
> # installed files from steam-launcher change
> -deb_version="${version}~ds-4"
> -sha256="afa2f1dd6271fd2b645ba30b8f3ab40afd3654e354241a31cbd51000f7e6fc77"
> +deb_version="${version}"
> +sha256="791682b0cc7efd946c7002f917c9dd474d2619b7f9ed00891216a8a6b4ac8f82"
> url="https://repo.steampowered.com/steam/archive/beta/steam_${version}.tar.gz";
> installed="$(cat "$STEAMDIR/deb-installer/version" 2>/dev/null || true)"
> new_installation=
> @@ -193,14 +193,10 @@
> dest="${XDG_DATA_HOME}/applications/steam.desktop"
> mkdir -p "${dest%/*}"
> # Adjust proprietary .desktop file for our installation location
> - # Also hotfix some Desktop Action URLs that no longer work, with the
> - # same replacements as in upstream beta 1.0.0.83
> sed \
> -e '1i#!/usr/bin/env xdg-open' \
> -e '/^Exec=/ s,/usr/bin/steam,/usr/games/steam,g' \
> -e 's,^Exec=steam ,Exec=/usr/games/steam ,' \
> - -e '/^Exec=/ s,steam://open/news,steam://openurl/https://store.steampowered.com/news,g' \
> - -e '/^Exec=/ s,steam://url/SteamIDControlPage,steam://url/CommunityHome/,g' \
> -e '/^Actions=/ a Keywords=Games' \
> < "$STEAMDIR/deb-installer/steam-launcher/steam.desktop" \
> > "$target"
--
Sebastian Ramacher
Reply to: