[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1107374: marked as done (unblock: ayatana-indicator-bluetooth/24.5.0-3)



Your message dated Fri, 06 Jun 2025 16:04:57 +0000
with message-id <E1uNZYv-008QBn-2c@respighi.debian.org>
and subject line unblock ayatana-indicator-bluetooth
has caused the Debian Bug report #1107374,
regarding unblock: ayatana-indicator-bluetooth/24.5.0-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1107374: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1107374
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: ayatana-indicator-bluetooth@packages.debian.org
Control: affects -1 + src:ayatana-indicator-bluetooth
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package ayatana-indicator-bluetooth

In Lomiri Greeter, there is a cogwheel icon shown without functionality.
This is caused by the bluetooth indicator not being started in Lomiri
Greeter.

[ Reason ]
Make basic Bluetooth functionality available in Lomiri Greeter (mainly:
enabling/disabling Bluetooth). This important if e.g. a Bluetooth
keyboard is used and not connected at login time.

[ Impact ]
BT functionality will not be available at login time of the
lomiri-greeter LightDM frontend is used.

[ Tests ]
Manual tests on a Debian trixie test notebook.

[ Risks ]
Minimal, only for users of ayatana-indicator-bluetooth (in Debian,
Ayatana Indicators are not in use by any desktop environment except from
Lomiri).

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
Relevant for Lomiri on Debian.

unblock ayatana-indicator-bluetooth/24.5.0-3
diff -Nru ayatana-indicator-bluetooth-24.5.0/debian/changelog ayatana-indicator-bluetooth-24.5.0/debian/changelog
--- ayatana-indicator-bluetooth-24.5.0/debian/changelog	2025-01-24 10:33:24.000000000 +0100
+++ ayatana-indicator-bluetooth-24.5.0/debian/changelog	2025-06-06 15:39:42.000000000 +0200
@@ -1,3 +1,11 @@
+ayatana-indicator-bluetooth (24.5.0-3) unstable; urgency=medium
+
+  * debian/patches:
+    + Add 0001_Add-desktop-greeter-profile.patch. Show BT indicator also in
+      Lomiri Greeter.
+
+ -- Mike Gabriel <sunweaver@debian.org>  Fri, 06 Jun 2025 15:39:42 +0200
+
 ayatana-indicator-bluetooth (24.5.0-2) unstable; urgency=medium
 
   * debian/control:
diff -Nru ayatana-indicator-bluetooth-24.5.0/debian/patches/0001_Add-desktop-greeter-profile.patch ayatana-indicator-bluetooth-24.5.0/debian/patches/0001_Add-desktop-greeter-profile.patch
--- ayatana-indicator-bluetooth-24.5.0/debian/patches/0001_Add-desktop-greeter-profile.patch	1970-01-01 01:00:00.000000000 +0100
+++ ayatana-indicator-bluetooth-24.5.0/debian/patches/0001_Add-desktop-greeter-profile.patch	2025-05-15 09:45:50.000000000 +0200
@@ -0,0 +1,140 @@
+From 2647235691ad8e6b9c06cc5feff4d362c85e37ab Mon Sep 17 00:00:00 2001
+From: Robert Tari <robert@tari.in>
+Date: Thu, 8 May 2025 23:07:09 +0200
+Subject: [PATCH] Add desktop greeter profile
+
+Fixes https://salsa.debian.org/ubports-team/lomiri/-/issues/44
+
+Signed-off-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
+---
+ data/org.ayatana.indicator.bluetooth |  3 ++
+ src/CMakeLists.txt                   |  9 +++++
+ src/greeter.vala                     | 50 ++++++++++++++++++++++++++++
+ src/service.vala                     |  3 ++
+ 4 files changed, 65 insertions(+)
+ create mode 100644 src/greeter.vala
+
+diff --git a/data/org.ayatana.indicator.bluetooth b/data/org.ayatana.indicator.bluetooth
+index a57ce0a..9f95e01 100644
+--- a/data/org.ayatana.indicator.bluetooth
++++ b/data/org.ayatana.indicator.bluetooth
+@@ -17,3 +17,6 @@ ObjectPath=/org/ayatana/indicator/bluetooth/desktop
+ ObjectPath=/org/ayatana/indicator/bluetooth/phone
+ Position=36
+ 
++[desktop_greeter]
++ObjectPath=/org/ayatana/indicator/bluetooth/greeter
++Position=36
+diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
+index 8770323..6b0a1e2 100644
+--- a/src/CMakeLists.txt
++++ b/src/CMakeLists.txt
+@@ -54,6 +54,14 @@ vala_add(ayatana-indicator-bluetooth-service
+         device
+ )
+ 
++vala_add(ayatana-indicator-bluetooth-service
++    greeter.vala
++        DEPENDS
++        profile
++        bluetooth
++        device
++)
++
+ vala_add(ayatana-indicator-bluetooth-service
+     device.vala
+ )
+@@ -85,6 +93,7 @@ vala_add(ayatana-indicator-bluetooth-service
+         device
+         phone
+         desktop
++        greeter
+ )
+ 
+ vala_finish(ayatana-indicator-bluetooth-service
+diff --git a/src/greeter.vala b/src/greeter.vala
+new file mode 100644
+index 0000000..17c2042
+--- /dev/null
++++ b/src/greeter.vala
+@@ -0,0 +1,50 @@
++/*
++* Copyright 2025 Robert Tari <robert@tari.in>
++*
++* This program is free software; you can redistribute it and/or modify
++* it under the terms of the GNU General Public License as published by
++* the Free Software Foundation; version 3.
++*
++* This program is distributed in the hope that it will be useful,
++* but WITHOUT ANY WARRANTY; without even the implied warranty of
++* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++* GNU General Public License for more details.
++*
++* You should have received a copy of the GNU General Public License
++* along with this program.  If not, see <http://www.gnu.org/licenses/>.
++*/
++
++class Greeter: Profile
++{
++    GLib.SimpleActionGroup action_group;
++
++    public Greeter (Bluetooth bluetooth, GLib.SimpleActionGroup action_group)
++    {
++        base (bluetooth, "greeter");
++        this.bluetooth = bluetooth;
++        this.action_group = action_group;
++        GLib.Action[] actions = {};
++        actions += root_action;
++        actions += create_supported_action (bluetooth);
++        actions += create_enabled_action (bluetooth);
++
++        foreach (GLib.Action action in actions)
++        {
++            action_group.add_action (action);
++        }
++
++        GLib.Menu section = new GLib.Menu ();
++        GLib.MenuItem menu_item = create_enabled_menuitem ();
++        section.append_item (menu_item);
++        menu.append_section (null, section);
++
++        bluetooth.notify.connect (() => update_visibility ());
++        update_visibility ();
++        bluetooth.notify.connect (() => update_root_action_state ());
++    }
++
++    void update_visibility ()
++    {
++        visible = bluetooth.enabled;
++    }
++}
+diff --git a/src/service.vala b/src/service.vala
+index 524175d..80ccea6 100644
+--- a/src/service.vala
++++ b/src/service.vala
+@@ -1,5 +1,6 @@
+ /*
+  * Copyright 2013 Canonical Ltd.
++ * Copyright 2025 Robert Tari
+  *
+  * This program is free software; you can redistribute it and/or modify
+  * it under the terms of the GNU General Public License as published by
+@@ -16,6 +17,7 @@
+  * Authors:
+  *   Charles Kerr <charles.kerr@canonical.com>
+  *   Robert Ancell <robert.ancell@canonical.com>
++ *   Robert Tari <robert@tari.in>
+  */
+ 
+ /**
+@@ -54,6 +56,7 @@ public class Service: Object
+     profiles = new HashTable<string,Profile> (str_hash, str_equal);
+     profiles.insert ("phone", new Phone (bluetooth, actions));
+     profiles.insert ("desktop", new Desktop (bluetooth, actions));
++    profiles.insert ("greeter", new Greeter (bluetooth, actions));
+   }
+ 
+   public int run ()
+-- 
+2.47.2
+
diff -Nru ayatana-indicator-bluetooth-24.5.0/debian/patches/series ayatana-indicator-bluetooth-24.5.0/debian/patches/series
--- ayatana-indicator-bluetooth-24.5.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ ayatana-indicator-bluetooth-24.5.0/debian/patches/series	2025-05-15 09:46:44.000000000 +0200
@@ -0,0 +1 @@
+0001_Add-desktop-greeter-profile.patch

--- End Message ---
--- Begin Message ---
Unblocked ayatana-indicator-bluetooth.

--- End Message ---

Reply to: