[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1107275: marked as done (unblock: alligator/25.04.0-4)



Your message dated Wed, 04 Jun 2025 12:59:54 +0000
with message-id <E1uMnik-005liB-1Z@respighi.debian.org>
and subject line unblock alligator
has caused the Debian Bug report #1107275,
regarding unblock: alligator/25.04.0-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1107275: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1107275
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: alligator@packages.debian.org, ltworf@debian.org
Control: affects -1 + src:alligator
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package alligator

[ Reason ]
I made a small patch to add a "copy URL" button (forwarded upstream)

[ Impact ]
It's a quality of life improvement, I often want to copy the URL of
the article I just read to send it to someone else. Without it I must
open the browser, then copy the url from the browser, then I can share it.

Consider that it's intended for mobile devices, so it's rather annoying to
do all of that because windows switching and selections and copying all happen
with various gestures.

[ Tests ]
I tried it manually on desktop and on tablet. Seems to work fine.

[ Risks ]
The patch is straightforward, I don't see what ill could happen from this.

[ Checklist ]
  [O] all changes are documented in the d/changelog
  [O] I reviewed all changes and I approve them
  [O] attach debdiff against the package in testing

[ Other info ]

unblock alligator/25.04.0-4
diff -Nru alligator-25.04.0/debian/changelog alligator-25.04.0/debian/changelog
--- alligator-25.04.0/debian/changelog	2025-04-30 22:24:58.000000000 +0200
+++ alligator-25.04.0/debian/changelog	2025-06-03 20:14:21.000000000 +0200
@@ -1,3 +1,9 @@
+alligator (25.04.0-4) unstable; urgency=medium
+
+  * Add patch to copy the URL of an article
+
+ -- Salvo 'LtWorf' Tomaselli <ltworf@debian.org>  Tue, 03 Jun 2025 20:14:21 +0200
+
 alligator (25.04.0-3) unstable; urgency=medium
 
   * Team upload.
diff -Nru alligator-25.04.0/debian/patches/000002-copy_url.patch alligator-25.04.0/debian/patches/000002-copy_url.patch
--- alligator-25.04.0/debian/patches/000002-copy_url.patch	1970-01-01 01:00:00.000000000 +0100
+++ alligator-25.04.0/debian/patches/000002-copy_url.patch	2025-06-03 20:14:16.000000000 +0200
@@ -0,0 +1,91 @@
+Description: Add button to copy URL
+ On my tablet, when I want to share a link with someone, currently I must open
+ in the browser, and then in the browser I must copy the URL and then finally
+ I can go to the chat and paste the link.
+ .
+ I think this is easier and I do it at least weekly.
+Author: Salvo 'LtWorf' Tomaselli <ltworf@debian.org>
+Forwarded: https://invent.kde.org/network/alligator/-/merge_requests/143/diffs
+Last-Update: 2025-06-03
+
+--- alligator-25.04.0.orig/src/CMakeLists.txt
++++ alligator-25.04.0/src/CMakeLists.txt
+@@ -12,6 +12,7 @@ add_executable(alligator
+     feedgroupsmodel.cpp
+     feedsproxymodel.cpp
+     contenthelper.cpp
++    clipboard.cpp
+ )
+ 
+ ecm_add_qml_module(alligator URI org.kde.alligator DEPENDENCIES QtCore)
+--- /dev/null
++++ alligator-25.04.0/src/clipboard.cpp
+@@ -0,0 +1,17 @@
++/**
++ * SPDX-FileCopyrightText: 2025 Salvo 'LtWorf' Tomaselli <ltworf@debian.org>
++ *
++ * SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
++ */
++#include <QString>
++#include <QClipboard>
++#include <QGuiApplication>
++
++#include "clipboard.h"
++
++Clipboard::Clipboard() {}
++
++void Clipboard::copy(const QString &text) {
++    QClipboard* cl = QGuiApplication::clipboard();
++    cl->setText(text);
++}
+--- /dev/null
++++ alligator-25.04.0/src/clipboard.h
+@@ -0,0 +1,34 @@
++/**
++ * SPDX-FileCopyrightText: 2025 Salvo 'LtWorf' Tomaselli <ltworf@debian.org>
++ *
++ * SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
++ */
++
++#pragma once
++
++#include <QObject>
++#include <QQmlEngine>
++
++class Clipboard : public QObject
++{
++    Q_OBJECT
++    QML_ELEMENT
++    QML_SINGLETON
++
++public:
++    static Clipboard &instance()
++    {
++        static Clipboard _instance;
++        return _instance;
++    }
++
++    static Clipboard *create(QQmlEngine *, QJSEngine *)
++    {
++        QQmlEngine::setObjectOwnership(&instance(), QQmlEngine::CppOwnership);
++        return &instance();
++    }
++    Q_INVOKABLE void copy(const QString &text);
++
++private:
++    Clipboard();
++};
+--- alligator-25.04.0.orig/src/qml/EntryPage.qml
++++ alligator-25.04.0/src/qml/EntryPage.qml
+@@ -77,6 +77,11 @@ Kirigami.ScrollablePage {
+                 Database.setFavorite(page.entryId, !page.favorite);
+                 page.favorite = !page.favorite;
+             }
++        },
++        Kirigami.Action {
++            text: i18n("Copy URL")
++            icon.name: "copy"
++            onTriggered: Clipboard.copy(page.link)
+         }
+     ]
+ }
diff -Nru alligator-25.04.0/debian/patches/series alligator-25.04.0/debian/patches/series
--- alligator-25.04.0/debian/patches/series	2025-04-30 22:23:19.000000000 +0200
+++ alligator-25.04.0/debian/patches/series	2025-06-03 20:10:23.000000000 +0200
@@ -1 +1,2 @@
 000001-open_in_browser_comes_first.patch
+000002-copy_url.patch

--- End Message ---
--- Begin Message ---
Unblocked alligator.

--- End Message ---

Reply to: