[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1106836: marked as done (unblock: tk9.0/9.0.1-3)



Your message dated Fri, 30 May 2025 10:55:01 +0000
with message-id <E1uKxO9-007So9-0P@respighi.debian.org>
and subject line unblock tk9.0
has caused the Debian Bug report #1106836,
regarding unblock: tk9.0/9.0.1-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1106836: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1106836
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: tk9.0@packages.debian.org
Control: affects -1 + src:tk9.0
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package tk9.0

[ Reason ]
The package fixes annoying bug with the size of fonts in
XFCE session on High DPI displays (see [1]). The displayed
text is twice as large as required by default.

[ Impact ]
The tk9.0 is not the default Tk versio, so the impact of this bug
will be fairly limited. But still it's nice to fix it.

[ Tests ]
There's no a special test for the difference, though they are
pretty trivial and the result can be seen by running a script like the
following:

label .l -text "Test Label"
pack .l

which shows huge text in XFCE session on a displya with DPI higher
than 160 (give or take).

[ Risks ]
The change is trivial, I dont expect any adverse effects for it.

[ Checklist ]
  [+] all changes are documented in the d/changelog
  [+] I reviewed all changes and I approve them
  [+] attach debdiff against the package in testing

[ Other info ]
(Anything else the release team should know.)

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1105050

unblock tk9.0/9.0.1-3
diff -Nru tk9.0-9.0.1/debian/changelog tk9.0-9.0.1/debian/changelog
--- tk9.0-9.0.1/debian/changelog	2025-03-25 12:38:40.000000000 +0300
+++ tk9.0-9.0.1/debian/changelog	2025-05-10 15:26:25.000000000 +0300
@@ -1,3 +1,11 @@
+tk9.0 (9.0.1-3) unstable; urgency=medium
+
+  * Never change ::tk::fontScalingFactor to a number different from 1 to
+    fix very large default fonts on high DPI displays in XFCE sessions
+    (closes: #1105050).
+
+ -- Sergei Golovan <sgolovan@debian.org>  Sat, 10 May 2025 15:26:25 +0300
+
 tk9.0 (9.0.1-2) unstable; urgency=medium
 
   * Move the Tcl part of the Tk library to /usr/lib from /usr/share/tcltk.
diff -Nru tk9.0-9.0.1/debian/patches/fontsizes.diff tk9.0-9.0.1/debian/patches/fontsizes.diff
--- tk9.0-9.0.1/debian/patches/fontsizes.diff	1970-01-01 03:00:00.000000000 +0300
+++ tk9.0-9.0.1/debian/patches/fontsizes.diff	2025-05-10 15:26:25.000000000 +0300
@@ -0,0 +1,24 @@
+From: Sergei Golovan
+Subject: Patch prevents Tk from setting font scaling factor to 2
+ in XFCE session when there is non-unity /Gdk/WindowScalingFactor
+ in effect. Tk font rendering does not depend on this scaling factor,
+ which means that if fontScalingFactor is set to 2 then the default
+ fonts appear twice as large as the correct ones.
+Date: Sat, 10 May 2025 15:17:03 +0300
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1105050
+
+--- a/library/scaling.tcl
++++ b/library/scaling.tcl
+@@ -58,9 +58,9 @@
+ 	    if {[catch {exec xfconf-query -c xsettings \
+ 		 -p /Gdk/WindowScalingFactor} result] == 0} {
+ 		set winScalingFactor $result
+-		if {$winScalingFactor >= 2} {
+-		    set fontScalingFactor 2
+-		}
++		#if {$winScalingFactor >= 2} {
++		#    set fontScalingFactor 2
++		#}
+ 	    }
+ 
+ 	    #
diff -Nru tk9.0-9.0.1/debian/patches/series tk9.0-9.0.1/debian/patches/series
--- tk9.0-9.0.1/debian/patches/series	2025-03-25 12:38:40.000000000 +0300
+++ tk9.0-9.0.1/debian/patches/series	2025-05-10 15:26:25.000000000 +0300
@@ -1,2 +1,3 @@
 tkprivate.diff
 versionedlibtkstub.diff
+fontsizes.diff

--- End Message ---
--- Begin Message ---
Unblocked.

--- End Message ---

Reply to: