[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1106697: unblock: wine/10.0~repack-4



On Wed, 28 May 2025 21:30:03 +0200, Paul Gevers <elbrus@debian.org> wrote:
> On 28-05-2025 08:59, Stephen Kitt wrote:
> > I've tested rebuilds in various scenarios, forcing debian/control
> > rebuilds and checking that regular package rebuilds don't result in a
> > debian/control rebuild.  
> 
> What happens during a binNMU? As I understand it, binNMU's inject an 
> entry in the changelog.

Ah, good question, I don’t know — I’ve simplified the patch so that the
package never rebuilds debian/control automatically, see the attached
debdiff.

>  > wine will be removed from Debian 13 if this isn't fixed (properly).  
> 
> That would also need resolving bug #1104317 one way or another.

Of course, hence the “if” rather than “if and only if” ;-).

Regards,

Stephen
diff -Nru wine-10.0~repack/debian/changelog wine-10.0~repack/debian/changelog
--- wine-10.0~repack/debian/changelog	2025-04-07 04:06:03.000000000 +0200
+++ wine-10.0~repack/debian/changelog	2025-05-28 08:46:37.000000000 +0200
@@ -1,3 +1,13 @@
+wine (10.0~repack-4) unstable; urgency=medium
+
+  * Stop rebuilding debian/control, it won't change for the wine package.
+    The rebuild recipe is preserved so that future changes to
+    debian/control.in can be applied without too much effort, but no
+    rebuild should rebuild debian/control (including binNMUs).
+    Closes: #1079184.
+
+ -- Stephen Kitt <skitt@debian.org>  Wed, 28 May 2025 08:46:37 +0200
+
 wine (10.0~repack-3) unstable; urgency=medium
 
   * Fix dh_strip errors on armhf.
diff -Nru wine-10.0~repack/debian/clean wine-10.0~repack/debian/clean
--- wine-10.0~repack/debian/clean	2025-04-05 08:01:18.000000000 +0200
+++ wine-10.0~repack/debian/clean	2025-05-28 08:42:55.000000000 +0200
@@ -1,6 +1,3 @@
-# control file is automatically generated
-debian/control
-
 # build-related temporary files
 wine
 config.*
diff -Nru wine-10.0~repack/debian/rules wine-10.0~repack/debian/rules
--- wine-10.0~repack/debian/rules	2025-04-07 04:06:03.000000000 +0200
+++ wine-10.0~repack/debian/rules	2025-05-28 08:46:37.000000000 +0200
@@ -248,10 +248,8 @@
 
 override_dh_clean:
 	dh_clean -- $(INSTALLS)
-	make -f debian/rules debian/control
 
 override_dh_auto_clean:
-	make -f debian/rules debian/control
 ifeq (,$(filter $(DEB_HOST_ARCH),i386 amd64))
 	# remove zlib patch on non x86 architectures
 	QUILT_PATCHES=debian/patches quilt pop -af || true

Attachment: pgptFQmCNdjgE.pgp
Description: OpenPGP digital signature


Reply to: