Hi,
在 2025-05-22四的 08:35 +0200，Sebastian Ramacher写道：
> Control: tags -1 moreinfo
>
> On 2025-05-21 20:38:16 -0400, Boyuan Yang wrote:
> > Package: release.debian.org
> > Control: affects -1 + src:fcitx-rime
> > X-Debbugs-Cc: fcitx-rime@packages.debian.org
> > User: release.debian.org@packages.debian.org
> > Usertags: unblock
> > X-Debbugs-Cc: byang@debian.org bird@b1az3.me
> > Severity: normal
> >
> > Please unblock package fcitx-rime
> >
> > [ Reason ]
> > As in https://bugs.debian.org/1106211 ;, the current
> > fcitx-rime/0.3.2+git20230425-6 in Debian Testing cannot be
> > launched due to an undefined symbol problem. This is due to
> > recent changes of librime library. The -7 upload
> > fixes this problem by cherry-pick the patch from Arch Linux
> > side.
>
> So librime dropped a symbol without doing a transition?
>
I reviewed the source code history and it looks like the case. What do you
think would be the best way forward?
* I can prepare an upload of librime to revert the removal of the symbol,
and then request an unblock.
* I am comfortable with having src:fcitx-rime drop out of Debian Testing and
Debian 13, as its upstream is dead now and the whole src:fcitx family will
nevertheless be scheduled for removal in Debian 14.
* It is also okay if you accept this ad-hoc patch for src:fcitx-rime, as
the removed symbol from librime is long deprecated. Other than src:fcitx-rime,
no other consumer, either inside or outside Debian, is known other than
src:fcitx-rime.
Many thanks,
Boyuan Yang
> > The fcitx-rime upstream is now dead, and thus the patch cannot
> > be verified by its original author. Manual code review is
> > performed instead.
> >
> > [ Impact ]
> > The fcitx-rime package as an input method cannot be used
> > by users.
> >
> > [ Tests ]
> > Manually reviewed and manually tested in a Debian Sid and
> > a Debian Testing VM.
> >
> > [ Risks ]
> > The risk level is minimum. The package cannot be further broken
> > anyway.
> >
> > [ Checklist ]
> > [X] all changes are documented in the d/changelog
> > [X] I reviewed all changes and I approve them
> > [X] attach debdiff against the package in testing
> >
> > [ Other info ]
> > Please find the full debdiff in the attachment.
> >
> > unblock fcitx-rime/0.3.2+git20230425-7
> >
> >
> > Thanks,
> > Boyuan Yang
>
> > diff -Nru fcitx-rime-0.3.2+git20230425/debian/changelog fcitx-rime-0.3.2+git20230425/debian/changelog
> > --- fcitx-rime-0.3.2+git20230425/debian/changelog 2025-03-03 12:15:48.000000000 -0500
> > +++ fcitx-rime-0.3.2+git20230425/debian/changelog 2025-05-21 13:16:57.000000000 -0400
> > @@ -1,3 +1,11 @@
> > +fcitx-rime (0.3.2+git20230425-7) unstable; urgency=high
> > +
> > + * Team upload.
> > + * debian/patches/fix-rime-process-key.patch: Fix incompatibility
> > + with recent librime versions. (Closes: #1106211)
> > +
> > + -- Boyuan Yang <byang@debian.org> Wed, 21 May 2025 13:16:57 -0400
> > +
> > fcitx-rime (0.3.2+git20230425-6) unstable; urgency=medium
> >
> > * Team upload.
> > diff -Nru fcitx-rime-0.3.2+git20230425/debian/patches/fix-rime-process-key.patch fcitx-rime-0.3.2+git20230425/debian/patches/fix-rime-process-key.patch
> > --- fcitx-rime-0.3.2+git20230425/debian/patches/fix-rime-process-key.patch 1969-12-31 19:00:00.000000000 -0500
> > +++ fcitx-rime-0.3.2+git20230425/debian/patches/fix-rime-process-key.patch 2025-05-21 13:16:42.000000000 -0400
> > @@ -0,0 +1,32 @@
> > +From 383e6754238dfeaf816afa0f1f2fa5061f835f91 Mon Sep 17 00:00:00 2001
> > +From: Frederick Zhang <frederick888@tsundere.moe>
> > +Date: Sat, 8 Feb 2025 18:37:11 +1100
> > +Subject: [PATCH] Fix undefined symbol RimeProcessKey
> > +
> > +[1] https://github.com/rime/librime/pull/877
> > +
> > +Origin: https://gitlab.archlinux.org/archlinux/packaging/packages/fcitx-rime/-/blob/main/fix-rime-process-key.patch
> > +Bug-Debian: https://bugs.debian.org/1106211
> > +Signed-off-by: Frederick Zhang <frederick888@tsundere.moe>
> > +---
> > + src/fcitx-rime.c | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/src/fcitx-rime.c b/src/fcitx-rime.c
> > +index 906bd81..c1df460 100644
> > +--- a/src/fcitx-rime.c
> > ++++ b/src/fcitx-rime.c
> > +@@ -366,9 +366,9 @@ INPUT_RETURN_VALUE FcitxRimeGetCandWord(void* arg, FcitxCandidateWord* candWord)
> > + }
> > +
> > + boolean FcitxRimePaging(void* arg, boolean prev) {
> > + FcitxRime *rime = (FcitxRime *)arg;
> > +- boolean result = RimeProcessKey(rime->session_id, prev ? FcitxKey_Page_Up : FcitxKey_Page_Down, 0);
> > ++ boolean result = rime->api->process_key(rime->session_id, prev ? FcitxKey_Page_Up : FcitxKey_Page_Down, 0);
> > + if (result) {
> > + FcitxRimeGetCandWords(rime);
> > + FcitxUIUpdateInputWindow(rime->owner);
> > + }
> > +--
> > +2.48.1
> > +
> > diff -Nru fcitx-rime-0.3.2+git20230425/debian/patches/series fcitx-rime-0.3.2+git20230425/debian/patches/series
> > --- fcitx-rime-0.3.2+git20230425/debian/patches/series 2024-12-09 13:15:30.000000000 -0500
> > +++ fcitx-rime-0.3.2+git20230425/debian/patches/series 2025-05-21 13:15:48.000000000 -0400
> > @@ -1 +1,2 @@
> > 0001-Fix-compatibility-with-librime-1.12.patch
> > +fix-rime-process-key.patch
>
>
>
>
Attachment:
signature.asc
Description: This is a digitally signed message part