[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1106328: bookworm-pu: package insighttoolkit4/4.13.3withdata-dfsg2-4+deb12u1



Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: sanvila@debian.org

[ Reason ]
Fix Bug #1105896 FTBFS: Test itkOptImageToImageMetricsTest04 fails on single-cpu systems
(which also happens in this package)

[ Impact ]
Without this update, not everybody will be able to build the package.

[ Tests ]
I've checked that the package builds again for everybody.

[ Risks ]
Very low. No real code changes. The change just removes a few lines in one test, and it has
been already merged upstream.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable
  (actually, the package does not exist anymore in trixie/sid)

[ Changes ]
Add patch fix-itkOptImageToImageMetricsTest04.patch, cherry-picked from upstream.

[ Other info ]
I've already uploaded the package for bookworm.

Note: Bug #1105896 really belongs to "insighttoolkit5". If this is a problem, please
reject the upload and I will reupload with another bug number which is a clone
and a reassign of #1105896.
diff -Nru insighttoolkit4-4.13.3withdata-dfsg2/debian/changelog insighttoolkit4-4.13.3withdata-dfsg2/debian/changelog
--- insighttoolkit4-4.13.3withdata-dfsg2/debian/changelog	2022-11-23 20:50:27.000000000 +0100
+++ insighttoolkit4-4.13.3withdata-dfsg2/debian/changelog	2025-05-22 14:35:00.000000000 +0200
@@ -1,3 +1,11 @@
+insighttoolkit4 (4.13.3withdata-dfsg2-4+deb12u1) bookworm; urgency=medium
+
+  * Team upload.
+  * Make itkOptImageToImageMetricsTest04 not to fail on single-CPU systems.
+    Closes: #1105896.
+
+ -- Santiago Vila <sanvila@debian.org>  Thu, 22 May 2025 14:35:00 +0200
+
 insighttoolkit4 (4.13.3withdata-dfsg2-4) unstable; urgency=medium
 
   * d/rules: add -fno-sized-deallocation; fix ftbfs with gcc-12.
diff -Nru insighttoolkit4-4.13.3withdata-dfsg2/debian/patches/fix-itkOptImageToImageMetricsTest04.patch insighttoolkit4-4.13.3withdata-dfsg2/debian/patches/fix-itkOptImageToImageMetricsTest04.patch
--- insighttoolkit4-4.13.3withdata-dfsg2/debian/patches/fix-itkOptImageToImageMetricsTest04.patch	1970-01-01 01:00:00.000000000 +0100
+++ insighttoolkit4-4.13.3withdata-dfsg2/debian/patches/fix-itkOptImageToImageMetricsTest04.patch	2025-05-22 14:35:00.000000000 +0200
@@ -0,0 +1,27 @@
+From: Niels Dekker <N.Dekker@lumc.nl>
+Subject: Make itkOptImageToImageMetricsTest04 not to fail on single-CPU systems
+Bug-Debian: https://bugs.debian.org/1105896
+Origin: https://github.com/InsightSoftwareConsortium/ITK/commit/57b138cf150e097340b75e7f37eee061da80c627
+Last-Update: 2025-05-16
+
+--- a/Modules/Nonunit/Review/test/itkOptImageToImageMetricsTest2.h
++++ b/Modules/Nonunit/Review/test/itkOptImageToImageMetricsTest2.h
+@@ -80,18 +80,6 @@
+     // so we seed the random number generator
+     // immediately before this call.
+     metric->Initialize();
+-
+-    //Verify that Initialize has properly called
+-    //MultiThreadingInitialize() and a series of CreateAnother();
+-
+-    typedef typename MetricType::TransformPointer TransformPointer;
+-    const TransformPointer *transformPtr= metric->GetThreaderTransform();
+-    if ((transformPtr==static_cast<const TransformPointer *>(ITK_NULLPTR))||
+-        (transformPtr[0].IsNull()))
+-      {
+-      exit(EXIT_FAILURE);
+-      }
+-
+     }
+     //Other registration functionality tested in
+     //OptImageToImageTest.cxx... skip the rest
diff -Nru insighttoolkit4-4.13.3withdata-dfsg2/debian/patches/series insighttoolkit4-4.13.3withdata-dfsg2/debian/patches/series
--- insighttoolkit4-4.13.3withdata-dfsg2/debian/patches/series	2022-11-23 20:50:27.000000000 +0100
+++ insighttoolkit4-4.13.3withdata-dfsg2/debian/patches/series	2025-05-22 14:35:00.000000000 +0200
@@ -14,3 +14,4 @@
 gcc11.patch
 python3.10.patch
 denoise-build-log.patch
+fix-itkOptImageToImageMetricsTest04.patch

Reply to: