[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1106278: marked as done (unblock: insighttoolkit5/5.2.1-5)

Your message dated Thu, 22 May 2025 14:03:00 +0200
with message-id <58e73544-6bb3-4c42-ac93-b70bf4db4b99@debian.org>
and subject line Re: Bug#1106278: unblock: insighttoolkit5/5.2.1-5
has caused the Debian Bug report #1106278,
regarding unblock: insighttoolkit5/5.2.1-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1106278: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1106278
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: insighttoolkit5@packages.debian.org, sanvila@debian.org
Control: affects -1 + src:insighttoolkit5

Please unblock package insighttoolkit5

[ Reason ]
Fix Bug #1105896 FTBFS: Test itkOptImageToImageMetricsTest04 fails on single-cpu systems

[ Impact ]
Without this update, not everybody will be able to build the package.

[ Tests ]
I've checked that the package builds again for everybody.

[ Risks ]
Very low. No real code changes. The change just removes a few lines in one test, and it has
been already merged upstream.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock insighttoolkit5/5.2.1-5
diff -Nru insighttoolkit5-5.4.3/debian/changelog insighttoolkit5-5.4.3/debian/changelog
--- insighttoolkit5-5.4.3/debian/changelog	2025-04-22 06:48:27.000000000 +0200
+++ insighttoolkit5-5.4.3/debian/changelog	2025-05-22 00:40:00.000000000 +0200
@@ -1,3 +1,12 @@
+insighttoolkit5 (5.4.3-5) unstable; urgency=medium
+
+  * Team upload.
+  * Make itkOptImageToImageMetricsTest04 not to fail on single-CPU systems.
+    Closes: #1105896.
+  * Update standards-version.
+
+ -- Santiago Vila <sanvila@debian.org>  Thu, 22 May 2025 00:40:00 +0200
+
 insighttoolkit5 (5.4.3-4) unstable; urgency=medium
 
   [ Steve Robbins ]
diff -Nru insighttoolkit5-5.4.3/debian/control insighttoolkit5-5.4.3/debian/control
--- insighttoolkit5-5.4.3/debian/control	2025-04-22 06:48:27.000000000 +0200
+++ insighttoolkit5-5.4.3/debian/control	2025-05-22 00:40:00.000000000 +0200
@@ -21,7 +21,7 @@
                libminc-dev,
                libnifti2-dev,
                libhdf5-dev
-Standards-Version: 4.6.2
+Standards-Version: 4.7.2
 Vcs-Browser: https://salsa.debian.org/med-team/insighttoolkit
 Vcs-Git: https://salsa.debian.org/med-team/insighttoolkit.git
 Homepage: http://www.itk.org/
diff -Nru insighttoolkit5-5.4.3/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch insighttoolkit5-5.4.3/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
--- insighttoolkit5-5.4.3/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch	1970-01-01 01:00:00.000000000 +0100
+++ insighttoolkit5-5.4.3/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch	2025-05-22 00:40:00.000000000 +0200
@@ -0,0 +1,25 @@
+From: Niels Dekker <N.Dekker@lumc.nl>
+Subject: Make itkOptImageToImageMetricsTest04 not to fail on single-CPU systems
+Bug-Debian: https://bugs.debian.org/1105896
+Origin: https://github.com/InsightSoftwareConsortium/ITK/commit/57b138cf150e097340b75e7f37eee061da80c627
+Last-Update: 2025-05-16
+
+--- a/Modules/Nonunit/Review/test/itkOptImageToImageMetricsTest2.h
++++ b/Modules/Nonunit/Review/test/itkOptImageToImageMetricsTest2.h
+@@ -81,16 +81,6 @@
+     // so we seed the random number generator
+     // immediately before this call.
+     metric->Initialize();
+-
+-    // Verify that Initialize has properly called
+-    // MultiThreadingInitialize() and a series of CreateAnother();
+-
+-    using TransformPointer = typename MetricType::TransformPointer;
+-    const TransformPointer * transformPtr = metric->GetThreaderTransform();
+-    if ((transformPtr == static_cast<const TransformPointer *>(nullptr)) || (transformPtr[0].IsNull()))
+-    {
+-      exit(EXIT_FAILURE);
+-    }
+   }
+   // Other registration functionality tested in
+   // OptImageToImageTest.cxx... skip the rest
diff -Nru insighttoolkit5-5.4.3/debian/patches/series insighttoolkit5-5.4.3/debian/patches/series
--- insighttoolkit5-5.4.3/debian/patches/series	2025-04-22 06:48:27.000000000 +0200
+++ insighttoolkit5-5.4.3/debian/patches/series	2025-05-22 00:40:00.000000000 +0200
@@ -1,3 +1,4 @@
 0001-Fix-building-and-running-with-system-MINC.patch
 0002-fix-build-gcc15.patch
 0003-fix-fftw-include.patch
+0004-fix-itkOptImageToImageMetricsTest04.patch

--- End Message ---
--- Begin Message --- 
Hi,

On 22-05-2025 13:45, Santiago Vila wrote:

Please unblock package insighttoolkit5


done.

Paul

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: