[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1105945: marked as done (unblock: mdanalysis/2.9.0-8)



Your message dated Sat, 17 May 2025 17:42:00 +0000
with message-id <E1uGLXs-000HJ9-2W@respighi.debian.org>
and subject line unblock mdanalysis
has caused the Debian Bug report #1105945,
regarding unblock: mdanalysis/2.9.0-8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1105945: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1105945
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: mdanalysis@packages.debian.org
Control: affects -1 + src:mdanalysis
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package mdanalysis

[ Reason ]

mdanalysis/2.9.0-8 provides an important patch that removes a source of
test flakiness.

[ Impact ]

If this patch is not allowed into trixe, the flaky test will cause
debci testing for trixie to regularly and randmonly report failed tests.

[ Tests ]

Upstream provides extensive testing, which is in fact is the problem
addressed here. One of their tests (test_distance) is consistently
flaky and is skipped in this package release. With that, 2.9.0-8 is
more consistently passing debci tests.

debci switched off testing on riscv64, which is why this unblock
request is needed.

[ Risks ]

Negligible risk. 2.9.0-7 is already in testing. This patch simply
removes a regularly failing test, so should make testing in trixie
more reliable.


[ Checklist ]
  [x ] all changes are documented in the d/changelog
  [x ] I reviewed all changes and I approve them
  [x ] attach debdiff against the package in testing

[ Other info ]
mdanalysis has a generally flaky collection of tests. Other tests
might continue to randomly fail from time, but debci tests are more
reliable with this patch skipping test_distance

unblock mdanalysis/2.9.0-8
diff -Nru mdanalysis-2.9.0/debian/changelog mdanalysis-2.9.0/debian/changelog
--- mdanalysis-2.9.0/debian/changelog	2025-04-23 10:50:06.000000000 +0200
+++ mdanalysis-2.9.0/debian/changelog	2025-05-11 23:44:46.000000000 +0200
@@ -1,3 +1,11 @@
+mdanalysis (2.9.0-8) unstable; urgency=medium
+
+  * skip test_distances, since NSGrid is flaky and causes distance
+    tests to often (randomly) fail, see upstream Issue #4906.
+    Closes: #1104387
+
+ -- Drew Parsons <dparsons@debian.org>  Sun, 11 May 2025 23:44:46 +0200
+
 mdanalysis (2.9.0-7) unstable; urgency=medium
 
   * skip all parallel tests, including multiprocess tests.
diff -Nru mdanalysis-2.9.0/debian/rules mdanalysis-2.9.0/debian/rules
--- mdanalysis-2.9.0/debian/rules	2025-04-23 10:50:06.000000000 +0200
+++ mdanalysis-2.9.0/debian/rules	2025-05-11 23:44:46.000000000 +0200
@@ -9,13 +9,17 @@
 # parallel and openmp tests are unstable, often timing out
 SKIP_TEST_LIST += parallel multiprocess openmp
 
+# gsd tends to induce test time-outs, https://github.com/MDAnalysis/mdanalysis/issues/4209
+SKIP_TEST_LIST += gsd GSD
+
+# NSGrid is flaky and causes distance tests to often (randomly) fail
+# https://github.com/MDAnalysis/mdanalysis/issues/4906
+SKIP_TEST_LIST += test_distances
+
 # mdahole2, pathsimanalysis are not yet packaged for debian
 # (duecredit test journal.pcbi.1004568 accesses pathsimanalysis)
 SKIP_TEST_LIST += test_all_import[.analysis.hole2] journal.pcbi.1004568
 
-# gsd tends to induce test time-outs, https://github.com/MDAnalysis/mdanalysis/issues/4209
-SKIP_TEST_LIST += gsd GSD
-
 ifneq (,$(findstring $(DEB_HOST_ARCH), i386))
   export DEB_CFLAGS_MAINT_APPEND += -ffloat-store -fexcess-precision=fast
 
diff -Nru mdanalysis-2.9.0/debian/tests/test-mdanalysis mdanalysis-2.9.0/debian/tests/test-mdanalysis
--- mdanalysis-2.9.0/debian/tests/test-mdanalysis	2025-04-23 10:50:06.000000000 +0200
+++ mdanalysis-2.9.0/debian/tests/test-mdanalysis	2025-05-11 23:44:46.000000000 +0200
@@ -15,6 +15,10 @@
 # gsd tends to induce test time-outs, https://github.com/MDAnalysis/mdanalysis/issues/4209
 SKIP_TEST_LIST=("${SKIP_TEST_LIST[@]}" gsd GSD)
 
+# NSGrid is flaky and causes distance tests to often (randomly) fail
+# https://github.com/MDAnalysis/mdanalysis/issues/4906
+SKIP_TEST_LIST=("${SKIP_TEST_LIST[@]}" test_distances)
+
 # mdahole2, pathsimanalysis are not yet packaged for debian
 # (duecredit test journal.pcbi.1004568 accesses pathsimanalysis)
 SKIP_TEST_LIST=("${SKIP_TEST_LIST[@]}" test_all_import[.analysis.hole2] journal.pcbi.1004568)

--- End Message ---
--- Begin Message ---
Unblocked.

--- End Message ---

Reply to: