[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1094495: marked as done (bookworm-pu: package golang-github-containers-buildah/1.28.2+ds1-3+deb12u1)

Your message dated Sat, 15 Mar 2025 09:44:44 +0000
with message-id <E1ttO4S-005KjT-80@coccia.debian.org>
and subject line Close 1094495
has caused the Debian Bug report #1094495,
regarding bookworm-pu: package golang-github-containers-buildah/1.28.2+ds1-3+deb12u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1094495: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1094495
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: golang-github-containers-buildah@packages.debian.org, team+pkg-go@tracker.debian.org, siretart@tauware.de
Control: affects -1 + src:golang-github-containers-buildah

[ Reason ]

golang-github-containers-buildah in bookworm FTBFS on the buildds since unshare
became the default.

[ Impact ]

Policy violation for golang-github-containers-buildah (must build on the
autobuild network) and inability to fix any other issues since it can't be
built.

[ Tests ]

The issue is in a test anyway, which is now disabled. This is straight backport
of a patch already in sid and testing.  Manual comparison of building
1.28.2+ds1-3 and +deb12u1 verifies that the build is fixed in an sbuild unshare
environment.

[ Risks ]

Low. Backports a single patch to the test suite which has been in sid for some
time.

This is effectively an NMU, package maintainers and patch author in CC - please
shout if you have any objections.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]

diff -Nru golang-github-containers-buildah-1.28.2+ds1/debian/changelog golang-github-containers-buildah-1.28.2+ds1/debian/changelog
--- golang-github-containers-buildah-1.28.2+ds1/debian/changelog	2023-04-29 20:57:39.000000000 +0100
+++ golang-github-containers-buildah-1.28.2+ds1/debian/changelog	2025-01-27 18:43:31.000000000 +0000
@@ -1,3 +1,10 @@
+golang-github-containers-buildah (1.28.2+ds1-3+deb12u1) bookworm; urgency=medium
+
+  * Backport 0005-Disable-TestDeviceFromPath.patch:
+    fix FTBFS by skipping TestDeviceFromPath (closes: #1072147)
+
+ -- Jonathan Wiltshire <jmw@debian.org>  Mon, 27 Jan 2025 18:43:31 +0000
+
 golang-github-containers-buildah (1.28.2+ds1-3) unstable; urgency=medium
 
   * reupload
diff -Nru golang-github-containers-buildah-1.28.2+ds1/debian/patches/0005-Disable-TestDeviceFromPath.patch golang-github-containers-buildah-1.28.2+ds1/debian/patches/0005-Disable-TestDeviceFromPath.patch
--- golang-github-containers-buildah-1.28.2+ds1/debian/patches/0005-Disable-TestDeviceFromPath.patch	1970-01-01 01:00:00.000000000 +0100
+++ golang-github-containers-buildah-1.28.2+ds1/debian/patches/0005-Disable-TestDeviceFromPath.patch	2025-01-27 18:42:25.000000000 +0000
@@ -0,0 +1,21 @@
+From: Reinhard Tartler <siretart@tauware.de>
+Date: Wed, 10 Jul 2024 21:16:08 -0400
+Subject: Disable TestDeviceFromPath
+
+Closes: #1072147
+---
+ pkg/parse/parse_test.go | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/pkg/parse/parse_test.go b/pkg/parse/parse_test.go
+index c1f8833..6acf52f 100644
+--- a/pkg/parse/parse_test.go
++++ b/pkg/parse/parse_test.go
+@@ -87,6 +87,7 @@ func TestIsValidDeviceMode(t *testing.T) {
+ }
+ 
+ func TestDeviceFromPath(t *testing.T) {
++	t.Skip("Test unsuitable for debian, see https://bugs.debian.org/1072147";)
+ 	if runtime.GOOS != "linux" {
+ 		t.Skip("Devices is only supported on Linux")
+ 	}
diff -Nru golang-github-containers-buildah-1.28.2+ds1/debian/patches/series golang-github-containers-buildah-1.28.2+ds1/debian/patches/series
--- golang-github-containers-buildah-1.28.2+ds1/debian/patches/series	2023-04-29 20:57:39.000000000 +0100
+++ golang-github-containers-buildah-1.28.2+ds1/debian/patches/series	2025-01-27 18:42:25.000000000 +0000
@@ -1 +1,2 @@
 manpage-fixes.patch
+0005-Disable-TestDeviceFromPath.patch

--- End Message ---
--- Begin Message --- 
Version: 12.10
This update has been released as part of 12.10. Thank you for your contribution.

--- End Message ---
Reply to: