[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1079350: marked as done (bookworm-pu: package calamares-settings-debian/12.0.9-1+deb12u1)

Your message dated Sat, 31 Aug 2024 12:34:14 +0100
with message-id <9e3e8b8cd0db3b52d4adb2cfad04baa007c8e3e8.camel@adam-barratt.org.uk>
and subject line Closing bugs for 12.7
has caused the Debian Bug report #1079350,
regarding bookworm-pu: package calamares-settings-debian/12.0.9-1+deb12u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1079350: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1079350
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
X-Debbugs-Cc: calamares-settings-debian@packages.debian.org
Control: affects -1 + src:calamares-settings-debian
User: release.debian.org@packages.debian.org
Usertags: pu

[ Reason ]
When launching the desktop icon "Install Debian" from an Xfce session,
a user will get a notification that the launcher is not trusted.
Adding the gio tools and some snippets to mark the application as
trusted fixes this issue.

[ Impact ]
It's an annoying and somewhat confusing message, and would be nice to
fix for the next point release.

[ Tests ]
I tested this manually on the current 12.6.0 iso and it works fine.

[ Risks ]
This is a reasonably trivial fix, and poses a low risk.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Debdiff ]
"""
diff -Nru calamares-settings-debian-12.0.9/debian/changelog calamares-settings-debian-12.0.9/debian/changelog
--- calamares-settings-debian-12.0.9/debian/changelog   2023-05-04 20:47:17.000000000 +0200
+++ calamares-settings-debian-12.0.9/debian/changelog   2024-08-22 16:35:51.000000000 +0200
@@ -1,3 +1,10 @@
+calamares-settings-debian (12.0.9-1+deb12u1) bookworm; urgency=medium
+
+  * Fix Xfce launcher permission issue (Closes: #1037299)
+    - Add new dependency: libglib2.0-bin
+
+ -- Jonathan Carter <jcc@debian.org>  Thu, 22 Aug 2024 16:35:51 +0200
+
 calamares-settings-debian (12.0.9-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru calamares-settings-debian-12.0.9/debian/control calamares-settings-debian-12.0.9/debian/control
--- calamares-settings-debian-12.0.9/debian/control     2023-04-04 09:51:00.000000000 +0200
+++ calamares-settings-debian-12.0.9/debian/control     2024-08-22 16:35:51.000000000 +0200
@@ -13,6 +13,7 @@
 Architecture: all
 Depends: calamares,
          cryptsetup,
+        libglib2.0-bin,
          keyutils,
          pkexec,
          qml-module-qtquick-window2,
diff -Nru calamares-settings-debian-12.0.9/debian/patches/fix-xfce-launcher calamares-settings-debian-12.0.9/debian/patches/fix-xfce-launcher
--- calamares-settings-debian-12.0.9/debian/patches/fix-xfce-launcher   1970-01-01 02:00:00.000000000 +0200
+++ calamares-settings-debian-12.0.9/debian/patches/fix-xfce-launcher   2024-08-22 16:35:51.000000000 +0200
@@ -0,0 +1,22 @@
+Description: Fix Xfce launcher 
+ Add gio bits to script so that Xfce doesn't complain about launcher icon
+ (Closes: #1037299)
+Author: Jonathan Carter <jcc@debian.org>
+Last-Update: 2024-08-22
+
+--- calamares-settings-debian-12.0.9.orig/add-calamares-desktop-icon
++++ calamares-settings-debian-12.0.9/add-calamares-desktop-icon
+@@ -25,3 +25,13 @@ else
+     # else doesn't seem to care either way.
+     chmod +x $DESKTOP/install-debian.desktop
+ fi
++
++if [ "$XDG_CURRENT_DESKTOP" = "XFCE" ]; then 
++    #Set desktop launcher as trusted under gnome/xfce (See: #1037299)
++    gio set --type=string ~/Desktop/install-debian.desktop \
++        metadata::trusted true
++    gio set --type=string ~/Desktop/install-debian.desktop \
++        metadata::xfce-exe-checksum \
++        "$(sha256sum ~/Desktop/install-debian.desktop | cut -f1 -d' ')"
++    touch ~/Desktop/install-debian.desktop
++fi
diff -Nru calamares-settings-debian-12.0.9/debian/patches/series calamares-settings-debian-12.0.9/debian/patches/series
--- calamares-settings-debian-12.0.9/debian/patches/series      1970-01-01 02:00:00.000000000 +0200
+++ calamares-settings-debian-12.0.9/debian/patches/series      2024-08-22 16:35:51.000000000 +0200
@@ -0,0 +1 @@
+fix-xfce-launcher
"""

thanks!

-Jonathan

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 12.7

Hi,

Each of these bugs relates to an update including in today's bookworm
12.7 point release.

Regards,

Adam

--- End Message ---
Reply to: