Bug#1068242: bookworm-pu: package libtool/2.4.7-7~deb12u1
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: Alastair McKinstry <mckinstry@debian.org>
[ Reason ]
I'd like to rebuild libtool from sid in order to fix two RC bugs:
* missing Conflicts against an obsolete (now virtual) package name
causing file conflicts on some upgrade paths of systems initially
installed while the obsolete package was still a real package
* incorrect detection of the += feature causing problems for packages
using it
[ Impact ]
Some upgrade paths not working (mostly triggered by QA tools).
Operator += not working.
[ Tests ]
Manual piuparts upgrade tests of the affected upgrade paths.
Both changes have been in sid since July without followup issues.
[ Risks ]
In case of regression, we could revert each of the two fixes
separately.
[ Checklist ]
[*] *all* changes are documented in the d/changelog
[*] I reviewed all changes and I approve them
[*] attach debdiff against the package in (old)stable
[*] the issue is verified as fixed in unstable
[ Changes ]
+libtool (2.4.7-7~deb12u1) bookworm; urgency=medium
+
+ * Non-maintainer upload.
+ * Rebuild for bookworm.
+ * Reinstate obsolete Breaks, Provides.
+
+ -- Andreas Beckmann <anbe@debian.org> Thu, 28 Mar 2024 13:23:40 +0100
+
+libtool (2.4.7-7) unstable; urgency=medium
+
+ * Remove obsole Breaks: for oldstable , Provides: libltdl7-dev
+ * Replace Breaks: libltdl3-dev with Conflicts: libltdl3-dev.
+ Thanks Andreas Beckmann. Closes: #1041229
+
+ -- Alastair McKinstry <mckinstry@debian.org> Mon, 17 Jul 2023 16:03:58 +0100
+
+libtool (2.4.7-6) unstable; urgency=medium
+
+ * Incorrect check for += operator causes func_append to fail
+ Patch from Ernesto Alfonso. Closes: #1039612
+ * Standards-Version: 4.6.2
+ * Add Breaks/Replaces on libtldl3-dev. Closes: #1039583
+
+ -- Alastair McKinstry <mckinstry@debian.org> Sat, 15 Jul 2023 09:09:39 +0100
changelog | 25 ++++++++
control | 4 +
patches/0090-shell-op.patch | 126 ++++++++++++++++++++++++++++++++++++++++++++
patches/series | 1
4 files changed, 155 insertions(+), 1 deletion(-)
[ Other info ]
This is a rebuild of the package from sid with the removal of some
obsolete Breaks/Replaces reverted to minimize the diff from stable.
There is an unneeded and useless (because misspelled) Replaces being
added. I'm not fixing (i.e. dropping) that because it's harmless and I
do not want to deviate from sid too much.
Andreas
diff -Nru libtool-2.4.7/debian/changelog libtool-2.4.7/debian/changelog
--- libtool-2.4.7/debian/changelog 2022-11-23 12:34:12.000000000 +0100
+++ libtool-2.4.7/debian/changelog 2024-03-28 13:23:40.000000000 +0100
@@ -1,3 +1,28 @@
+libtool (2.4.7-7~deb12u1) bookworm; urgency=medium
+
+ * Non-maintainer upload.
+ * Rebuild for bookworm.
+ * Reinstate obsolete Breaks, Provides.
+
+ -- Andreas Beckmann <anbe@debian.org> Thu, 28 Mar 2024 13:23:40 +0100
+
+libtool (2.4.7-7) unstable; urgency=medium
+
+ * Remove obsole Breaks: for oldstable , Provides: libltdl7-dev
+ * Replace Breaks: libltdl3-dev with Conflicts: libltdl3-dev.
+ Thanks Andreas Beckmann. Closes: #1041229
+
+ -- Alastair McKinstry <mckinstry@debian.org> Mon, 17 Jul 2023 16:03:58 +0100
+
+libtool (2.4.7-6) unstable; urgency=medium
+
+ * Incorrect check for += operator causes func_append to fail
+ Patch from Ernesto Alfonso. Closes: #1039612
+ * Standards-Version: 4.6.2
+ * Add Breaks/Replaces on libtldl3-dev. Closes: #1039583
+
+ -- Alastair McKinstry <mckinstry@debian.org> Sat, 15 Jul 2023 09:09:39 +0100
+
libtool (2.4.7-5) unstable; urgency=medium
* Standards-Version: 4.6.1
diff -Nru libtool-2.4.7/debian/control libtool-2.4.7/debian/control
--- libtool-2.4.7/debian/control 2022-11-23 12:34:12.000000000 +0100
+++ libtool-2.4.7/debian/control 2024-03-28 13:23:32.000000000 +0100
@@ -13,7 +13,7 @@
Section: devel
Priority: optional
Maintainer: Alastair McKinstry <mckinstry@debian.org>
-Standards-Version: 4.6.1
+Standards-Version: 4.6.2
Rules-Requires-Root: no
Homepage: https://www.gnu.org/software/libtool/
Vcs-Browser: https://salsa.debian.org:/mckinstry/libtool.git
@@ -96,6 +96,8 @@
Section: libdevel
Suggests: libtool-doc
Provides: libltdl3-dev, libltdl7-dev
+Conflicts: libltdl3-dev
+Replaces: libbtldl3-dev
Recommends: libtool
Depends: libltdl7 (= ${binary:Version}), ${misc:Depends}, ${automake}
Description: System independent dlopen wrapper for GNU libtool (headers)
diff -Nru libtool-2.4.7/debian/patches/0090-shell-op.patch libtool-2.4.7/debian/patches/0090-shell-op.patch
--- libtool-2.4.7/debian/patches/0090-shell-op.patch 1970-01-01 01:00:00.000000000 +0100
+++ libtool-2.4.7/debian/patches/0090-shell-op.patch 2023-07-17 17:03:58.000000000 +0200
@@ -0,0 +1,126 @@
+Author: Ernesto Alfonso <erjoalgo@gmail.com>
+Description: Incorrect check for += operator causes func_append to fail
+Bug-Origin: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039612
+Forwarded: no
+Last-Updated: 2023-07-15
+
+--- a/bootstrap
++++ b/bootstrap
+@@ -227,7 +227,7 @@
+
+ # Source required external libraries:
+ # Set a version string for this script.
+-scriptversion=2019-02-19.15; # UTC
++scriptversion=2023-07-15.07; # UTC
+
+ # General shell script boiler plate, and helper functions.
+ # Written by Gary V. Vaughan, 2004
+@@ -735,27 +735,15 @@
+ # ---------------------
+ # Append VALUE onto the existing contents of VAR.
+
+- # We should try to minimise forks, especially on Windows where they are
+- # unreasonably slow, so skip the feature probes when bash or zsh are
+- # being used:
+- if test set = "${BASH_VERSION+set}${ZSH_VERSION+set}"; then
+- : ${_G_HAVE_ARITH_OP="yes"}
+- : ${_G_HAVE_XSI_OPS="yes"}
+- # The += operator was introduced in bash 3.1
+- case $BASH_VERSION in
+- [12].* | 3.0 | 3.0*) ;;
+- *)
+- : ${_G_HAVE_PLUSEQ_OP="yes"}
+- ;;
+- esac
+- fi
+-
+- # _G_HAVE_PLUSEQ_OP
+- # Can be empty, in which case the shell is probed, "yes" if += is
+- # useable or anything else if it does not work.
+- test -z "$_G_HAVE_PLUSEQ_OP" \
+- && (eval 'x=a; x+=" b"; test "a b" = "$x"') 2>/dev/null \
+- && _G_HAVE_PLUSEQ_OP=yes
++ # _G_HAVE_PLUSEQ_OP
++ # Can be empty, in which case the shell is probed, "yes" if += is
++ # useable or anything else if it does not work.
++ if test -z "$_G_HAVE_PLUSEQ_OP" && \
++ __PLUSEQ_TEST="a" && \
++ __PLUSEQ_TEST+=" b" 2>/dev/null && \
++ test "a b" = "$__PLUSEQ_TEST"; then
++ _G_HAVE_PLUSEQ_OP=yes
++ fi
+
+ if test yes = "$_G_HAVE_PLUSEQ_OP"
+ then
+--- a/build-aux/funclib.sh
++++ b/build-aux/funclib.sh
+@@ -507,27 +507,15 @@
+ # ---------------------
+ # Append VALUE onto the existing contents of VAR.
+
+- # We should try to minimise forks, especially on Windows where they are
+- # unreasonably slow, so skip the feature probes when bash or zsh are
+- # being used:
+- if test set = "${BASH_VERSION+set}${ZSH_VERSION+set}"; then
+- : ${_G_HAVE_ARITH_OP="yes"}
+- : ${_G_HAVE_XSI_OPS="yes"}
+- # The += operator was introduced in bash 3.1
+- case $BASH_VERSION in
+- [12].* | 3.0 | 3.0*) ;;
+- *)
+- : ${_G_HAVE_PLUSEQ_OP="yes"}
+- ;;
+- esac
+- fi
+-
+ # _G_HAVE_PLUSEQ_OP
+ # Can be empty, in which case the shell is probed, "yes" if += is
+ # useable or anything else if it does not work.
+- test -z "$_G_HAVE_PLUSEQ_OP" \
+- && (eval 'x=a; x+=" b"; test "a b" = "$x"') 2>/dev/null \
+- && _G_HAVE_PLUSEQ_OP=yes
++ if test -z "$_G_HAVE_PLUSEQ_OP" && \
++ __PLUSEQ_TEST="a" && \
++ __PLUSEQ_TEST+=" b" 2>/dev/null && \
++ test "a b" = "$__PLUSEQ_TEST"; then
++ _G_HAVE_PLUSEQ_OP=yes
++ fi
+
+ if test yes = "$_G_HAVE_PLUSEQ_OP"
+ then
+--- a/build-aux/ltmain.sh
++++ b/build-aux/ltmain.sh
+@@ -572,27 +572,15 @@
+ # ---------------------
+ # Append VALUE onto the existing contents of VAR.
+
+- # We should try to minimise forks, especially on Windows where they are
+- # unreasonably slow, so skip the feature probes when bash or zsh are
+- # being used:
+- if test set = "${BASH_VERSION+set}${ZSH_VERSION+set}"; then
+- : ${_G_HAVE_ARITH_OP="yes"}
+- : ${_G_HAVE_XSI_OPS="yes"}
+- # The += operator was introduced in bash 3.1
+- case $BASH_VERSION in
+- [12].* | 3.0 | 3.0*) ;;
+- *)
+- : ${_G_HAVE_PLUSEQ_OP="yes"}
+- ;;
+- esac
+- fi
+-
+ # _G_HAVE_PLUSEQ_OP
+ # Can be empty, in which case the shell is probed, "yes" if += is
+ # useable or anything else if it does not work.
+- test -z "$_G_HAVE_PLUSEQ_OP" \
+- && (eval 'x=a; x+=" b"; test "a b" = "$x"') 2>/dev/null \
+- && _G_HAVE_PLUSEQ_OP=yes
++ if test -z "$_G_HAVE_PLUSEQ_OP" && \
++ __PLUSEQ_TEST="a" && \
++ __PLUSEQ_TEST+=" b" 2>/dev/null && \
++ test "a b" = "$__PLUSEQ_TEST"; then
++ _G_HAVE_PLUSEQ_OP=yes
++ fi
+
+ if test yes = "$_G_HAVE_PLUSEQ_OP"
+ then
diff -Nru libtool-2.4.7/debian/patches/series libtool-2.4.7/debian/patches/series
--- libtool-2.4.7/debian/patches/series 2022-11-23 12:34:12.000000000 +0100
+++ libtool-2.4.7/debian/patches/series 2023-07-17 17:03:58.000000000 +0200
@@ -20,3 +20,4 @@
0075-remove-dates-from-docs.patch
0080-struct-names.patch
0085-tcc-path.patch
+0090-shell-op.patch
Reply to: