Bug#1061652: bookworm-pu: package rss-glx/0.9.1-6.4+deb12u1
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: rss-glx@packages.debian.org
Control: affects -1 + src:rss-glx
[ Reason ]
The current rss-glx package in Bookworm contains two bugs that
render it unusable for a large percentage of its target audience
without direct intervention (to move files to the correct location)
or recompilation (if the user's GPU doesn't automatically flush
before buffer swap).
[ Impact ]
rss-glx continues to silently fail for a significant proportion
of its target user base.
[ Tests ]
Tested in several modes on a POWER host with an AMD GPU, using
the open source GPU drivers.
[ Risks ]
The only risk would be potentially triggering a latent GPU driver
bug that I am unaware of on non-AMD hardware. Such a bug would
need to be fixed in the relevant driver, as the operation order
now used in the updated rss-glx source is correct per standards.
[ Checklist ]
[X] *all* changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in (old)stable
[X] the issue is verified as fixed in unstable
[ Changes ]
* debian/patches/glfinish.patch: Call GLFinish() prior to glXSwapBuffers()
(Closes: #1061507)
* Install screensavers into /usr/libexec/xscreensaver (Closes: #979490)
dpkg-source: warning: extracting unsigned source package (/disk2/SCREENSAVERS/NEW.FOR_UPLOAD/rss-glx_0.9.1-6.4.dsc)
diff -Nru rss-glx-0.9.1/debian/changelog rss-glx-0.9.1/debian/changelog
--- rss-glx-0.9.1/debian/changelog 2021-10-16 08:11:19.000000000 -0500
+++ rss-glx-0.9.1/debian/changelog 2024-01-27 08:41:00.000000000 -0600
@@ -1,3 +1,12 @@
+rss-glx (0.9.1-6.4) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * debian/patches/glfinish.patch: Call GLFinish() prior to glXSwapBuffers()
+ (Closes: #1061507)
+ * Install screensavers into /usr/libexec/xscreensaver (Closes: #979490)
+
+ -- Timothy Pearson <tpearson@raptorengineering.com> Sat, 27 Jan 2024 08:41:00 -0600
+
rss-glx (0.9.1-6.3) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru rss-glx-0.9.1/debian/patches/glfinish.patch rss-glx-0.9.1/debian/patches/glfinish.patch
--- rss-glx-0.9.1/debian/patches/glfinish.patch 1969-12-31 18:00:00.000000000 -0600
+++ rss-glx-0.9.1/debian/patches/glfinish.patch 2024-01-25 10:43:27.000000000 -0600
@@ -0,0 +1,12 @@
+Index: rss-glx-0.9.1/src/driver.c
+===================================================================
+--- rss-glx-0.9.1.orig/src/driver.c
++++ rss-glx-0.9.1/src/driver.c
+@@ -238,6 +238,7 @@
+
+ if (drawEnabled) {
+ hack_draw (XStuff, (double)now.tv_sec + now.tv_usec / 1000000.0f, frameTimeSoFar / 1000000.0f);
++ glFinish();
+
+ glXSwapBuffers (XStuff->display, XStuff->window);
+ }
diff -Nru rss-glx-0.9.1/debian/patches/series rss-glx-0.9.1/debian/patches/series
--- rss-glx-0.9.1/debian/patches/series 2021-10-16 08:05:56.000000000 -0500
+++ rss-glx-0.9.1/debian/patches/series 2024-01-27 08:41:00.000000000 -0600
@@ -2,3 +2,4 @@
pixelcity-cpp.patch
readme.patch
include-cstddef.patch
+glfinish.patch
diff -Nru rss-glx-0.9.1/debian/rules rss-glx-0.9.1/debian/rules
--- rss-glx-0.9.1/debian/rules 2011-05-27 10:01:25.000000000 -0500
+++ rss-glx-0.9.1/debian/rules 2024-01-27 08:41:00.000000000 -0600
@@ -15,12 +15,12 @@
override_dh_auto_configure:
dh_auto_configure -- --with-configdir=/usr/share/xscreensaver/config \
--with-kdessconfigdir=/usr/share/kde4/services/ScreenSavers \
- --bindir=/usr/lib/xscreensaver --enable-static=no \
+ --bindir=/usr/libexec/xscreensaver --enable-static=no \
LDFLAGS=-Wl,--as-needed
override_dh_auto_install:
dh_auto_install
- mv $(CURDIR)/debian/rss-glx/usr/lib/xscreensaver/rss-glx_install.pl \
+ mv $(CURDIR)/debian/rss-glx/usr/libexec/xscreensaver/rss-glx_install.pl \
$(CURDIR)/debian/rss-glx/usr/bin/rss-glx_install
cp $(CURDIR)/debian/desktop_files/*.desktop \
$(CURDIR)/debian/rss-glx/usr/share/applications/screensavers
Reply to: