Hi Eberhard, On 27-04-2023 16:48, Eberhard Beilharz wrote:
After the installation of ibus-keyman the ibus daemon needs to be restarted which is what the `postinst` script tries to do. It restarts or stops ibus-daemon, then checks if ibus-daemon is running - if not it will start it. If any of these steps fail we still want to successfully finish the installation. Since then ibus is not running the user will not be able to see any installed Keyman keyboards and will have to logout or reboot which will start ibus.
But without the failure, how will the user know this? Also, please consider policy 10.4 which says:
""" Every script should use set -e or check the exit status of every command. """Which you are moving away from. Is the failure to start happening that often? Is there a bug report about it?
If we return with a non-exit code from the postinst script instead the installation of ibus-keyman aborts. The user can then try to install again which might lead into the same error, leaving him with an uninstallable ibus-keyman where the only thing that failed was the failure to (re-)start ibus.
It feels weird to use "only" when referring to failure to (re)start a service. Can you elaborate? Shouldn't that have it's own RC bug?
Paul
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature