[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1052543: marked as done (bookworm-pu: package plasma-framework/5.103.0-1+deb12u1)

Your message dated Sat, 07 Oct 2023 09:59:43 +0000
with message-id <E1qp463-00A4IR-3I@coccia.debian.org>
and subject line Released with 12.2
has caused the Debian Bug report #1052543,
regarding bookworm-pu: package plasma-framework/5.103.0-1+deb12u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1052543: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1052543
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: plasma-framework@packages.debian.org, deltaone@debian.org
Control: affects -1 + src:plasma-framework

[ Reason ]
Upstream KDE has received a number of bug reports about plasmashell
crashing when closing windows. This patch backports the fix to
avoid these crashes back into bookworm.

It was fixed in plasma-framework 5.104.0 which is available in
unstable (unstable currently has 5.107.0)

The corresponding Debian bug report is
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050723
with the upstream bug report to be found at
https://bugs.kde.org/show_bug.cgi?id=472543.

[ Impact ]
plasmashell crashes somewhat regularly when closing a window.

[ Tests ]
No manual or automated tests were conducted on the Debian side.
However, the request for this backport comes from upstream KDE and
the patch has been included upstream as well.

[ Risks ]
The code change is trivial - it is a 1-line patch.
The patch is coming directly from upstream and has been included
in subsequent versions of plasma-framework.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
One-line patch to fix plasmashell crashing when closing windows.

diffstat for plasma-framework-5.103.0 plasma-framework-5.103.0

 changelog                           |    7 +++++++
 patches/fix-plasmashell-crash.patch |   33 +++++++++++++++++++++++++++++++++
 patches/series                      |    1 +
 3 files changed, 41 insertions(+)

diff -Nru plasma-framework-5.103.0/debian/changelog plasma-framework-5.103.0/debian/changelog
--- plasma-framework-5.103.0/debian/changelog	2023-02-12 21:44:34.000000000 +0100
+++ plasma-framework-5.103.0/debian/changelog	2023-09-24 12:36:00.000000000 +0200
@@ -1,3 +1,10 @@
+plasma-framework (5.103.0-1+deb12u1) bookworm; urgency=medium
+
+  * Team upload.
+  * Add patch to fix plasmashell crashes (Closes: #1050723).
+
+ -- Patrick Franz <deltaone@debian.org>  Sun, 24 Sep 2023 12:36:00 +0200
+
 plasma-framework (5.103.0-1) unstable; urgency=medium
 
   [ Aurélien COUDERC ]
diff -Nru plasma-framework-5.103.0/debian/patches/fix-plasmashell-crash.patch plasma-framework-5.103.0/debian/patches/fix-plasmashell-crash.patch
--- plasma-framework-5.103.0/debian/patches/fix-plasmashell-crash.patch	1970-01-01 01:00:00.000000000 +0100
+++ plasma-framework-5.103.0/debian/patches/fix-plasmashell-crash.patch	2023-09-24 12:32:39.000000000 +0200
@@ -0,0 +1,33 @@
+From 0ad9576f29a3fcc41cec283ad13d3e654508ce1f Mon Sep 17 00:00:00 2001
+From: Fushan Wen <qydwhotmail@gmail.com>
+Date: Tue, 7 Mar 2023 22:34:03 +0800
+Subject: [PATCH] WindowThumbnail: postpone texture deletion to avoid crash
+
+The culprit was the texture that was delete as soon as the item was
+delete while they may be used a bit longer by the render thread.
+
+See also: https://github.com/sailfishos/sailfish-office/pull/85
+
+BUG: 464186
+BUG: 446874
+FIXED-IN: 5.104
+---
+ src/declarativeimports/core/windowthumbnail.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/declarativeimports/core/windowthumbnail.cpp b/src/declarativeimports/core/windowthumbnail.cpp
+index 6a08f3bc29..7b1e26dc80 100644
+--- a/src/declarativeimports/core/windowthumbnail.cpp
++++ b/src/declarativeimports/core/windowthumbnail.cpp
+@@ -233,7 +233,7 @@ void WindowThumbnail::releaseResources()
+ {
+     QQuickWindow::RenderStage m_renderStage = QQuickWindow::NoStage;
+     if (m_textureProvider) {
+-        window()->scheduleRenderJob(new DiscardTextureProviderRunnable(m_textureProvider), m_renderStage);
++        window()->scheduleRenderJob(new DiscardTextureProviderRunnable(m_textureProvider), QQuickWindow::AfterSynchronizingStage);
+         m_textureProvider = nullptr;
+     }
+ 
+-- 
+GitLab
+
diff -Nru plasma-framework-5.103.0/debian/patches/series plasma-framework-5.103.0/debian/patches/series
--- plasma-framework-5.103.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ plasma-framework-5.103.0/debian/patches/series	2023-09-24 12:32:50.000000000 +0200
@@ -0,0 +1 @@
+fix-plasmashell-crash.patch

--- End Message ---
--- Begin Message --- 
Version: 12.2

The upload requested in this bug has been released as part of 12.2.

--- End Message ---
Reply to: