Bug#1051395: bookworm-pu: package pywinrm/0.3.0-4+deb12u1
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: pywinrm@packages.debian.org
Control: affects -1 + src:pywinrm
[ Reason ]
The winrm.transport module throws an error with python3.11:
kerberos: module 'inspect' has no attribute 'getargspec'
This is fixed by using inspect.getfullargspec instead.
This issue makes the module unusable, either directly as reported in #1050848 or via ansible.
[ Impact ]
The winrm module is unusable.
[ Tests ]
Also manually tested 0.3.0-4+deb12u1 to ensure it works with ansible to manage Windows hosts.
[ Risks ]
The change is trivial and similar patches have been applied to other module to fix this issue with python3.11.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
gbp.conf was added to make git-buildpackage work out of the box.
Vcs-Git URL was updated to make debcheckout use the correct branch.
inspect.patch as added to fix the issue.
[ Other info ]
N/A
Kind Regards,
Bas
diff -Nru pywinrm-0.3.0/debian/changelog pywinrm-0.3.0/debian/changelog
--- pywinrm-0.3.0/debian/changelog 2022-11-02 22:04:39.000000000 +0100
+++ pywinrm-0.3.0/debian/changelog 2023-09-07 12:05:00.000000000 +0200
@@ -1,3 +1,13 @@
+pywinrm (0.3.0-4+deb12u1) bookworm; urgency=medium
+
+ * Team upload.
+ * Add gbp.conf to use pristine-tar & --source-only-changes by default.
+ * Update branch in Vcs-Git URL.
+ * Add patch to fix compatibility with inspect in python3.11.
+ (closes: #1050848)
+
+ -- Bas Couwenberg <sebastic@debian.org> Thu, 07 Sep 2023 12:05:00 +0200
+
pywinrm (0.3.0-4) unstable; urgency=medium
[ Debian Janitor ]
diff -Nru pywinrm-0.3.0/debian/control pywinrm-0.3.0/debian/control
--- pywinrm-0.3.0/debian/control 2022-11-02 22:04:39.000000000 +0100
+++ pywinrm-0.3.0/debian/control 2023-09-07 12:05:00.000000000 +0200
@@ -16,7 +16,7 @@
Standards-Version: 4.1.3
Testsuite: autopkgtest-pkg-python
Homepage: https://github.com/diyan/pywinrm
-Vcs-Git: https://salsa.debian.org/python-team/packages/python-winrm.git
+Vcs-Git: https://salsa.debian.org/python-team/packages/python-winrm.git -b bookworm
Vcs-Browser: https://salsa.debian.org/python-team/packages/python-winrm
diff -Nru pywinrm-0.3.0/debian/gbp.conf pywinrm-0.3.0/debian/gbp.conf
--- pywinrm-0.3.0/debian/gbp.conf 1970-01-01 01:00:00.000000000 +0100
+++ pywinrm-0.3.0/debian/gbp.conf 2023-09-07 12:05:00.000000000 +0200
@@ -0,0 +1,19 @@
+[DEFAULT]
+
+# The default name for the upstream branch is "upstream".
+# Change it if the name is different (for instance, "master").
+upstream-branch = upstream
+
+# The default name for the Debian branch is "master".
+# Change it if the name is different (for instance, "debian/unstable").
+debian-branch = bookworm
+
+# git-import-orig uses the following names for the upstream tags.
+# Change the value if you are not using git-import-orig
+upstream-tag = upstream/%(version)s
+
+# Always use pristine-tar.
+pristine-tar = True
+
+[buildpackage]
+pbuilder-options = --source-only-changes
diff -Nru pywinrm-0.3.0/debian/patches/inspect.patch pywinrm-0.3.0/debian/patches/inspect.patch
--- pywinrm-0.3.0/debian/patches/inspect.patch 1970-01-01 01:00:00.000000000 +0100
+++ pywinrm-0.3.0/debian/patches/inspect.patch 2023-09-07 12:05:00.000000000 +0200
@@ -0,0 +1,16 @@
+Description: Use getfullargspec instead of getargspec for python3.11.
+Author: Bas Couwenberg <sebastic@debian.org>
+Bug-Debian: https://bugs.debian.org/1050848
+Forwarded: not-needed
+
+--- a/winrm/transport.py
++++ b/winrm/transport.py
+@@ -289,7 +289,7 @@ class Transport(object):
+ return response_text
+
+ def _get_args(self, mandatory_args, optional_args, function):
+- argspec = set(inspect.getargspec(function).args)
++ argspec = set(inspect.getfullargspec(function).args)
+ function_args = dict()
+ for name, value in mandatory_args.items():
+ if name in argspec:
diff -Nru pywinrm-0.3.0/debian/patches/series pywinrm-0.3.0/debian/patches/series
--- pywinrm-0.3.0/debian/patches/series 2022-11-02 22:04:39.000000000 +0100
+++ pywinrm-0.3.0/debian/patches/series 2023-09-07 12:05:00.000000000 +0200
@@ -1 +1,2 @@
avoid-distutils.patch
+inspect.patch
Reply to: