[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1039047: marked as done (bookworm-pu: package cvs/2:1.12.13+real-28+deb12u1)

Your message dated Sat, 22 Jul 2023 13:19:41 +0000
with message-id <E1qNCWL-005rq1-V8@coccia.debian.org>
and subject line Released with 12.1
has caused the Debian Bug report #1039047,
regarding bookworm-pu: package cvs/2:1.12.13+real-28+deb12u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1039047: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039047
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: cvs@packages.debian.org, tg@mirbsd.de
Control: affects -1 + src:cvs

Pre-approval with debdiff.

[ Reason ]
CVS was always compiled with --with-rsh=ssh but the configure
script ignored that and used rsh because it could not find an
ssh binary in the PATH at compile time. This used to be not a
problem because ssh was aliased to rsh but in bookworm it no
longer is.

[ Impact ]
Users are unable to cvs update or cvs commit or anything else
unless they manually export CVS_RSH=ssh or change their access
method from :ext: to :extssh: (which is a relatively new thing
and may not be universally known, e.g. to frontends).

If this is rejected, I’d suggest the $CVS_RSH workaround be
added to the release notes, if they can be changed at this
point in time.

[ Tests ]
The change switches the cpp macro RSH_DFLT, which is used in
only two places to set the default rsh. I have tested this as
part of the larger changes in tonight’s sid upload, and code
inspection shows this has no effect on unrelated code.

[ Risks ]
See above, this is a no-risk change.

[ Checklist ]
  [✓] *all* changes are documented in the d/changelog
  [✓] I reviewed all changes and I approve them
  [✓] attach debdiff against the package in (old)stable
  [✓] the issue is verified as fixed in unstable

[ Changes ]
Pass the full path to ssh(1) to configure so it’s actually used.

diff -u cvs-1.12.13+real/debian/changelog cvs-1.12.13+real/debian/changelog
--- cvs-1.12.13+real/debian/changelog
+++ cvs-1.12.13+real/debian/changelog
@@ -1,3 +1,9 @@
+cvs (2:1.12.13+real-28+deb12u1) bookworm; urgency=high
+
+  * configure-time hardcode full path for ssh(1) (Closes: #1038926)
+
+ -- Thorsten Glaser <tg@mirbsd.de>  Sat, 24 Jun 2023 19:48:48 +0200
+
 cvs (2:1.12.13+real-28) unstable; urgency=medium
 
   [ Helmut Grohne ]
diff -u cvs-1.12.13+real/debian/rules cvs-1.12.13+real/debian/rules
--- cvs-1.12.13+real/debian/rules
+++ cvs-1.12.13+real/debian/rules
@@ -66,7 +66,7 @@
 			--without-krb4 \
 			--with-gssapi \
 			--with-external-zlib \
-			--with-rsh=ssh \
+			--with-rsh=/usr/bin/ssh \
 			--with-editor=/usr/bin/editor \
 			--with-tmpdir=/var/tmp \
 			--with-umask=002 \

--- End Message ---
--- Begin Message --- 
Version: 12.1

The upload requested in this bug has been released as part of 12.1.

--- End Message ---
Reply to: