Bug#1036474: unblock: debian-edu-fai/2023.05.16.1

[Mike Gabriel <sunweaver@debian.org>]

Hi Paul,

On  Mi 24 Mai 2023 18:33:44 CEST, Paul Gevers wrote:

> control: tags -1 moreinfo
>
> Hi Mike,
>
> On 21-05-2023 21:38, Mike Gabriel wrote:
> > In addition to the adduser changes, the diff to testing also  
> > includes a simple
> > directory-exists test before writing to it.
>
> See below, I see more. Please elaborate.
>
> > +  * bin/debian-edu-faiinstall: Make sure FAI_CONFIGDIR_REAL is set  
> > before it
> > +    is accessed.
>
> What does this mean functionally? The change was made in 2022-09,  
> was it not a problem all that time?

https://salsa.debian.org/debian-edu/debian-edu-fai/-/commit/9d8fba39024dcf407506995bba1e3eb6403b841d

There are two test/dev scenarios:

  * a Git working copy of debian-edu-fai symlinked to /srv/fai/config
  * a copy of /usr/share/debian-edu-fai/config

The first scenario is the one I am using to test changes to the FAI  
config space while developing.

The second scenario is less tested and is broken without the above  
patch (as FAI_CONFIGDIR_REAL never gets set if not a symlink).

> diff -Nru debian-edu-fai-2022.04.14.1/fai/config/class/FAIBASE.var  
> debian-edu-fai-2023.05.16.1/fai/config/class/FAIBASE.var
> --- debian-edu-fai-2022.04.14.1/fai/config/class/FAIBASE.var  
> 2022-09-16 18:38:21.000000000 +0000
> +++ debian-edu-fai-2023.05.16.1/fai/config/class/FAIBASE.var  
> 1970-01-01 00:00:00.000000000 +0000
> @@ -1,27 +0,0 @@
> -# default values for installation. You can override them in your *.var files
> -
> -# allow installation of packages from unsigned repositories
> -FAI_ALLOW_UNSIGNED=1
> -
> -# Set UTC=yes if your system clock is set to UTC (GMT), and UTC=no if not.
> -UTC=yes
> -TIMEZONE=Europe/Berlin
> -
> -# the hash of the root password for the new installed linux system
> -# pw is "fai"
> -ROOTPW='$1$kBnWcO.E$djxB128U7dMkrltJHPf6d1'
> -ROOTPW='$1$2fO2Hkud$nuSo8D5iUzgzUXBs8afZ8.'
> -
> -# errors in tasks greater than this value will cause the  
> installation to stop
> -STOP_ON_ERROR=700
> -
> -# set parameter for install_packages(8)
> -MAXPACKAGES=800
> -
> -# a user account will be created
> -username='spguser'
> -USERPW='$1$xwwADosf$LiKds1UMtKaYpHC91FAcy.'
> -
> -# user / server to use for storing FAI installation logs... (e.g.  
> fai@faiserver.intern)
> -LOGUSER='fai'
> -LOGSERVER='faiserver.intern'

The FAIBASE.var file is runtime cruft which sneaked its way into the  
previous package version. For this version, I removed it again. This  
file has never been committed but got included from my local test  
instance's file system.

Sorry, I forgot to add the info to the initial unblock mail.

Greets,
Mike

--

mike gabriel aka sunweaver (Debian Developer)
mobile: +49 (1520) 1976 148
landline: +49 (4351) 486 14 27

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: sunweaver@debian.org, http://sunweavers.net

Attachment: pgpulH8TR8WwN.pgp
Description: Digitale PGP-Signatur