[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1036552: marked as done (unblock: twinkle/1:1.10.2+dfsg-2)

Your message dated Wed, 24 May 2023 19:26:04 +0000
with message-id <E1q1u7Y-00Do7N-RH@respighi.debian.org>
and subject line unblock twinkle
has caused the Debian Bug report #1036552,
regarding unblock: twinkle/1:1.10.2+dfsg-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1036552: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1036552
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Control: affects -1 + src:twinkle
X-Debbugs-Cc: twinkle@packages.debian.org
User: release.debian.org@packages.debian.org
Usertags: unblock
Severity: normal

Please unblock package twinkle.

[ Reason ]
Fix for RC bug #1034661.

[ Impact ]
User's browser might end up opening a spam (and maybe web exploiting) website.

[ Tests ]
Opening the About section's manual will open https://mfnboer.home.xs4all.nl/twinkle/ instead of the spam website.

[ Risks ]
None.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock twinkle/1:1.10.2+dfsg-2
diff -Nru twinkle-1.10.2+dfsg/debian/changelog twinkle-1.10.2+dfsg/debian/changelog
--- twinkle-1.10.2+dfsg/debian/changelog	2020-12-03 15:47:34.000000000 +0100
+++ twinkle-1.10.2+dfsg/debian/changelog	2023-05-20 17:12:46.000000000 +0200
@@ -1,3 +1,10 @@
+twinkle (1:1.10.2+dfsg-2) unstable; urgency=medium
+
+  * Team upload.
+  * Change upstream URL taken over by hostile actors (Closes: #1034661)
+
+ -- Bernhard Schmidt <berni@debian.org>  Sat, 20 May 2023 17:12:46 +0200
+
 twinkle (1:1.10.2+dfsg-1) unstable; urgency=medium
 
   * New upstream version 1.10.2+dfsg
diff -Nru twinkle-1.10.2+dfsg/debian/patches/remove-malicious-homepage.patch twinkle-1.10.2+dfsg/debian/patches/remove-malicious-homepage.patch
--- twinkle-1.10.2+dfsg/debian/patches/remove-malicious-homepage.patch	1970-01-01 01:00:00.000000000 +0100
+++ twinkle-1.10.2+dfsg/debian/patches/remove-malicious-homepage.patch	2023-05-20 17:12:46.000000000 +0200
@@ -0,0 +1,63 @@
+From da274607aa835a2735dcf9b9a7ba550910f9d03e Mon Sep 17 00:00:00 2001
+From: matchi <hansi77@yandex.com>
+Date: Wed, 1 Dec 2021 09:54:39 +0100
+Subject: [PATCH] changed references to http(s)://twinklephone.com to
+ https://mfnboer.home.xs4all.nl/twinkle/
+
+(cherry picked from commit 165c43d8a1574946e7704c639c56cea3d5264606)
+---
+ AUTHORS                    | 2 +-
+ src/gui/lang/twinkle_de.ts | 2 +-
+ src/gui/mphoneform.cpp     | 2 +-
+ twinkle.spec.in            | 2 +-
+ 4 files changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/AUTHORS b/AUTHORS
+index 88cbeadb..ec1ad55c 100644
+--- a/AUTHORS
++++ b/AUTHORS
+@@ -33,4 +33,4 @@ Russian Michail Chodorenko
+ Swedish Daniel Nylander
+ 
+ Michel de Boer
+-www.twinklephone.com
++https://mfnboer.home.xs4all.nl/twinkle/
+diff --git a/src/gui/lang/twinkle_de.ts b/src/gui/lang/twinkle_de.ts
+index 8ab0b014..a5b38916 100644
+--- a/src/gui/lang/twinkle_de.ts
++++ b/src/gui/lang/twinkle_de.ts
+@@ -5620,7 +5620,7 @@ The values of all SIP headers in the incoming INVITE message are passed in envir
+ TWINKLE_TRIGGER=in_call. SIPREQUEST_METHOD=INVITE. The request-URI of the INVITE will be passed in &lt;b&gt;SIPREQUEST_URI&lt;/b&gt;. The name of the user profile will be passed in &lt;b&gt;TWINKLE_USER_PROFILE&lt;/b&gt;.</source>
+         <translation>&lt;p&gt;
+ Dieses Script wird gerufen, wenn ein INVITE (Anruf) ankommt. &lt;br&gt;
+-Bitte lesen Sie im Handbuch unter &quot;/usr/share/doc/packages/twinkle/...&quot; oder &quot;http://twinklephone.com&quot;  die ausführliche Beschreibung!
++Bitte lesen Sie im Handbuch unter &quot;/usr/share/doc/packages/twinkle/...&quot; oder &quot;https://mfnboer.home.xs4all.nl/twinkle/&quot; die ausführliche Beschreibung!
+ &lt;/p&gt;
+ &lt;h3&gt;Rückgabewerte&lt;/h3&gt; -   print nach STDOUT (z.B. `echo &quot;action=dnd&quot;`), ein Wert pro Zeile: &lt;br&gt;
+ &lt;tt&gt;action=[ continue | reject | dnd | redirect | autoanswer ]&lt;br&gt;&lt;/tt&gt;
+diff --git a/src/gui/mphoneform.cpp b/src/gui/mphoneform.cpp
+index c4e3c1d9..abca70d0 100644
+--- a/src/gui/mphoneform.cpp
++++ b/src/gui/mphoneform.cpp
+@@ -2290,7 +2290,7 @@ void MphoneForm::aboutQt()
+ 
+ void MphoneForm::manual()
+ {
+-	((t_gui *)ui)->open_url_in_browser("http://www.twinklephone.com";);
++	((t_gui *)ui)->open_url_in_browser("https://mfnboer.home.xs4all.nl/twinkle/";);
+ }
+ 
+ void MphoneForm::editUserProfile()
+diff --git a/twinkle.spec.in b/twinkle.spec.in
+index 989c4514..7c014167 100644
+--- a/twinkle.spec.in
++++ b/twinkle.spec.in
+@@ -10,7 +10,7 @@ BuildArch:	i586
+ #BuildArch:	x86_64
+ BuildRoot:	%{_tmppath}/making_of_%{name}_%{version}
+ Packager:
+-URL:		http://www.twinklephone.com
++URL:		https://mfnboer.home.xs4all.nl/twinkle/
+ Requires:	alsa
+ Requires:	ucommon
+ Requires:	ccrtp >= 1.6.0
diff -Nru twinkle-1.10.2+dfsg/debian/patches/series twinkle-1.10.2+dfsg/debian/patches/series
--- twinkle-1.10.2+dfsg/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ twinkle-1.10.2+dfsg/debian/patches/series	2023-05-20 17:12:46.000000000 +0200
@@ -0,0 +1 @@
+remove-malicious-homepage.patch

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: