[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035560: unblock: calamares-settings-debian/12.0.9-1



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: calamares-settings-debian@packages.debian.org, kibi@debian.org
Control: affects -1 + src:calamares-settings-debian

Please unblock package calamares-settings-debian

[ Reason ]
The method that LUKS encryption tools (cryptsetup, cryptset-initramfs,
keyutils) have changed. Prior to bookworm, these were included in the squashfs
system, so it was installed whether or not it was required, resulting in a
warning on unencrypted systems when update-initramfs were run.

By some happy accident due to updates in the live build system, these aren't
included in the squashfs image anymore, so we've added it to the media package
pool so that it could be installed only when required. This Calamares change
will install the required package only when LUKS have been configured.

[ Impact ]
If this isn't accepted, users who installed via the Calamares installer on
live media will not be able to boot their systems until they install 
cryptsetup-initramfs (and potentially keyutils, depending on configuration)
from rescue media.

[ Tests ]
This package was tested manually on the latest live test build.

[ Risks ]
The fixes are trivial and has been tested, and once migrated, we'll test it
yet again asap on the latest installation media. We're also adding luks tests
to our standard live smoke testing to help catch a bug like this sooner in the
future.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ DebDiff ]

"""
diff -Nru calamares-settings-debian-12.0.8/CHANGELOG calamares-settings-debian-12.0.9/CHANGELOG
--- calamares-settings-debian-12.0.8/CHANGELOG	2023-04-26 14:23:37.000000000 +0200
+++ calamares-settings-debian-12.0.9/CHANGELOG	2023-05-04 20:34:51.000000000 +0200
@@ -1,8 +1,15 @@
-[ 10.0.8 ]
+[ 12.0.9 ]
+
+ * Fix typos in version numbers for last two changelog entries
+ * Install cryptsetup-initramfs, cryptsetup and keyutils (only) when needed
+   (required due to these packages only now existing on package pool,
+    not on the squashfs filesystem)
+
+[ 12.0.8 ]

  * Do grub work within the chroot

-[ 10.0.7 ]
+[ 12.0.7 ]

  * Enable os-prober /after/ grub has been installed.

diff -Nru calamares-settings-debian-12.0.8/debian/changelog calamares-settings-debian-12.0.9/debian/changelog
--- calamares-settings-debian-12.0.8/debian/changelog	2023-04-26 14:25:34.000000000 +0200
+++ calamares-settings-debian-12.0.9/debian/changelog	2023-05-04 20:47:17.000000000 +0200
@@ -1,3 +1,10 @@
+calamares-settings-debian (12.0.9-1) unstable; urgency=medium
+
+  * New upstream release
+    - Deal with changes in how luks tools are installed from live media
+
+ -- Jonathan Carter <jcc@debian.org>  Thu, 04 May 2023 20:47:17 +0200
+
 calamares-settings-debian (12.0.8-1) unstable; urgency=medium

   * New upstream release
diff -Nru calamares-settings-debian-12.0.8/scripts/bootloader-config calamares-settings-debian-12.0.9/scripts/bootloader-config
--- calamares-settings-debian-12.0.8/scripts/bootloader-config	2023-04-26 14:23:37.000000000 +0200
+++ calamares-settings-debian-12.0.9/scripts/bootloader-config	2023-05-04 20:34:51.000000000 +0200
@@ -2,22 +2,24 @@

 CHROOT=$(mount | grep proc | grep calamares | awk '{print $3}' | sed -e "s#/proc##g")

-# Set secure permissions for the initramfs if we're configuring
+# Install luks utilities if needed.
+# Also, set secure permissions for the initramfs if we're configuring
 # full-disk-encryption. The initramfs is re-generated later in the
 # installation process so we only set the permissions snippet without
 # regenerating the initramfs right now:
 if [ "$(mount | grep $CHROOT" " | cut -c -16)" = "/dev/mapper/luks" ]; then
     echo "UMASK=0077" > $CHROOT/etc/initramfs-tools/conf.d/initramfs-permissions
+    chroot $CHROOT apt-get -y install cryptsetup-initramfs cryptsetup keyutils
 fi

 echo "Running bootloader-config..."

 if [ -d /sys/firmware/efi/efivars ]; then
     echo " * Installing grub-efi (uefi)..."
-    DEBIAN_FRONTEND=noninteractive chroot $CHROOT apt-get -y install grub-efi-amd64 cryptsetup keyutils
+    DEBIAN_FRONTEND=noninteractive chroot $CHROOT apt-get -y install grub-efi-amd64
 else
     echo " * install grub... (bios)"
-    DEBIAN_FRONTEND=noninteractive chroot $CHROOT apt-get -y install grub-pc cryptsetup keyutils
+    DEBIAN_FRONTEND=noninteractive chroot $CHROOT apt-get -y install grub-pc
 fi

 # Re-enable os-prober:
"""

thanks,

-Jonathan

unblock calamares-settings-debian/12.0.9-1


Reply to: