[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035398: [pre-approval] unblock: dwarves/1.24-4.1



Hi!

Aurelien Jarno <aurelien@aurel32.net> (2023-05-02):
> > [ Reason ]
> > Back in #1033301, Aurelien reported that the arm64 kernel size did
> > increase significantly due to issues with BTF deduplication. First
> > suspected to be a Linux kernel upstream issue, Aurelien discussed this
> > on with upstream and it was found that the issue is caused by a
> > src:dwarves regression (applied in 1.24-4).
> > 
> > Details in https://bugs.debian.org/1033301#31
> > 
> > The (not yet uploaded) dwarves upload with attache debdiff
> > cherry-picks the upstream commit.
> > 
> > (Please provide enough (but not too much) information to help
> > the release team to judge the request efficiently. E.g. by
> > filling in the sections below.)
> > 
> > [ Impact ]
> > Increased arm64 kernel size.
> > 
> > [ Tests ]
> > Apart from the report from Aurelien[1], package passes its autopkgtest.
> > 
> >  [1]  https://lore.kernel.org/linux-arm-kernel/ZEzHaJUP21Ln5XBt@aurel32.net/
> 
> Thanks a lot for preparing this pre-approval request and the
> corresponding upload. I confirm that I tested the exact same change on
> arm64, on both native and cross-compiled build and that it fixes the
> issue I reported.
> 
> > [ Risks ]
> > The upstream commit zero-initializes memory which previous was not
> > initialized after allocation, and might have contained garbage values
> > which were used. The fix is isolated as a oneliner.
> 
> I agree that the risk is quite low. The fix also likely improves
> reproducibility by removing a dependence on build time random data which
> is always good think.

Thanks from me as well for the d-i side: this issue worried me earlier
but didn't reach my list of topics to keep an eye on for Bookworm
(https://salsa.debian.org/installer-team/debian-installer/-/issues/1),
I'm glad you kept track!

I'll let someone else from the release team comment on the actual
unblock request though.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature


Reply to: