Bug#1035354: unblock: fish/3.6.0-3.1
I'm the previous uploader of src:fish.
The change looks good to me.
Please feel free to go ahead with the nmu once the release managers say OK.
On Mon, 2023-05-01 at 19:13 +0200, Andrej Shadura wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> X-Debbugs-Cc: fish@packages.debian.org, Mo Zhou <lumin@debian.org>
> Control: affects -1 + src:fish
>
> Please unblock package fish
>
> As described in #1000351, mc ships fragile prompt extraction code which
> was broken by a change in fish 3.3.0, leaving fish unusable in
> conjunction with mc. I had hoped that this bug would be fixed in mc by
> the time of bookworm release, but this didn’t happen. Instead, the
> upstream developers of fish proposed a workaround and shipped it
> in the bugfix release 3.6.1.
>
> I intend to either upload an NMU or let Mo Zhou do a maintainer’s
> upload.
>
> This fix has very limited impact, as it specifically checks for the
> presence of an mc-specific environment variable, and is a no-op
> otherwise. The workaround itself is also straightforward.
>
> The impact of not shipping this patch is that all users of both fish and
> mc (like myself) will have to put fish on hold and stay on the version
> shipped in bullseye.
>
> [ Checklist ]
> [x] all changes are documented in the d/changelog
> [x] I reviewed all changes and I approve them
> [x] attach debdiff against the package in testing
>
>
> Links:
>
> [1]: https://bugs.debian.org/1035353: the original mc bug
> [2]: https://bugs.debian.org/1000351: a clone of the above for the
> package fish
> [3]: https://github.com/fish-shell/fish-shell/pull/9540: a pull request
> in the upstream package.
>
> unblock fish/3.6.0-3.1
Reply to: