[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035339: unblock: vice/3.7.1+dfsg1-1



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Control: affects -1 + src:vice

Hi RMs,

[ Reason ]
Upstream source contains several ROM files for Commodore machines and
floppy drives, including printers. All these have a size of 2k and
multiples. A script under debian/ directory called mangle-source.sh
remove those. There's a printer ROM file which turned out to be an
exception to this size rule. Meaning this non-free file slipped to the
source tree and to the package itself.
This is filed as a serious bug [1] already. I've fixed it by removing
the file and updating the removal script.

[ Impact ]
It will make the package DFSG free and users can still have it in Bookworm.

[ Tests ]
This file is unused for package build and only needed if someone would
like to emulate the Commodore printer. That is, no extra tests are
required.

[ Risks ]
Nothing. The change is only a file removal, replace it with the text
'dummy' and a source repack shell script update.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
Uploaded, built on all architectures and package is working.

unblock vice/3.7.1+dfsg1-1

Thanks for considering,
Laszlo/GCS
[1] https://bugs.debian.org/1035079
Binary files /tmp/Vc_Z6BwILs/vice-3.7.1+dfsg/data/PRINTER/mps803.bin and /tmp/e6SEihfSew/vice-3.7.1+dfsg1/data/PRINTER/mps803.bin differ
diff -Nru vice-3.7.1+dfsg/debian/changelog vice-3.7.1+dfsg1/debian/changelog
--- vice-3.7.1+dfsg/debian/changelog	2023-02-17 21:06:12.000000000 +0100
+++ vice-3.7.1+dfsg1/debian/changelog	2023-04-29 10:58:51.000000000 +0200
@@ -1,3 +1,9 @@
+vice (3.7.1+dfsg1-1) unstable; urgency=medium
+
+  * Remove mps803.bin printer ROM from source (closes: #1035079).
+
+ -- Laszlo Boszormenyi (GCS) <gcs@debian.org>  Sat, 29 Apr 2023 10:58:51 +0200
+
 vice (3.7.1+dfsg-2) unstable; urgency=medium
 
   * Clarify license of CBM.ttf (closes: #1029260).
diff -Nru vice-3.7.1+dfsg/debian/mangle-source.sh vice-3.7.1+dfsg1/debian/mangle-source.sh
--- vice-3.7.1+dfsg/debian/mangle-source.sh	2023-01-14 20:56:30.000000000 +0100
+++ vice-3.7.1+dfsg1/debian/mangle-source.sh	2023-04-29 10:58:51.000000000 +0200
@@ -24,6 +24,9 @@
       echo dummy > $FILE
     fi
   done
+  # non-standard size
+  rm data/PRINTER/mps803.bin
+  echo dummy > data/PRINTER/mps803.bin
   # replace non-free font
   echo replace font 1>&2
   rm data/common/C64_Pro_Mono-STYLE.ttf 1>&2

Reply to: