Control: tag -1 confirmed
Salut Guilhem,
Guilhem Moulin <guilhem@debian.org> (2023-04-25):
> diffstat for argon2-0~20171227 argon2-0~20171227
>
> changelog | 18 ++++++++++++++++++
> control | 1 +
> gbp.conf | 2 +-
> libargon2-1-udeb.install | 2 ++
People wanting to toy around with the debdiff must remember to set the
.install +x otherwise there's a nice FTBFS right around the corner! :D
> rules | 11 -----------
> 5 files changed, 22 insertions(+), 12 deletions(-)
>
> diff -Nru argon2-0~20171227/debian/changelog argon2-0~20171227/debian/changelog
> --- argon2-0~20171227/debian/changelog 2022-02-13 10:41:34.000000000 +0100
> +++ argon2-0~20171227/debian/changelog 2023-04-21 21:29:33.000000000 +0200
> @@ -1,3 +1,21 @@
> +argon2 (0~20171227-0.3+deb12u1) bookworm; urgency=medium
Since there was no 0~20171227-0.4 upload ever, this slightly shorter
version number could be used instead, but both are fine with me.
> + * Non-maintainer upload.
> +
> + [ Bastian Germann ]
> + * Add Breaks on cryptsetup-initramfs (see #1032235)
This could have been a little more verbose, but I've followed parts of
the backstory in that bug report anyway…
> + [ Guilhem Moulin ]
> + * d/gbp.conf: Set 'debian-branch = debian/bookworm'.
> + * d/rules: Restore threading support to libargon2-1-udeb (closes: #1034696).
> + This is beneficial for cryptsetup-udeb, see #1028250. Removing threading
> + support in libargon2-1-udeb was done for historical reasons no longer
> + relevant since Debian Bookworm. This also restores threading support to
> + argon2 which was inadvertently dropped in 0~20171227-0.1 (closes:
> + #1032234).
> +
> + -- Guilhem Moulin <guilhem@debian.org> Fri, 21 Apr 2023 21:29:33 +0200
Since I didn't want to wait much more, and since I didn't trust myself
to be entirely objective, I've done the following: apply this debdiff,
keep the timestamp from the previous entry to limit timestamp-related
differences, and use diffoscope between builds without and with that
debdiff.
I can confirm thread-related additions in the udeb, as desired.
I could also confirm their popping up for the argon2 executable, inside
the argon2 binary, but also in libargon2.a, inside the libargon2-1
binary.
I'm also seeing an old changelog entry going away, but that seems
consistent with this in dh_installchangelogs:
use constant CUTOFF_DATE_STR => "2019-07-06"; # oldstable = Debian 10 Buster
since that's the first argon2 build with that cutoff (last argon2 build
was early 2022, cutoff got added late 2022).
> --- argon2-0~20171227/debian/control 2022-02-13 10:41:34.000000000 +0100
> +++ argon2-0~20171227/debian/control 2023-04-21 21:29:33.000000000 +0200
> @@ -60,6 +60,7 @@
> Architecture: any
> Pre-Depends: ${misc:Pre-Depends}
> Depends: ${shlibs:Depends}, ${misc:Depends}
> +Breaks: cryptsetup-initramfs (<<2:2.6.1-2)
FWIW: A space is customary after '<<' but it appears in the end (via
dh_gencontrol I suppose but I didn't check the exact inner workings).
With or without the version number tweaked (shortened), looks good to
me, please go ahead.
Cheers,
--
Cyril Brulebois (kibi@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
Attachment:
signature.asc
Description: PGP signature