Bug#1034715: unblock: python-xmlschema/1.10.0
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: python-xmlschema@packages.debian.org
Control: affects -1 + src:python-xmlschema
Please unblock package python-xmlschema
This package had a RC bug, due to changes in the dependency python3-elementpath
I uploaded an new release, 1.10.0-4, which a small patch which fixes bug
#1027439,
so the 72 failed tests are now succeeding.
[ Impact ]
other packages which depend directly on python3-xmlschema are
- python3-xarray-sentinel
- python3-pysaml2
- libervia-backend
[ Tests ]
dh_auto_test runs 1207 tests successfully, 11 tests are skipped.
[ Risks ]
python3-xmlschema is rather complex, but the changes made to the test suite
provided by upstream developers in version 1.10.0 are trivial.
the popcon score of python-xmlschema is approximately 60; it is not a leaf
package.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
Best regards, Georges.
unblock python-xmlschema/1.10.0
diff -Nru python-xmlschema-1.10.0/debian/changelog python-xmlschema-1.10.0/debian/changelog
--- python-xmlschema-1.10.0/debian/changelog 2022-12-18 20:47:28.000000000 +0100
+++ python-xmlschema-1.10.0/debian/changelog 2023-04-22 10:58:29.000000000 +0200
@@ -1,3 +1,12 @@
+python-xmlschema (1.10.0-4) unstable; urgency=medium
+
+ * created the debian patch d/Fix-tests.patch, which modifies two tests:
+ xmlschema/testing/_builders.py with a true fix, and
+ tests/test_typing.py which is just disabled (not a true fix).
+ Closes: #1027439
+
+ -- Georges Khaznadar <georgesk@debian.org> Sat, 22 Apr 2023 10:58:29 +0200
+
python-xmlschema (1.10.0-3) unstable; urgency=medium
* Fix patch description
diff -Nru python-xmlschema-1.10.0/debian/patches/Fix-tests.patch python-xmlschema-1.10.0/debian/patches/Fix-tests.patch
--- python-xmlschema-1.10.0/debian/patches/Fix-tests.patch 1970-01-01 01:00:00.000000000 +0100
+++ python-xmlschema-1.10.0/debian/patches/Fix-tests.patch 2023-04-22 10:58:29.000000000 +0200
@@ -0,0 +1,26 @@
+Index: python-xmlschema/xmlschema/testing/_builders.py
+===================================================================
+--- python-xmlschema.orig/xmlschema/testing/_builders.py
++++ python-xmlschema/xmlschema/testing/_builders.py
+@@ -125,7 +125,7 @@ def make_schema_test_class(test_file, te
+ if not inspect and not self.errors:
+ context = XMLSchemaContext(schema)
+ elements = [x for x in schema.iter()] # Contains schema elements only
+- xpath_context_elements = [x for x in context.iter() if isinstance(x, XsdValidator)]
++ xpath_context_elements = [x for x in context.root.iter() if isinstance(x, XsdValidator)]
+ descendants = [x for x in context.iter_descendants('descendant-or-self')]
+ self.assertTrue(x in descendants for x in xpath_context_elements)
+ for e in elements:
+Index: python-xmlschema/tests/test_typing.py
+===================================================================
+--- python-xmlschema.orig/tests/test_typing.py
++++ python-xmlschema/tests/test_typing.py
+@@ -20,6 +20,8 @@ try:
+ except ImportError:
+ mypy = None
+
++# this test is disabled in Debian
++mypy = None
+
+ @unittest.skipIf(mypy is None, "mypy is not installed")
+ class TestTyping(unittest.TestCase):
diff -Nru python-xmlschema-1.10.0/debian/patches/series python-xmlschema-1.10.0/debian/patches/series
--- python-xmlschema-1.10.0/debian/patches/series 2022-12-18 20:47:28.000000000 +0100
+++ python-xmlschema-1.10.0/debian/patches/series 2023-04-22 10:58:29.000000000 +0200
@@ -1 +1,2 @@
Skip-failing-packaging-test.patch
+Fix-tests.patch
Reply to: