Package: release.debian.org Severity: normal User: release.debian.org@packages.debian.org Usertags: unblock X-Debbugs-Cc: u-boot-menu@packages.debian.org, vagrant@debian.org Control: affects -1 + src:u-boot-menu Please unblock package u-boot-menu Recent versions of u-boot (2023.04+ from debian experimental) fixed bugs which reveal a misconfiguration in u-boot-menu's hard-coded default value for the "prompt" setting that cause the menu to not be displayed. [ Reason ] Depending on the version of u-boot used, the menu that u-boot-menu generates will not display a boot menu, proceeding with the default boot option without opportunity to select a boot option. The main purpose of u-boot-menu is to provide a menu, so this is suboptimal! [ Impact ] The changes implement the possibility to override the default behavior by making a hard-coded value configurable. [ Tests ] I have tested that this works correctly with u-boot from experimental (2023.04) on pinebook pro, with both the default behavior as well as the modified configuration. The u-boot from bookworm (2023.01) on the pinebook pro behavior is unchanged, regardless of the configuration (e.g. it always displays a menu). [ Risks ] Risks are very low; the defaults behave identically to previous versions. The changes are small and hopefully straightforward. [ Checklist ] [X] all changes are documented in the d/changelog [X] I reviewed all changes and I approve them [X] attach debdiff against the package in testing [ Other info ] It would be ideal to switch the default behavior, but given how late in the bookworm release cycle and not many platforms have been tested to be working correctly, it seems safer to keep the default behavior, and just make it possible to configure if needed. unblock u-boot-menu/4.2.2 Thanks! live well, vagrant
diff -Nru u-boot-menu-4.2.1/debian/changelog u-boot-menu-4.2.2/debian/changelog
--- u-boot-menu-4.2.1/debian/changelog 2022-12-12 13:26:47.000000000 -0800
+++ u-boot-menu-4.2.2/debian/changelog 2023-04-08 16:12:34.000000000 -0700
@@ -1,3 +1,10 @@
+u-boot-menu (4.2.2) unstable; urgency=medium
+
+ [ Diederik de Haas ]
+ * u-boot-update: Make 'prompt' configurable (Closes: #1034071)
+
+ -- Vagrant Cascadian <vagrant@debian.org> Sat, 08 Apr 2023 16:12:34 -0700
+
u-boot-menu (4.2.1) unstable; urgency=medium
* Revert "add kalsrseed support" (Closes: #1025954)
diff -Nru u-boot-menu-4.2.1/default u-boot-menu-4.2.2/default
--- u-boot-menu-4.2.1/default 2022-12-07 10:38:40.000000000 -0800
+++ u-boot-menu-4.2.2/default 2023-04-08 15:37:49.000000000 -0700
@@ -4,6 +4,7 @@
#U_BOOT_ALTERNATIVES="default recovery"
#U_BOOT_DEFAULT="l0"
+#U_BOOT_PROMPT="0"
#U_BOOT_ENTRIES="all"
#U_BOOT_MENU_LABEL="Debian GNU/Linux"
#U_BOOT_PARAMETERS="ro quiet"
diff -Nru u-boot-menu-4.2.1/u-boot-update u-boot-menu-4.2.2/u-boot-update
--- u-boot-menu-4.2.1/u-boot-update 2022-12-12 13:23:18.000000000 -0800
+++ u-boot-menu-4.2.2/u-boot-update 2023-04-08 15:37:49.000000000 -0700
@@ -96,6 +96,7 @@
U_BOOT_ALTERNATIVES="${U_BOOT_ALTERNATIVES:-default recovery}"
U_BOOT_DEFAULT="${U_BOOT_DEFAULT:-l0}"
+U_BOOT_PROMPT="${U_BOOT_PROMPT:-0}"
U_BOOT_ENTRIES="${U_BOOT_ENTRIES:-all}"
U_BOOT_TIMEOUT="${U_BOOT_TIMEOUT:-50}"
U_BOOT_MENU_LABEL="${U_BOOT_MENU_LABEL:-${PRETTY_NAME:-Debian GNU/Linux kernel}}"
@@ -162,7 +163,7 @@
default ${U_BOOT_DEFAULT}
menu title U-Boot menu
-prompt 0
+prompt ${U_BOOT_PROMPT}
timeout ${U_BOOT_TIMEOUT}
"
Attachment:
signature.asc
Description: PGP signature