Bug#1034479: [pre-approval] unblock: rocprim/5.3.3-4
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: debian-ai@lists.debian.org
Control: affets -1 + src:rocprim
We'd like to get approval to unblock rocprim/5.3.3-4. It has been
prepared, but not yet uploaded.
This version in itself isn't controversial, but unfortunately the
previous version 5.3.3-3 did not yet migrate to testing, so I'm asking
for pre-approval to to 5.3.3-4 and allow it to eventually migrate, and
otherwise guidance for an alternative solution.
[ Reason ]
Mainly to close #1034476, a missing dependency on a package key to
librocprim-dev.
The other notable changes (from -2 to -3) are: adding hardening flags,
and changing from arch:any to arch:all, as it always should have been
(header-only library).
[ Impact ]
Users installing this package will not be able to use it, unless they
discover this missing dependency by themselves.
[ Tests ]
autopkgtests are implemented but not part of this package yet. This is
mostly because they require GPU access to work.
An upload with autopkgtest packages enabled (but skipped on systems
lacking the hardware) will go through experimental once this request has
been resolved.
[ Risks ]
None. The only user-visible changes are the hardening flags, and they
passed on our ends.
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
unblock rocprim/5.3.3-4
diff -Nru rocprim-5.3.3/debian/changelog rocprim-5.3.3/debian/changelog
--- rocprim-5.3.3/debian/changelog 2023-01-04 10:09:08.000000000 +0100
+++ rocprim-5.3.3/debian/changelog 2023-04-16 13:40:58.000000000 +0200
@@ -1,3 +1,22 @@
+rocprim (5.3.3-4) unstable; urgency=medium
+
+ * Add libamdhip64-dev to Depends (Closes: #1034476)
+ * Fix Maintainer name
+ * Add myself to Uploaders
+
+ -- Christian Kastner <ckk@debian.org> Sun, 16 Apr 2023 13:40:58 +0200
+
+rocprim (5.3.3-3) unstable; urgency=medium
+
+ * Move cmake files to /usr/share.
+ * d/rules: drop override for debug symbols
+ * d/control: update standards version to 4.6.2
+ * d/control: library is arch-independent
+ * d/rules: enable hardening flags for tests
+ * d/rules: enable gfx1010 and gfx1011 for tests
+
+ -- Cordell Bloor <cgmb@slerp.xyz> Mon, 06 Mar 2023 00:55:17 -0700
+
rocprim (5.3.3-2) unstable; urgency=medium
* d/rules: add rules to handle rocm-cmake >= 5.3
diff -Nru rocprim-5.3.3/debian/control rocprim-5.3.3/debian/control
--- rocprim-5.3.3/debian/control 2022-11-17 20:47:12.000000000 +0100
+++ rocprim-5.3.3/debian/control 2023-04-16 13:40:58.000000000 +0200
@@ -2,26 +2,27 @@
Section: devel
Homepage: https://github.com/rocmsoftwareplatform/rocprim
Priority: optional
-Standards-Version: 4.6.1
+Standards-Version: 4.6.2
Vcs-Git: https://salsa.debian.org/rocm-team/rocprim.git
Vcs-Browser: https://salsa.debian.org/rocm-team/rocprim
-Maintainer: ROCm Team <debian-ai@lists.debian.org>
+Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Uploaders: Maxime Chambonnet <maxzor@maxzor.eu>,
Cordell Bloor <cgmb@slerp.xyz>,
+ Christian Kastner <ckk@debian.org>,
Build-Depends: debhelper-compat (= 13),
cmake,
hipcc,
libamd-comgr-dev,
libhsa-runtime-dev,
rocminfo,
- rocm-cmake,
+ rocm-cmake (>= 5.3.0),
libgtest-dev <!nocheck>
Rules-Requires-Root: no
Package: librocprim-dev
Section: libdevel
-Architecture: any
-Depends: ${misc:Depends}
+Architecture: all
+Depends: ${misc:Depends}, libamdhip64-dev
Description: parallel primitives for GPU-accelerated code - headers
rocPRIM is a header-only library providing HIP parallel primitives for
developing performant GPU-accelerated code on the AMD ROCm platform.
diff -Nru rocprim-5.3.3/debian/librocprim-dev.install rocprim-5.3.3/debian/librocprim-dev.install
--- rocprim-5.3.3/debian/librocprim-dev.install 2022-10-22 16:53:03.000000000 +0200
+++ rocprim-5.3.3/debian/librocprim-dev.install 2023-04-16 13:40:58.000000000 +0200
@@ -1,2 +1,2 @@
usr/include/rocprim
-usr/lib/cmake/rocprim
+usr/share/cmake/rocprim
diff -Nru rocprim-5.3.3/debian/rules rocprim-5.3.3/debian/rules
--- rocprim-5.3.3/debian/rules 2023-01-04 10:09:08.000000000 +0100
+++ rocprim-5.3.3/debian/rules 2023-04-16 13:40:58.000000000 +0200
@@ -1,15 +1,17 @@
#!/usr/bin/make -f
export CXX=hipcc
-export DEB_BUILD_MAINT_OPTIONS = hardening=-all
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all
export VERBOSE=1
#export AMD_LOG_LEVEL=4
-%:
- dh $@ -Scmake
+# filter incompatible options from affecting device code
+CFLAGS := $(subst -fstack-protector-strong,-Xarch_host -fstack-protector-strong,$(CFLAGS))
+CXXFLAGS := $(subst -fstack-protector-strong,-Xarch_host -fstack-protector-strong,$(CXXFLAGS))
CMAKE_FLAGS = \
-DCMAKE_BUILD_TYPE=Release \
- -DCMAKE_INSTALL_LIBDIR=lib \
+ -DCMAKE_INSTALL_LIBDIR=share \
+ -DAMDGPU_TARGETS="gfx803;gfx900;gfx906;gfx908;gfx90a;gfx1010;gfx1011;gfx1030" \
-DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF
ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
@@ -34,7 +36,3 @@
override_dh_auto_install:
dh_auto_install --destdir=debian/tmp
-
-override_dh_dwz:
- @echo "W: debug symbols unavailable for the moment[1]."
- @echo "W: [1]: https://github.com/ROCm-Developer-Tools/hipamd/issues/17";
Reply to: