[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1034461: marked as done (unblock: gnome-user-docs/43.0-2)

Your message dated Sun, 16 Apr 2023 09:21:14 +0000
with message-id <E1pnyZO-001URb-BY@respighi.debian.org>
and subject line unblock gnome-user-docs
has caused the Debian Bug report #1034461,
regarding unblock: gnome-user-docs/43.0-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1034461: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034461
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: gunnarhj@debian.org
Control: affects -1 + src:gnome-user-docs

Please unblock package gnome-user-docs.

[ Reason ]
Upstream missed to ship two figures in the tarball. They were added via a patch in gnome-user-docs 43.0-2. 

[ Impact ]

Without the patch it doesn't look so good if you browse this page:

yelp /usr/share/help/C/gnome-help/bluetooth-device-specific-pairing.page

[ Tests ]
Installed the binary built by version 43.0-2 of the gnome-user-docs source, and confirmed that the figures showed up as expected. 

[ Risks ]

Just two docs figures, not affecting anything else.

[ Checklist ]
     [x] all changes are documented in the d/changelog
     [x] I reviewed all changes and I approve them
     [x] attach debdiff against the package in testing

--
Cheers,
Gunnar Hjalmarsson
diff --git a/debian/changelog b/debian/changelog
index f8b94f77a..deff6d0ed 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+gnome-user-docs (43.0-2) unstable; urgency=medium
+
+  * Add-missing-figures.patch
+
+ -- Gunnar Hjalmarsson <gunnarhj@debian.org>  Sat, 15 Apr 2023 23:54:03 +0200
+
 gnome-user-docs (43.0-1) unstable; urgency=medium
 
   * New upstream release
diff --git a/debian/patches/Add-missing-figures.patch b/debian/patches/Add-missing-figures.patch
new file mode 100644
index 000000000..ab58c19b0
--- /dev/null
+++ b/debian/patches/Add-missing-figures.patch
@@ -0,0 +1,153 @@
+Description: Add missing figures
+ A consequence of the mistake in gnome-help/Makefile.am is that the
+ figures are not included in the upstream tarball. So this patch also
+ adds the missing figures as such.
+Author: Gunnar Hjalmarsson <gunnarhj@debian.org>
+Forwarded: https://gitlab.gnome.org/GNOME/gnome-user-docs/-/merge_requests/164
+---
+ /dev/null => gnome-help/C/figures/ps-button.svg         |  62 +++
+ /dev/null => gnome-help/C/figures/ps-create.svg         |  54 ++
+ gnome-help/Makefile.am                                  |   2 +
+ 3 files changed, 118 insertions(+)
+
+diff --git a/gnome-help/C/figures/ps-button.svg b/gnome-help/C/figures/ps-button.svg
+new file mode 100644
+index 0000000..f65a8f3
+--- /dev/null
++++ b/gnome-help/C/figures/ps-button.svg
+@@ -0,0 +1,62 @@
++<?xml version="1.0" encoding="UTF-8" standalone="no"?>
++<!-- Created with Inkscape (http://www.inkscape.org/) -->
++
++<svg
++   width="16"
++   height="16"
++   viewBox="0 0 16 16"
++   version="1.1"
++   id="svg442"
++   inkscape:version="1.2.1 (9c6d41e410, 2022-07-14)"
++   sodipodi:docname="ps-button.svg"
++   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape";
++   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd";
++   xmlns="http://www.w3.org/2000/svg";
++   xmlns:svg="http://www.w3.org/2000/svg";>
++  <sodipodi:namedview
++     id="namedview444"
++     pagecolor="#ffffff"
++     bordercolor="#666666"
++     borderopacity="1.0"
++     inkscape:showpageshadow="2"
++     inkscape:pageopacity="0.0"
++     inkscape:pagecheckerboard="0"
++     inkscape:deskcolor="#d1d1d1"
++     inkscape:document-units="mm"
++     showgrid="false"
++     inkscape:zoom="5.1754899"
++     inkscape:cx="114.57852"
++     inkscape:cy="-20.481153"
++     inkscape:window-width="3440"
++     inkscape:window-height="1371"
++     inkscape:window-x="0"
++     inkscape:window-y="0"
++     inkscape:window-maximized="1"
++     inkscape:current-layer="layer1" />
++  <defs
++     id="defs439" />
++  <g
++     inkscape:label="Layer 1"
++     inkscape:groupmode="layer"
++     id="layer1">
++    <g
++       id="ffffffff"
++       transform="matrix(0.02115953,0,0,0.02115953,-4.3997981,-4.0954221)">
++      <path
++         fill="#000000"
++         opacity="1"
++         d="m 490.94,279.87 c 42.23,8.85 83.93,20.03 125.2,32.59 32.61,9.83 65.21,20.25 95.84,35.32 10.03,5.54 20.06,11.14 29.33,17.91 12.86,9.68 24.65,21.04 33.43,34.63 10.99,16.2 16.99,35.14 21.01,54.14 3.7,23.93 5.61,48.33 3.36,72.5 -2.24,21.42 -7.45,43.32 -20.25,61.06 -8.05,11.61 -19.57,20.81 -32.68,26.07 -11.81,4.3 -24.59,5.67 -37.08,4.7 -15.84,-1.74 -31.25,-6.64 -45.61,-13.45 L 663,604.79 c -0.14,-55.91 -0.02,-111.84 -0.06,-167.76 -0.14,-12.52 0.86,-25.32 -2.67,-37.5 -1.98,-7.47 -5.6,-15.04 -12.39,-19.25 -6.12,-3.89 -14.19,-7.19 -21.25,-3.85 -7.22,3.5 -10.33,11.77 -11.84,19.16 -1.63,9.36 -1.15,18.91 -1.23,28.37 0,146.48 -0.01,292.96 0.01,439.43 -40.79,-13.3 -81.8,-25.93 -122.67,-38.98 0.09,-181.51 0,-363.03 0.04,-544.54 z"
++         id="path21" />
++      <path
++         fill="#000000"
++         opacity="1"
++         d="m 327.44,658.66 c 46.42,-16.55 92.93,-32.89 139.32,-49.54 -0.53,23.75 0.03,47.53 -0.28,71.29 -37.54,13.55 -75.23,26.94 -112.83,40.45 -9.05,3.33 -18.47,6.04 -26.65,11.28 -2.75,2.09 -5.93,4.41 -6.49,8.08 -0.93,3.84 2.48,7 5.52,8.71 11.01,5.75 23.84,6.13 36,6.06 16.45,0.01 32.84,-3.19 48.25,-8.93 18.74,-6.87 37.62,-13.36 56.28,-20.45 0.07,21.36 -0.17,42.73 0.12,64.08 -10.94,1.32 -21.72,3.97 -32.76,4.52 -17.22,2.06 -34.59,2.46 -51.91,2.14 -26.81,-0.09 -53.41,-4.22 -79.64,-9.51 -14.37,-3.79 -28.79,-7.45 -42.88,-12.19 -10.64,-3.19 -20.82,-7.91 -30.22,-13.8 -9.27,-6.16 -18.02,-14.7 -20.58,-25.92 -2.77,-10.06 2.43,-20.63 9.87,-27.29 15.13,-12.12 32.76,-20.55 50.61,-27.83 19.18,-7.7 38.84,-14.11 58.27,-21.15 z"
++         id="path23" />
++      <path
++         fill="#000000"
++         opacity="1"
++         d="m 750.88,641.02 c 8.08,0.05 16.09,-1.49 24.18,-0.83 41.48,0.26 83.18,5.72 122.63,18.91 6.74,2.53 13.57,4.79 20.41,7.06 11.94,4.93 24.15,10.12 33.72,19.05 6.59,5.74 11.65,13.81 12.26,22.68 0.3,7.97 -3.95,15.24 -8.87,21.18 -13.82,13.41 -31.33,22.32 -49.12,29.28 -89.51,32.38 -179.16,64.36 -268.69,96.69 0.12,-23.73 -0.02,-47.46 0.07,-71.19 66.18,-23.73 132.45,-47.23 198.64,-70.96 6.78,-2.42 13.89,-5.59 17.84,-11.96 1.64,-2.96 0.25,-6.73 -2.33,-8.64 -7.23,-5.35 -16.37,-6.99 -25.14,-7.51 -12.2,-1.46 -24.53,-0.37 -36.62,1.46 -14.56,2.27 -28.16,8.15 -42.04,12.85 -36.81,12.98 -73.64,25.9 -110.42,38.94 0.04,-24.58 0.13,-49.17 -0.05,-73.76 36.62,-12.67 74.95,-20.09 113.53,-23.25 z"
++         id="path25" />
++    </g>
++  </g>
++</svg>
+diff --git a/gnome-help/C/figures/ps-create.svg b/gnome-help/C/figures/ps-create.svg
+new file mode 100644
+index 0000000..f62dec8
+--- /dev/null
++++ b/gnome-help/C/figures/ps-create.svg
+@@ -0,0 +1,54 @@
++<?xml version="1.0" encoding="UTF-8" standalone="no"?>
++<!-- Created with Inkscape (http://www.inkscape.org/) -->
++
++<svg
++   width="16"
++   height="16"
++   viewBox="0 0 16 16"
++   version="1.1"
++   id="svg1189"
++   inkscape:version="1.2.1 (9c6d41e410, 2022-07-14)"
++   sodipodi:docname="ps-share.svg"
++   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape";
++   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd";
++   xmlns="http://www.w3.org/2000/svg";
++   xmlns:svg="http://www.w3.org/2000/svg";>
++  <sodipodi:namedview
++     id="namedview1191"
++     pagecolor="#ffffff"
++     bordercolor="#666666"
++     borderopacity="1.0"
++     inkscape:showpageshadow="2"
++     inkscape:pageopacity="0.0"
++     inkscape:pagecheckerboard="0"
++     inkscape:deskcolor="#d1d1d1"
++     inkscape:document-units="mm"
++     showgrid="false"
++     inkscape:zoom="29.276992"
++     inkscape:cx="29.818637"
++     inkscape:cy="3.9279992"
++     inkscape:window-width="3440"
++     inkscape:window-height="1371"
++     inkscape:window-x="0"
++     inkscape:window-y="0"
++     inkscape:window-maximized="1"
++     inkscape:current-layer="layer1" />
++  <defs
++     id="defs1186" />
++  <g
++     inkscape:label="Layer 1"
++     inkscape:groupmode="layer"
++     id="layer1">
++    <text
++       xml:space="preserve"
++       style="font-size:21.3333px;line-height:1.25;font-family:Lato;-inkscape-font-specification:Lato;letter-spacing:0px;word-spacing:0px"
++       x="-17.10936"
++       y="15.921875"
++       id="text1364"
++       transform="rotate(-90)"><tspan
++         sodipodi:role="line"
++         id="tspan1362"
++         x="-17.10936"
++         y="15.921875">⚟</tspan></text>
++  </g>
++</svg>
+diff --git a/gnome-help/Makefile.am b/gnome-help/Makefile.am
+index 95000e0..a94470b 100644
+--- a/gnome-help/Makefile.am
++++ b/gnome-help/Makefile.am
+@@ -83,6 +83,8 @@ HELP_MEDIA = \
+ 	figures/network-wireless-disabled-symbolic.svg \
+ 	figures/preferences-desktop-accessibility-symbolic.svg \
+ 	figures/printing-select.png \
++	figures/ps-button.svg \
++	figures/ps-create.svg \
+ 	figures/rotation-allowed-symbolic.svg \
+ 	figures/rotation-locked-symbolic.svg \
+ 	figures/screenshot-tool.png \
diff --git a/debian/patches/series b/debian/patches/series
index ead8eb86f..b87203895 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 drop-experimental-style-for-prefs.page.patch
+Add-missing-figures.patch

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: