[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1034276: marked as done (unblock: fwknop/2.6.10-16)

Your message dated Wed, 12 Apr 2023 11:50:42 +0000
with message-id <E1pmYzq-00EFBh-Mo@respighi.debian.org>
and subject line unblock fwknop
has caused the Debian Bug report #1034276,
regarding unblock: fwknop/2.6.10-16
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1034276: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034276
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: fwknop@packages.debian.org
Control: affects -1 + src:fwknop

Please unblock package fwknop

[ Reason ]
The AppArmor profile was incorrectly installed in the systemd
system service path:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034055

[ Impact ]
I'm not sure whether it would cause any actual problems, but it is likely a
policy violation and the bug reporter did file it as an RC bug.

[ Tests ]
I upgraded to the version I uploaded to unstable yesterday and confirmed
that the file is in the new location:

  $ dpkg -L fwknop-apparmor-profile | grep usr.sbin.fwknopd
  /usr/share/apparmor/extra-profiles/usr.sbin.fwknopd

[ Risks ]
Trivial fix. I made it so that the AppArmor profile is not automatically
enabled either to avoid changing (i.e. fixing) the behavior compared to what
it was in -15.

So this should be a no-op in terms of functionality.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing


unblock fwknop/2.6.10-16

diff -Nru fwknop-2.6.10/debian/changelog fwknop-2.6.10/debian/changelog
--- fwknop-2.6.10/debian/changelog	2023-01-10 21:23:46.000000000 -0800
+++ fwknop-2.6.10/debian/changelog	2023-04-10 20:52:01.000000000 -0700
@@ -1,3 +1,12 @@
+fwknop (2.6.10-16) unstable; urgency=high
+
+  * Install apparmor profile in /usr/share/apparmor/extra-profiles/
+    instead of the systemd service directory. Note that the profile
+    will not be used unless manually copied into /etc/apparmor.d/
+    (Closes: #1034055).
+
+ -- Francois Marier <francois@debian.org>  Mon, 10 Apr 2023 20:52:01 -0700
+
 fwknop (2.6.10-15) unstable; urgency=medium
 
   [ Helmut Grohne ]
diff -Nru fwknop-2.6.10/debian/fwknop-apparmor-profile.install fwknop-2.6.10/debian/fwknop-apparmor-profile.install
--- fwknop-2.6.10/debian/fwknop-apparmor-profile.install	2023-01-10 21:23:46.000000000 -0800
+++ fwknop-2.6.10/debian/fwknop-apparmor-profile.install	2023-04-10 20:52:01.000000000 -0700
@@ -1 +1 @@
-extras/apparmor/usr.sbin.fwknopd	/usr/lib/systemd/system/
+extras/apparmor/usr.sbin.fwknopd	/usr/share/apparmor/extra-profiles/

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: