[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1034166: unblock (pre-approval): gnome-shell/43.4-1



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: gnome-shell@packages.debian.org
Control: affects -1 + src:gnome-shell

I'd like to upload a new upstream bug fix release of gnome-shell.

[ Reason ]
Catch up with upstream 43.4 bug fix release, and cherry-pick patches
that were already accepted for 43.5.

[ Impact ]
One small bug fix, one translation update, and convert several earlier
translation updates and bug fixes from being applied as patches to being
part of the updated upstream source.

[ Tests ]
I used a previous release-candidate on my Intel laptop for several days
without noticing any regressions. The only change since that version is
the Abkhazian translation update.

[ Risks ]
Key package with high visibility in our default desktop environment, but
the changes are narrowly targeted.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing
      (filtered to exclude patch contents and translations)

[ Other info ]
This has only been tested together with the corresponding mutter update.

unblock gnome-shell/43.4-1
debdiff *.dsc | filterdiff -p1 -x'debian/patches/*.patch' -x'po/*.po'

diffstat for gnome-shell-43.3 gnome-shell-43.4

 NEWS                                                                           |   14 
 debian/changelog                                                               |   16 
 debian/patches/Update-Abkhazian-translation.patch                              | 4910 ++++++++++
 debian/patches/Update-Finnish-translation.patch                                |  873 -
 debian/patches/Update-Georgian-translation.patch                               |  577 -
 debian/patches/Update-German-translation.patch                                 |  896 -
 debian/patches/Update-Hungarian-translation.patch                              |  848 -
 debian/patches/Update-Indonesian-translation.patch                             |  544 -
 debian/patches/Update-Lithuanian-translation.patch                             |  554 -
 debian/patches/Update-Polish-translation.patch                                 |  806 -
 debian/patches/Update-Portuguese-translation.patch                             |  574 -
 debian/patches/Update-Serbian-translation.patch                                |  591 -
 debian/patches/Update-Slovenian-translation.patch                              | 1990 ----
 debian/patches/Update-Swedish-translation.patch                                |  537 -
 debian/patches/Update-Turkish-translation.patch                                |  869 -
 debian/patches/Update-Ukrainian-translation.patch                              |  577 -
 debian/patches/debian/Revert-build-Port-to-gcr4.patch                          |    2 
 debian/patches/overview-Don-t-claim-to-be-SHOWN-when-HIDDEN-during-start.patch |   38 
 debian/patches/overview-Hide-when-failing-to-take-grab-at-end-of-startup.patch |   27 
 debian/patches/series                                                          |   16 
 js/ui/dnd.js                                                                   |    9 
 js/ui/status/network.js                                                        |    6 
 meson.build                                                                    |    2 
 po/ab.po                                                                       | 4383 ++++++++
 po/fr.po                                                                       |  377 
 subprojects/extensions-app/data/metainfo/org.gnome.Extensions.metainfo.xml.in  |    1 
 subprojects/extensions-app/meson.build                                         |    2 
 subprojects/extensions-app/subprojects/shew/meson.build                        |    2 
 subprojects/extensions-tool/meson.build                                        |    2 
 subprojects/shew/meson.build                                                   |    2 
 30 files changed, 9414 insertions(+), 10631 deletions(-)

diff -Nru gnome-shell-43.3/debian/changelog gnome-shell-43.4/debian/changelog
--- gnome-shell-43.3/debian/changelog	2023-03-08 11:09:54.000000000 +0000
+++ gnome-shell-43.4/debian/changelog	2023-04-10 14:07:38.000000000 +0100
@@ -1,3 +1,19 @@
+gnome-shell (43.4-1) unstable; urgency=medium
+
+  * Team upload
+  * New upstream release
+    - Fix memory leaks when the list of wireless networks is refreshed
+      (GNOME/gnome-shell!2652)
+    - Stop tracking drag-and-drop source object when destroyed
+      (part of GNOME/gnome-shell!2318)
+    - Translation update: fr
+    - All other changes were included in 43.3-2 and 43.3-3
+  * Drop patches added by 43.3-2 and 43.3-3, included in upstream 43.4
+  * d/patches: Update to gnome-43 branch commit 43.4-1-g3499d2e87
+    - Translation update: ab
+
+ -- Simon McVittie <smcv@debian.org>  Mon, 10 Apr 2023 14:07:38 +0100
+
 gnome-shell (43.3-3) unstable; urgency=medium
 
   * Team upload
diff -Nru gnome-shell-43.3/debian/patches/series gnome-shell-43.4/debian/patches/series
--- gnome-shell-43.3/debian/patches/series	2023-03-08 11:09:54.000000000 +0000
+++ gnome-shell-43.4/debian/patches/series	2023-04-10 14:07:38.000000000 +0100
@@ -1,17 +1,3 @@
-Update-Swedish-translation.patch
-Update-Turkish-translation.patch
-Update-Finnish-translation.patch
-Update-Georgian-translation.patch
-Update-Portuguese-translation.patch
-Update-Ukrainian-translation.patch
-Update-Indonesian-translation.patch
-Update-Slovenian-translation.patch
-Update-German-translation.patch
-Update-Polish-translation.patch
-Update-Lithuanian-translation.patch
-Update-Serbian-translation.patch
-Update-Hungarian-translation.patch
-overview-Don-t-claim-to-be-SHOWN-when-HIDDEN-during-start.patch
-overview-Hide-when-failing-to-take-grab-at-end-of-startup.patch
+Update-Abkhazian-translation.patch
 debian/gnome-shell-extension-prefs-Give-Debian-specific-advice.patch
 debian/Revert-build-Port-to-gcr4.patch
diff -Nru gnome-shell-43.3/js/ui/dnd.js gnome-shell-43.4/js/ui/dnd.js
--- gnome-shell-43.3/js/ui/dnd.js	2023-02-14 00:11:32.000000000 +0000
+++ gnome-shell-43.4/js/ui/dnd.js	2023-03-19 20:25:01.000000000 +0000
@@ -367,6 +367,10 @@
                     y = stageY - this._dragActor.height / 2;
                 }
                 this._dragActor.set_position(x, y);
+
+                this._dragActorSourceDestroyId = this._dragActorSource.connect('destroy', () => {
+                    this._dragActorSource = null;
+                });
             } else {
                 this._dragActorSource = this.actor;
             }
@@ -799,6 +803,11 @@
             this._dragOrigParent = null;
         }
 
+        if (this._dragActorSource) {
+            this._dragActorSource.disconnect(this._dragActorSourceDestroyId);
+            this._dragActorSource = null;
+        }
+
         this._dragState = DragState.INIT;
         currentDraggable = null;
     }
diff -Nru gnome-shell-43.3/js/ui/status/network.js gnome-shell-43.4/js/ui/status/network.js
--- gnome-shell-43.3/js/ui/status/network.js	2023-02-14 00:11:32.000000000 +0000
+++ gnome-shell-43.4/js/ui/status/network.js	2023-03-19 20:25:01.000000000 +0000
@@ -861,6 +861,7 @@
         if (!this._accessPoints.delete(ap))
             return false;
 
+        ap.disconnectObject(this);
         this._updateBestAp();
 
         if (wasActive !== this.is_active)
@@ -1069,6 +1070,11 @@
         this._activeConnectionChanged();
         this._availableConnectionsChanged();
         this._updateItemsVisibility();
+
+        this.connect('destroy', () => {
+            for (const net of this._networkItems.keys())
+                net.destroy();
+        });
     }
 
     get icon_name() {
diff -Nru gnome-shell-43.3/meson.build gnome-shell-43.4/meson.build
--- gnome-shell-43.3/meson.build	2023-04-10 14:20:08.000000000 +0100
+++ gnome-shell-43.4/meson.build	2023-04-10 14:20:08.000000000 +0100
@@ -1,5 +1,5 @@
 project('gnome-shell', 'c',
-  version: '43.3',
+  version: '43.4',
   meson_version: '>= 0.58.0',
   license: 'GPLv2+'
 )
diff -Nru gnome-shell-43.3/NEWS gnome-shell-43.4/NEWS
--- gnome-shell-43.3/NEWS	2023-02-14 00:11:32.000000000 +0000
+++ gnome-shell-43.4/NEWS	2023-03-19 20:25:01.000000000 +0000
@@ -1,3 +1,17 @@
+43.4
+====
+* Plugged leak [Sebastian; !2652]
+* Misc. bug fixes and cleanups [Jonas, Sebastian; !2318, !2667]
+
+Contributors:
+  Jonas Dreßler, Sebastian Keller
+
+Translators:
+  Anders Jonsson [sv], Sabri Ünal [tr], Jiri Grönroos [fi],
+  Ekaterine Papava [ka], Hugo Carvalho [pt], Yuri Chornoivan [uk],
+  Kukuh Syafaat [id], Martin [sl], Tim Sabsch [de], Piotr Drąg [pl],
+  Aurimas Černius [lt], Мирослав Николић [sr], Balázs Úr [hu], Alan Paris [fr]
+
 43.3
 ====
 * Ensure quick settings toggles align with the pixel grid [Sebastian; !2577]
diff -Nru gnome-shell-43.3/subprojects/extensions-app/data/metainfo/org.gnome.Extensions.metainfo.xml.in gnome-shell-43.4/subprojects/extensions-app/data/metainfo/org.gnome.Extensions.metainfo.xml.in
--- gnome-shell-43.3/subprojects/extensions-app/data/metainfo/org.gnome.Extensions.metainfo.xml.in	2023-02-14 00:11:32.000000000 +0000
+++ gnome-shell-43.4/subprojects/extensions-app/data/metainfo/org.gnome.Extensions.metainfo.xml.in	2023-03-19 20:25:01.000000000 +0000
@@ -39,6 +39,7 @@
   </description>
 
   <releases>
+    <release version="43.4" date="2023-03-19"/>
     <release version="43.3" date="2023-02-13"/>
     <release version="43.2" date="2022-12-06"/>
     <release version="43.1" date="2022-10-22"/>
diff -Nru gnome-shell-43.3/subprojects/extensions-app/meson.build gnome-shell-43.4/subprojects/extensions-app/meson.build
--- gnome-shell-43.3/subprojects/extensions-app/meson.build	2023-02-14 00:11:32.000000000 +0000
+++ gnome-shell-43.4/subprojects/extensions-app/meson.build	2023-03-19 20:25:01.000000000 +0000
@@ -1,5 +1,5 @@
 project('gnome-extensions-app',
-  version: '43.3',
+  version: '43.4',
   meson_version: '>= 0.58.0',
   license: 'GPLv2+'
 )
diff -Nru gnome-shell-43.3/subprojects/extensions-app/subprojects/shew/meson.build gnome-shell-43.4/subprojects/extensions-app/subprojects/shew/meson.build
--- gnome-shell-43.3/subprojects/extensions-app/subprojects/shew/meson.build	2023-02-14 00:11:32.000000000 +0000
+++ gnome-shell-43.4/subprojects/extensions-app/subprojects/shew/meson.build	2023-03-19 20:25:01.000000000 +0000
@@ -1,5 +1,5 @@
 project('shew', 'c',
-  version: '43.3',
+  version: '43.4',
   meson_version: '>= 0.58.0',
   license: 'LGPLv2+',
 )
diff -Nru gnome-shell-43.3/subprojects/extensions-tool/meson.build gnome-shell-43.4/subprojects/extensions-tool/meson.build
--- gnome-shell-43.3/subprojects/extensions-tool/meson.build	2023-02-14 00:11:32.000000000 +0000
+++ gnome-shell-43.4/subprojects/extensions-tool/meson.build	2023-03-19 20:25:01.000000000 +0000
@@ -1,5 +1,5 @@
 project('gnome-extensions-tool', 'c',
-  version: '43.3',
+  version: '43.4',
   meson_version: '>= 0.58.0',
   license: 'GPLv2+'
 )
diff -Nru gnome-shell-43.3/subprojects/shew/meson.build gnome-shell-43.4/subprojects/shew/meson.build
--- gnome-shell-43.3/subprojects/shew/meson.build	2023-02-14 00:11:32.000000000 +0000
+++ gnome-shell-43.4/subprojects/shew/meson.build	2023-03-19 20:25:01.000000000 +0000
@@ -1,5 +1,5 @@
 project('shew', 'c',
-  version: '43.3',
+  version: '43.4',
   meson_version: '>= 0.58.0',
   license: 'LGPLv2+',
 )

Reply to: