Bug#1034097: unblock: tar/1.34+dfsg-1.2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: tar@packages.debian.org
Control: affects -1 + src:tar
Please unblock package tar
[ Reason ]
tar fails to build from source on 32 bits architectures (bug 1026204)
since the latest glibc version, because the test suite fails on files
with access dates outside of the 32-bit timestamps reach. This was
noticed because there was an NMU to fix the d/copyright. After quite
some discussion it was deemed best to enable lfs and -D_TIME_BITS=64
on 32 bits archs, which will be the default in the next tar upstream
version too.
[ Impact ]
Users on 32 bits systems wouldn't be able to rebuild tar. If there
would be a security update, it would fail to build too.
[ Tests ]
tar has a test suite that failed before the upload, now it passes.
[ Risks ]
In bug 1026204, wookey warned against implications of enabling 64-bit
time and large file system support, however the other people involved
in the bug and on IRC were convinced this was the right solution.
Because of this, I recommend to *not* age the package when unblocked,
but give it some time in unstable.
[ Checklist ]
[no] all changes are documented in the d/changelog
I only noticed when I started to request this unblock that there are
two new files in the previous NMU that were not mentioned:
debian/upstream/metadata and debian/salsa-ci.yml, but I consider both
harmless enough to not do a new upload for that.
[yes] I reviewed all changes and I approve them
[yes] attach debdiff against the package in testing
[ Other info ]
helmut promised on IRC to care for fallout if it would occur.
unblock tar/1.34+dfsg-1.2
diff -Nru tar-1.34+dfsg/debian/changelog tar-1.34+dfsg/debian/changelog
--- tar-1.34+dfsg/debian/changelog 2021-02-17 10:55:26.000000000 +0100
+++ tar-1.34+dfsg/debian/changelog 2023-04-06 16:25:47.000000000 +0200
@@ -1,3 +1,21 @@
+tar (1.34+dfsg-1.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Build with lfs and -D_TIME_BITS=64 on 32 bits archs (Closes: #1026204)
+ Thanks to Andreas Henriksson and Helge Deller
+
+ -- Paul Gevers <elbrus@debian.org> Thu, 06 Apr 2023 16:25:47 +0200
+
+tar (1.34+dfsg-1.1) unstable; urgency=medium
+
+ * Non-maintainer upload
+
+ [ Mechtilde ]
+ * [730f266] Improved d/copyright with patch
+ from Bastian Germann <bage@debian.org> (Closes: #1024084)
+
+ -- Mechtilde Stehmann <mechtilde@debian.org> Sun, 20 Nov 2022 15:52:41 +0100
+
tar (1.34+dfsg-1) unstable; urgency=medium
* New upstream version
diff -Nru tar-1.34+dfsg/debian/copyright tar-1.34+dfsg/debian/copyright
--- tar-1.34+dfsg/debian/copyright 2021-02-17 10:53:49.000000000 +0100
+++ tar-1.34+dfsg/debian/copyright 2023-04-06 16:25:47.000000000 +0200
@@ -1,38 +1,87 @@
-This is the Debian GNU/Linux prepackaged version of GNU tar. GNU
-tar, heavily based on John Gilmore's public domain version of tar,
-was originally written by Graham Todd. It is now maintained by
-Paul Eggert <eggert@twinsun.com>.
-
-This package is maintained for Debian by Janos Lenart <ocsi@debian.org>, and
-was built from the sources found at:
-
- ftp://ftp.gnu.org/gnu/tar/
-
-More recently, I'm directly using the upstream source repository at
-
- http://git.savannah.gnu.org/cgit/tar.git
-
-GNU tar is
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Comment:
+ This is the Debian GNU/Linux prepackaged version of GNU tar.
+ GNU tar, heavily based on John Gilmore's public domain version of tar,
+ was originally written by Graham Todd.
+ It is now maintained by Sergey Poznyakoff.
+ .
+ This package is maintained for Debian by Janos Lenart <ocsi@debian.org>.
+Upstream-Contact: bug-tar@gnu.org
+Source:
+ ftp://ftp.gnu.org/gnu/tar/
+ http://git.savannah.gnu.org/cgit/tar.git
+Files: *
+Copyright:
Copyright (C) 1988, 1992, 1993, 1994, 1995, 1996, 1997, 1999, 2000,
2001, 2003, 2004, 2005, 2006, 2007 Free Software Foundation, Inc.
-
+License: GPL-3+
This program is free software; you can redistribute it and/or modify it
under the terms of the GNU General Public License as published by the
Free Software Foundation; either version 3, or (at your option) any later
version.
-
-On Debian GNU/Linux systems, the complete text of the GNU General Public
-License version 3 can be found in /usr/share/common-licenses/GPL-3.
-
-The Debian packaging is
-
+Comment:
+ On Debian GNU/Linux systems, the complete text of the GNU General Public
+ License version 3 can be found in /usr/share/common-licenses/GPL-3.
+
+Files:
+ gnu/parse-datetime-gen.h
+ gnu/parse-datetime.c
+Copyright:
+ Copyright (C) 1984, 1989-1990, 2000-2015 Free Software Foundation, Inc.
+License: GPL-3+ with Bison exception
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+ .
+ As a special exception, you may create a larger work that contains
+ part or all of the Bison parser skeleton and distribute that work
+ under terms of your choice, so long as that work isn't itself a
+ parser generator using the skeleton or a modified version thereof
+ as a parser skeleton. Alternatively, if you modify or redistribute
+ the parser skeleton itself, you may (at your option) remove this
+ special exception, which will cause the skeleton and the resulting
+ Bison output files to be licensed under the GNU General Public
+ License without this special exception.
+ .
+ This special exception was added by the Free Software Foundation in
+ version 2.2 of Bison.
+Comment:
+ On Debian GNU/Linux systems, the complete text of the GNU General Public
+ License version 3 can be found in /usr/share/common-licenses/GPL-3.
+
+Files:
+ tests/argcv.*
+Copyright:
+ Copyright (C) 1999, 2000, 2001, 2007, 2009, 2010 Free Software
+ Foundation, Inc.
+License: LGPL-3+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 3 of the License, or (at your option) any later version.
+Comment:
+ On Debian GNU/Linux systems, the complete text of the GNU Lesser General
+ Public License version 3 can be found in /usr/share/common-licenses/LGPL-3.
+
+Files:
+ debian/*
+Copyright:
Copyright (C) 2006, 2007 Bdale Garbee <bdale@gag.com>
-
+License: GPL-2+
This program is free software; you can redistribute it and/or modify it
under the terms of the GNU General Public License as published by the
Free Software Foundation; either version 2, or (at your option) any later
version.
-
-On Debian GNU/Linux systems, the complete text of the GNU General Public
-License version 2 can be found in /usr/share/common-licenses/GPL-2.
+Comment:
+ On Debian GNU/Linux systems, the complete text of the GNU General Public
+ License version 2 can be found in /usr/share/common-licenses/GPL-2.
diff -Nru tar-1.34+dfsg/debian/rules tar-1.34+dfsg/debian/rules
--- tar-1.34+dfsg/debian/rules 2021-02-17 10:53:49.000000000 +0100
+++ tar-1.34+dfsg/debian/rules 2023-04-06 16:25:47.000000000 +0200
@@ -1,15 +1,23 @@
#!/usr/bin/make -f
+include /usr/share/dpkg/architecture.mk
+
DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
ifneq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
CONFARGS = --host=$(DEB_HOST_GNU_TYPE)
endif
-CFLAGS = `dpkg-buildflags --get CFLAGS`
-CFLAGS += -Wall -Wno-analyzer-null-argument
-LDFLAGS += `dpkg-buildflags --get LDFLAGS`
-CPPFLAGS = `dpkg-buildflags --get CPPFLAGS`
+export DEB_BUILD_MAINT_OPTIONS = future=+lfs
+export DEB_CFLAGS_MAINT_APPEND = -Wall -Wno-analyzer-null-argument
+# Workaround gnulib issue: The below three lines can be dropped once
+# tar >= 1.35 is used.
+ifeq (32,$(DEB_HOST_ARCH_BITS))
+export DEB_CPPFLAGS_MAINT_APPEND = -D_TIME_BITS=64
+endif
+
+DPKG_EXPORT_BUILDFLAGS = 1
+include /usr/share/dpkg/buildflags.mk
export BUILD_DATE = $(shell dpkg-parsechangelog | sed -n -e 's/^Date: //p')
diff -Nru tar-1.34+dfsg/debian/salsa-ci.yml tar-1.34+dfsg/debian/salsa-ci.yml
--- tar-1.34+dfsg/debian/salsa-ci.yml 1970-01-01 01:00:00.000000000 +0100
+++ tar-1.34+dfsg/debian/salsa-ci.yml 2023-04-06 16:25:47.000000000 +0200
@@ -0,0 +1,3 @@
+include:
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
diff -Nru tar-1.34+dfsg/debian/upstream/metadata tar-1.34+dfsg/debian/upstream/metadata
--- tar-1.34+dfsg/debian/upstream/metadata 1970-01-01 01:00:00.000000000 +0100
+++ tar-1.34+dfsg/debian/upstream/metadata 2023-04-06 16:25:47.000000000 +0200
@@ -0,0 +1,41 @@
+# You can find a description at
+# https://wiki.debian.org/UpstreamMetadata
+# Archive:
+# ASCL-id:
+Bug-Database:
+Bug-Submit:
+# Cite-As:
+Changelog:
+# CPE:
+Documentation:
+# Donation:
+# FAQ:
+# Funding:
+# Gallery:
+# Other-References:
+# Reference:
+# Author:
+# Booktitle:
+# DOI:
+# Editor:
+# Eprint:
+# ISBN:
+# ISSN:
+# Journal:
+# Number:
+# Pages:
+# PMID:
+# Publisher:
+# Title:
+# Type:
+# URL:
+# Volume:
+# Year:
+# Debian-package:
+# Registration:
+# Registry:
+Repository:
+Repository-Browse:
+# Screenshots:
+# Security-Contact:
+# Webservice:
Reply to: