Bug#1033840: unblock: castle-game-engine/7.0~alpha.2+dfsg1-3
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package castle-game-engine
[ Reason ]
Many lintian errors which can be fixed without any risk of regressions.
[ Impact ]
There should not be any impact. Only unused files are removed and using Debian
packaged jquery instead of a web based version.
[ Tests ]
Tested documentation to ensure that Debian packaged jquery works as the web
based version it replaced.
[ Risks ]
Documentation browsing may be not optimal, but unlikely.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
[ Other info ]
The changes are not intrusive and should help having a cleaner package for
Bookworm with less lintian detected errors, while almost no risk.
unblock castle-game-engine/7.0~alpha.2+dfsg1-3
diff -Nru castle-game-engine-7.0~alpha.2+dfsg1/debian/changelog castle-game-engine-7.0~alpha.2+dfsg1/debian/changelog
--- castle-game-engine-7.0~alpha.2+dfsg1/debian/changelog 2022-10-24 20:19:14.000000000 +0200
+++ castle-game-engine-7.0~alpha.2+dfsg1/debian/changelog 2023-04-02 16:44:18.000000000 +0200
@@ -1,3 +1,15 @@
+castle-game-engine (7.0~alpha.2+dfsg1-3) unstable; urgency=medium
+
+ * Removed unused binary files to fix lintian reported errors.
+ Removed files are either unused statically liked libraries or some
+ supplied windows programs or npm ignore file.
+ These files were included in the source packages, but are not useful for
+ Debian users.
+ * Replaced use of web based jquery.js with debian packaged version.
+ Added dependency on libjs-jquery dor documentation package.
+
+ -- Abou Al Montacir <abou.almontacir@sfr.fr> Sun, 02 Apr 2023 16:44:18 +0200
+
castle-game-engine (7.0~alpha.2+dfsg1-2) unstable; urgency=medium
* Fixed build issue on arm64 and ppc64el.
diff -Nru castle-game-engine-7.0~alpha.2+dfsg1/debian/control castle-game-engine-7.0~alpha.2+dfsg1/debian/control
--- castle-game-engine-7.0~alpha.2+dfsg1/debian/control 2022-09-18 21:58:19.000000000 +0200
+++ castle-game-engine-7.0~alpha.2+dfsg1/debian/control 2023-04-02 16:15:36.000000000 +0200
@@ -76,11 +76,11 @@
${misc:Depends},
fonts-droid-fallback,
fonts-dejavu-core,
+ libjs-bootstrap,
+ libjs-jquery,
Suggests:
castle-game-engine-src,
fp-units-castle-game-engine,
- libjs-bootstrap,
- libjs-jquery,
Multi-Arch: foreign
Description: Castle Game Engine - Developer's Documentation
Castle Game Engine is a set of LGPL licenced libraries that are intended to
diff -Nru castle-game-engine-7.0~alpha.2+dfsg1/debian/patches/Replaced-web-baseed-jquery-by-local-version.patch castle-game-engine-7.0~alpha.2+dfsg1/debian/patches/Replaced-web-baseed-jquery-by-local-version.patch
--- castle-game-engine-7.0~alpha.2+dfsg1/debian/patches/Replaced-web-baseed-jquery-by-local-version.patch 1970-01-01 01:00:00.000000000 +0100
+++ castle-game-engine-7.0~alpha.2+dfsg1/debian/patches/Replaced-web-baseed-jquery-by-local-version.patch 2023-04-02 16:11:17.000000000 +0200
@@ -0,0 +1,70 @@
+Description: Replaced web baseed jquery by local version
+ Lintian doesn't like to use web based jquery.
+ We use locally installed verision from libjs-jquery.
+Author: Abou Al Montacir <abou.almotacir@sfr.fr>
+
+diff --git a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example1/index.html b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example1/index.html
+index 8f10b93..98bca68 100644
+--- a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example1/index.html
++++ b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example1/index.html
+@@ -9,7 +9,7 @@
+ h2{font-size:13px; margin:15px 0 0 0;}
+ </style>
+ <link rel="stylesheet" href="colorbox.css" />
+- <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js";></script>
++ <script src="file:///usr/share/javascript/jquery/jquery.min.js"></script>
+ <script src="../jquery.colorbox.js"></script>
+ <script>
+ $(document).ready(function(){
+diff --git a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example2/index.html b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example2/index.html
+index 8f10b93..98bca68 100644
+--- a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example2/index.html
++++ b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example2/index.html
+@@ -9,7 +9,7 @@
+ h2{font-size:13px; margin:15px 0 0 0;}
+ </style>
+ <link rel="stylesheet" href="colorbox.css" />
+- <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js";></script>
++ <script src="file:///usr/share/javascript/jquery/jquery.min.js"></script>
+ <script src="../jquery.colorbox.js"></script>
+ <script>
+ $(document).ready(function(){
+diff --git a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example3/index.html b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example3/index.html
+index 8f10b93..98bca68 100644
+--- a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example3/index.html
++++ b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example3/index.html
+@@ -9,7 +9,7 @@
+ h2{font-size:13px; margin:15px 0 0 0;}
+ </style>
+ <link rel="stylesheet" href="colorbox.css" />
+- <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js";></script>
++ <script src="file:///usr/share/javascript/jquery/jquery.min.js"></script>
+ <script src="../jquery.colorbox.js"></script>
+ <script>
+ $(document).ready(function(){
+diff --git a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example4/index.html b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example4/index.html
+index 8f10b93..98bca68 100644
+--- a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example4/index.html
++++ b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example4/index.html
+@@ -9,7 +9,7 @@
+ h2{font-size:13px; margin:15px 0 0 0;}
+ </style>
+ <link rel="stylesheet" href="colorbox.css" />
+- <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js";></script>
++ <script src="file:///usr/share/javascript/jquery/jquery.min.js"></script>
+ <script src="../jquery.colorbox.js"></script>
+ <script>
+ $(document).ready(function(){
+diff --git a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example5/index.html b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example5/index.html
+index 8f10b93..98bca68 100644
+--- a/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example5/index.html
++++ b/doc/pasdoc/html-parts/castle-engine-website-base/node_modules/jquery-colorbox/example5/index.html
+@@ -9,7 +9,7 @@
+ h2{font-size:13px; margin:15px 0 0 0;}
+ </style>
+ <link rel="stylesheet" href="colorbox.css" />
+- <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js";></script>
++ <script src="file:///usr/share/javascript/jquery/jquery.min.js"></script>
+ <script src="../jquery.colorbox.js"></script>
+ <script>
+ $(document).ready(function(){
diff -Nru castle-game-engine-7.0~alpha.2+dfsg1/debian/rules castle-game-engine-7.0~alpha.2+dfsg1/debian/rules
--- castle-game-engine-7.0~alpha.2+dfsg1/debian/rules 2022-10-02 14:59:29.000000000 +0200
+++ castle-game-engine-7.0~alpha.2+dfsg1/debian/rules 2023-04-02 16:37:28.000000000 +0200
@@ -140,6 +140,13 @@
${MAKE} -C doc/pasdoc ${DOCTYPE}
# pasdoc create a jquery file, but we link from jquery instead
${RM} doc/reference/tipuesearch/jquery.min.js
+ # Remove .npmignore file as Lintian complains about it.
+ ${RM} doc/reference/castle-engine-website-base/node_modules/slick-carousel/.npmignore
+ # Remove statically linked libraries from source packages as Lintian
+ # complains about it.
+ ${RM} src/vampyre_imaginglib/src/Extensions/*/*.a
+ # Remove windows executable files as Lintian complains about them.
+ ${RM} tools/contrib/x86_64-win64
override_dh_auto_install-indep: install-source
Reply to: