Control: tags -1 moreinfo On 27-03-2023 18:15, Eberhard Beilharz wrote:
While keyman has autopkgtests and so would qualify for automatic migration, the tests are skipped on s390x.
Ack.
Included are only small changes: one is a small fix in the postinst script,
-set -e +# Don't call `set -e`. Even if some commands should fail, it's still +# worth running the rest of the commands.Can you elaborate? I could imagine you want to run the rest of the commands, but if there is any failure, shouldn't that be recorded and used as the exit code? With the current change, the admin isn't going to be aware of issues at all, which feels weird (why would you run the postinst then in the first place). See also policy 6.1 [1].
> Another reason why I'd like to get this version approved is that it brings the version in Debian on par with the upstream
version which simplifies user help requests.Did I miss something but is the *only* change upstream the addition echo? Doesn't feel very appropriate at this stage...
Paul[1] https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#introduction-to-package-maintainer-scripts
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature