Paul Gevers:
Hi, On 20-03-2023 17:16, Hans-Christoph Steiner wrote:I haven't really ever been able to troubleshoot it. I don't have access to a s390x box. And:~ $ ssh zelenka.debian.org ssh: connect to host zelenka.debian.org port 22: Connection timed out ~ $ That's the only porterbox I could find.It works for me (now). Can you try again?
I got in.
Also, you don't strictly need to troubleshoot it. Obviously it depends on how sure you are it's in your dependency, but you said it quite convinced.
I'm 100% sure its the dependency, and I just confirmed it on the porterbox and filed a bug upstream:
https://github.com/androguard/androguard/issues/928
Normally we expect a debdiff attached to an unblock. This is mostly to trigger the submitter to look at it and make sure that all changes are explained. Can you please elaborate on the changes in ./debian/?^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* zipalign is no longer used by fdroidserver * these patches were upstreamed: debian/patches/0005-handle-str-and-pathlib.Path-in-getvcs.patch was upstreamed debian/patches/0006-Fix-openjdk-detection-on-different-architectures.patch debian/patches/fix-java-paths-for-non-amd64.patch
The debdiff is large because we were working upstream on 2.2.x as the release that is tied to Debian/bookworm (attached).Sure, I already used some tooling on our side to inspect it. It would help if you took a look and see if you spot things worth mentioning (e.g. some patches being dropped, I don't want to assume things). To reduce the diff you could ignore the tests and translations.
There were changes related to have I mentioned above, like purging dead code related to zipalign, buildozer, and bug fixes related to a recent port to use pathlib.
Also, there were methods added to support verifying JARs and APKs signed by SHA1, which are still considered valid by the Android apksigner tool, though Java has dropped support for verifying SHA1 signatures.
The download_repo_index_v2() function was to finalize the whole "index-v2" work that was completed in fdroidserver 2.2.x. That was the one last key missing bit.