[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1033236: marked as done (unblock: apktool/2.7.0+dfsg-6)

Your message dated Tue, 21 Mar 2023 22:09:09 +0100
with message-id <f079263b-8c48-fcfd-ccb2-a24b0234d6ec@debian.org>
and subject line Re: Bug#1033236: unblock: apktool/2.7.0+dfsg-5
has caused the Debian Bug report #1033236,
regarding unblock: apktool/2.7.0+dfsg-6
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1033236: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033236
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: apktool@packages.debian.org
Control: affects -1 + src:apktool

Please unblock package apktool

[ Reason ]

To fix the RC bug #1033226.

[ Impact ]
The core feature of `apktool build` will not work at all because it can't find a JAR. 

[ Tests ]

I added a new test to cover a full cycle:

    apktool decode
    check if extracted file exists
    apktool build
    check if new APK file exists

[ Risks ]

Its a trivial fix, just fixing a symlink, I see no risks.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock apktool/2.7.0+dfsg-5
diff --git a/debian/changelog b/debian/changelog
index d439603..1884587 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+apktool (2.7.0+dfsg-5) unstable; urgency=medium
+
+  * fix broken symlink to commons-text.jar (Closes: #1033226)
+
+ -- Hans-Christoph Steiner <hans@eds.org>  Mon, 20 Mar 2023 14:00:20 +0100
+
 apktool (2.7.0+dfsg-4) unstable; urgency=medium
 
   * fix arch detection for Depends:
diff --git a/debian/links b/debian/links
index 2c167db..779d62e 100644
--- a/debian/links
+++ b/debian/links
@@ -2,7 +2,7 @@ usr/share/java/antlr3-runtime.jar usr/share/apktool/antlr3-runtime.jar
 usr/share/java/commons-cli.jar usr/share/apktool/commons-cli.jar
 usr/share/java/commons-io.jar usr/share/apktool/commons-io.jar
 usr/share/java/commons-lang3.jar usr/share/apktool/commons-lang3.jar
-usr/share/java/commons-text-1.9.jar usr/share/apktool/commons-text-1.9.jar
+usr/share/java/commons-text.jar usr/share/apktool/commons-text.jar
 usr/share/java/guava.jar usr/share/apktool/guava.jar
 usr/share/java/snakeyaml.jar usr/share/apktool/snakeyaml.jar
 usr/share/java/stringtemplate.jar usr/share/apktool/stringtemplate.jar
diff --git a/debian/tests/control b/debian/tests/control
index 298f6e5..af602dd 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,4 +1,4 @@
 # urzip.apk comes from https://github.com/eighthave/urzip via https://gitlab.com/fdroid/fdroidserver
-Test-Command: apktool d debian/tests/urzip.apk && test -e urzip/smali/info/guardianproject/urzip/UnZipper.smali
+Test-Command: apktool d debian/tests/urzip.apk && test -e urzip/smali/info/guardianproject/urzip/UnZipper.smali && apktool b urzip/ && test -e urzip/dist/urzip.apk
 Depends: apktool
 Restrictions: allow-stderr

--- End Message ---
--- Begin Message --- 
Hi Hans-Christoph.

On 20-03-2023 16:08, Hans-Christoph Steiner wrote:

Please unblock package apktool


apktool isn't blocked, it just needs to age a bit.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: