[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1032526: marked as done ([pre-approval] unblock: dar/2.7.8-2)

Your message dated Wed, 15 Mar 2023 09:07:43 +0000
with message-id <ZBGK31Rn02F5XUOl@powdarrmonkey.net>
and subject line Re: Bug#1032526: [pre-approval] unblock: dar/2.7.8-2
has caused the Debian Bug report #1032526,
regarding [pre-approval] unblock: dar/2.7.8-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1032526: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032526
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: jgoerzen@complete.org
Control: affects -1 + src:dar

Hi RMs,

Please pre-approve a feature enabled version of dar.

[ Reason ]
John Goerzen updated build dependencies to reflect the libext2fs-dev
rename, added delta changes support with rsync (previously I've not
enabled it as it didn't have the static library to use with
dar-static) and use Linux capabilities support.

[ Impact ]
Users will get a more feature rich version of dar.

[ Tests ]
The delta changes testing done by John, I did only build and basic testing.

[ Risks ]
I don't know any. No code change, only enable features that are
present in the source code already.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

Thanks for consideration,
Laszlo/GCS

diff -Nru dar-2.7.8/debian/changelog dar-2.7.8/debian/changelog
--- dar-2.7.8/debian/changelog	2022-12-04 15:57:33.000000000 +0100
+++ dar-2.7.8/debian/changelog	2023-03-08 18:14:41.000000000 +0100
@@ -1,3 +1,17 @@
+dar (2.7.8-2) unstable; urgency=medium
+
+  [ John Goerzen ]
+  * Support delta changes via librsync.
+  * Update dep on e2fslibs-dev to new name libext2fs-dev
+  * Add dep on libcap-dev to eneable proper capability handling.
+  * Add build-dependency on dot to ensure figures for docs are always
+    built.
+
+  [ Laszlo Boszormenyi (GCS) ]
+  * Build depend on libcap-dev only on Linux architectures.
+
+ -- Laszlo Boszormenyi (GCS) <gcs@debian.org>  Wed, 08 Mar 2023 18:14:41 +0100
+
 dar (2.7.8-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru dar-2.7.8/debian/control dar-2.7.8/debian/control
--- dar-2.7.8/debian/control	2022-12-04 15:57:33.000000000 +0100
+++ dar-2.7.8/debian/control	2023-03-08 18:14:41.000000000 +0100
@@ -3,9 +3,11 @@
 Priority: optional
 Maintainer: Laszlo Boszormenyi (GCS) <gcs@debian.org>
 Build-Depends: debhelper-compat (= 13), pkg-config, zlib1g-dev, libbz2-dev,
- libzstd-dev, liblzo2-dev, liblzma-dev, liblz4-dev, e2fslibs-dev,
- libgcrypt20-dev, libgpgme-dev, libassuan-dev, libargon2-dev, doxygen, groff
-Build-Conflicts: libcurl4-gnutls-dev, libcurl4-openssl-dev, librsync-dev
+ libzstd-dev, liblzo2-dev, liblzma-dev, liblz4-dev, libext2fs-dev,
+ libgcrypt20-dev, libgpgme-dev, libassuan-dev, libargon2-dev,
+ librsync-dev, libcap-dev [linux-any],
+ doxygen, groff, graphviz
+Build-Conflicts: libcurl4-gnutls-dev, libcurl4-openssl-dev
 Standards-Version: 4.6.1
 Rules-Requires-Root: no
 Homepage: http://dar.linux.free.fr/
diff -Nru dar-2.7.8/debian/rules dar-2.7.8/debian/rules
--- dar-2.7.8/debian/rules	2022-12-04 15:57:33.000000000 +0100
+++ dar-2.7.8/debian/rules	2023-03-08 18:14:41.000000000 +0100
@@ -4,13 +4,18 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
+DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
+
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 
 DEB_CONFIGURE_EXTRA_FLAGS := --disable-upx --disable-python-binding \
 			     --enable-mode=64
 DEB_CONFIGURE_EXTRA_FLAGS += --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH)
 
-BUILT_USING_PACKAGES = libc-dev-bin libattr1-dev libbz2-dev libgcrypt20-dev libgpgme-dev liblzo2-dev zlib1g-dev libzstd-dev liblz4-dev libargon2-dev libassuan-dev
+BUILT_USING_PACKAGES = libc-dev-bin libbz2-dev libgcrypt20-dev libgpgme-dev liblzo2-dev zlib1g-dev libzstd-dev liblz4-dev libargon2-dev libassuan-dev librsync-dev libext2fs-dev
+ifeq ($(DEB_HOST_ARCH_OS), linux)
+BUILT_USING_PACKAGES += libcap-dev
+endif
 
 BUILT_USING=$(shell dpkg-query -f '$${source:Package} (= $${source:Version}), ' -W $(BUILT_USING_PACKAGES))

--- End Message ---
--- Begin Message --- 
On Wed, Mar 08, 2023 at 07:32:06PM +0100, László Böszörményi wrote:
> Please pre-approve a feature enabled version of dar.
> 
> [ Reason ]
> John Goerzen updated build dependencies to reflect the libext2fs-dev
> rename, added delta changes support with rsync (previously I've not
> enabled it as it didn't have the static library to use with
> dar-static) and use Linux capabilities support.
> 
> [ Impact ]
> Users will get a more feature rich version of dar.

NACK, sorry. Even at the time you filed this request the criteria was
"targetted fixes only", and feature releases do not qualify.

Thanks,

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1

--- End Message ---
Reply to: