[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1032923: marked as done (unblock: ftools-fv/5.5.2+dfsg-2)



Your message dated Tue, 14 Mar 2023 09:03:24 +0000
with message-id <ZBA4XC2eatpoEhZJ@powdarrmonkey.net>
and subject line Re: Bug#1032923: unblock: ftools-fv/5.5.2+dfsg-2
has caused the Debian Bug report #1032923,
regarding unblock: ftools-fv/5.5.2+dfsg-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1032923: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032923
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: unblock
Severity: normal

Please unblock package ftools-fv.

The new version fixes the "important" bug #1032280 "fv may not start if another Tcl/Tk is installed". This is accompanied by a no-change-needed push of the Standards Version in d/control.

The package does not come with autopkgtests and therefore requires a manual unblock in hard freeze. It is a zero-day miss of the "Hard Freeze" milestone.

This is a leaf package. There are no risks accompanied with the update.

Debdiff:

diff -Nru ftools-fv-5.5.2+dfsg/debian/changelog ftools-fv-5.5.2+dfsg/debian/changelog --- ftools-fv-5.5.2+dfsg/debian/changelog 2020-09-04 11:16:57.000000000 +0200 +++ ftools-fv-5.5.2+dfsg/debian/changelog 2023-03-02 22:33:03.000000000 +0100
@@ -1,3 +1,11 @@
+ftools-fv (5.5.2+dfsg-2) unstable; urgency=medium
+
+  * Make sure the correct "wish" is executed when fv is started
+    (Closes: #1032280)
+  * Push Standards-Version to 4.6.2, no changes
+
+ -- Ole Streicher <olebole@debian.org>  Thu, 02 Mar 2023 22:33:03 +0100
+
 ftools-fv (5.5.2+dfsg-1) unstable; urgency=low

   * New upstream version 5.5.2+dfsg. Rediff patches
diff -Nru ftools-fv-5.5.2+dfsg/debian/control ftools-fv-5.5.2+dfsg/debian/control
--- ftools-fv-5.5.2+dfsg/debian/control	2020-09-04 11:16:17.000000000 +0200
+++ ftools-fv-5.5.2+dfsg/debian/control	2023-03-02 22:33:03.000000000 +0100
@@ -1,23 +1,26 @@
 Source: ftools-fv
-Section: science
-Priority: optional
Maintainer: Debian Astro Team <debian-astro-maintainers@lists.alioth.debian.org>
 Uploaders: Ole Streicher <olebole@debian.org>
+Section: science
+Priority: optional
 Build-Depends: debhelper-compat (= 13),
                libcfitsio-dev,
                tcl-dev,
                tk-dev,
                wcslib-dev
-Standards-Version: 4.5.0
-Homepage: https://heasarc.gsfc.nasa.gov/docs/software/lheasoft/ftools/fv/
-Vcs-Git: https://salsa.debian.org/debian-astro-team/ftools-fv.git
+Standards-Version: 4.6.2
 Vcs-Browser: https://salsa.debian.org/debian-astro-team/ftools-fv
+Vcs-Git: https://salsa.debian.org/debian-astro-team/ftools-fv.git
+Homepage: https://heasarc.gsfc.nasa.gov/docs/software/lheasoft/ftools/fv/
 Rules-Requires-Root: no

 Package: ftools-fv
 Architecture: all
-Depends: ftools-pow, iwidgets4, ${misc:Depends}
-Suggests: saods9, xpa-tools
+Depends: ftools-pow,
+         iwidgets4,
+         ${misc:Depends}
+Suggests: saods9,
+          xpa-tools
 Description: Tool for viewing and editing FITS format files
  Fv provides a graphical user interface to data stored in FITS
  (Flexible Image Transport System) files.  Local files can be created,
diff -Nru ftools-fv-5.5.2+dfsg/debian/patches/Fv-Change-default-temp-location-to-tmp.patch ftools-fv-5.5.2+dfsg/debian/patches/Fv-Change-default-temp-location-to-tmp.patch --- ftools-fv-5.5.2+dfsg/debian/patches/Fv-Change-default-temp-location-to-tmp.patch 2020-09-04 11:12:32.000000000 +0200 +++ ftools-fv-5.5.2+dfsg/debian/patches/Fv-Change-default-temp-location-to-tmp.patch 2023-03-02 22:33:03.000000000 +0100
@@ -6,14 +6,14 @@
the home directory. This patch moves the temp files there while keeping the
 FVTMP behaviour intact.
 ---
- ftools/guis/fv/class/fvApp.tcl | 22 +++++++++++++++-------
- 1 file changed, 15 insertions(+), 7 deletions(-)
+ ftools/guis/fv/class/fvApp.tcl | 24 ++++++++++++++++--------
+ 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/ftools/guis/fv/class/fvApp.tcl b/ftools/guis/fv/class/fvApp.tcl
-index e347cf0..74b8f26 100644
+index e347cf0..60547db 100644
 --- a/ftools/guis/fv/class/fvApp.tcl
 +++ b/ftools/guis/fv/class/fvApp.tcl
-@@ -445,37 +445,45 @@ itcl::body fvApp::_setupBackup { } {
+@@ -445,44 +445,52 @@ itcl::body fvApp::_setupBackup { } {
     if { $isWin } {
        set fvBackupDir "fv_tmp"
        set fvHOME FV_HOME
@@ -66,3 +66,11 @@
        if ![file exists $g_backupDir] {
  	 file mkdir $g_backupDir
        }
+    }
+
+    # cleanup previous temp directory
+- set backupList [eval glob -directory {[file dirname $g_backupDir]} -nocomplain "*"] ++ set backupList [eval glob -directory {[file dirname $g_backupDir]} -nocomplain "fvTmp_*_*"]
+
+    foreach dirname $backupList {
+        set token [split [file tail $dirname] "_"]
diff -Nru ftools-fv-5.5.2+dfsg/debian/patches/Fv-Replace-the-startup-script-by-something-simpler.patch ftools-fv-5.5.2+dfsg/debian/patches/Fv-Replace-the-startup-script-by-something-simpler.patch --- ftools-fv-5.5.2+dfsg/debian/patches/Fv-Replace-the-startup-script-by-something-simpler.patch 2020-09-04 11:12:32.000000000 +0200 +++ ftools-fv-5.5.2+dfsg/debian/patches/Fv-Replace-the-startup-script-by-something-simpler.patch 2023-03-02 22:33:03.000000000 +0100
@@ -9,7 +9,7 @@
  2 files changed, 4 insertions(+), 121 deletions(-)

 diff --git a/ftools/guis/fv/fv b/ftools/guis/fv/fv
-index 49afa8e..d6edc4c 100755
+index 49afa8e..d3cf700 100755
 --- a/ftools/guis/fv/fv
 +++ b/ftools/guis/fv/fv
 @@ -1,119 +1,5 @@
@@ -135,7 +135,7 @@
 +export FITSVIEWER_LIBRARY=/usr/share/ftools/fv
 +export FV_HELPDIR=/usr/share/doc/ftools-fv/doc
 +export XLIB_SKIP_ARGB_VISUALS=1
-+exec wish $FITSVIEWER_LIBRARY/fvInit.tcl -- "$@"
++exec /usr/bin/wish $FITSVIEWER_LIBRARY/fvInit.tcl -- "$@"
 diff --git a/ftools/guis/fv/fvInit.tcl b/ftools/guis/fv/fvInit.tcl
 index 413d1bf..fc4e3e5 100644
 --- a/ftools/guis/fv/fvInit.tcl

--- End Message ---
--- Begin Message ---
Hi,

On Tue, Mar 14, 2023 at 08:06:16AM +0100, Ole Streicher wrote:
> The new version fixes the "important" bug #1032280 "fv may not start if
> another Tcl/Tk is installed". This is accompanied by a no-change-needed push
> of the Standards Version in d/control.

... plus a change to cleaning up the temporary directory, and some
rearranging of control lines and comments.

It's really helpful next time to avoid noise in the diff with these things.
The temporary directory fix would be fine if it had a bug; unblocked.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1

--- End Message ---

Reply to: