[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1032065: marked as done (ola: request RT acknowledgement for update to upstream version 0.10.9)



Your message dated Mon, 27 Feb 2023 21:25:01 +0100
with message-id <58fa5fff-5e22-eb68-19ab-bdb6ab69440a@debian.org>
and subject line Re: Bug#1032065: ola: request RT acknowledgement for update to upstream version 0.10.9
has caused the Debian Bug report #1032065,
regarding ola: request RT acknowledgement for update to upstream version 0.10.9
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1032065: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032065
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal

Hi release team!

Since the current state of the freeze, I thought I'd check with you guys
before uploading ola 0.10.9.

A bit of background: there were a few compatibility bugs in ola 0.10.8
(currently in stable) which meant that it was kicked out of testing a
while back for FTBFS reasons.

In coordination with upstream, I uploaded a prerelease snapshot to
Debian in December that solves some, but not all, of the existing
issues. Upstream has since worked on fixing more issues and getting
0.10.9 out, and given that the difference between the current snapshot
in Debian and 0.10.9 is mostly bugs fixed, I would like to update to
0.10.9 -- but seen as how there are quite a number of things, and seen
as how it is a new upstream release (which technically isn't allowed
anymore, AIUI), I would like your go-ahead before I upload.

The full list of changes can be found at

https://github.com/OpenLightingProject/ola/compare/1b28e794...0.10.9

but it starts off with a number of changelogs and upstream CI things
(which we don't use), so you can ignore those and start at

https://github.com/OpenLightingProject/ola/compare/1b28e794...0.10.9#diff-d20d9f18d302fd0e8d90fc0b3f880090767ea56fd65f565a1dbb2dcf41c12135

Most of the changes are small bug fixes, spelling fixes, and a bunch of
reformatting in the python code. What's not:

- olad/www/new/*: this is precompiled in the upstream tarball from
  olad/www/new-src, removed before upload to Debian (hence the
  ".nojsmin" bit in the version -- I refuse to call this a ".dfsg"
  version because I don't agree it's a DFSG issue, but think of it as
  that)
- A number of tests were added (so there's better test coverage)
- Ola was in the midst of a reworking of some code that was still
  Python2-specific; the code that hadn't been ported has been
  (temporarily) disabled in the version that is currently in the
  archive. There are some new python files that are necessary to finish
  the Python3 transition for ola. This is mostly the RDM tester code;
  the package for that is currently disabled in testing and unstable,
  but that is a regression from stable -- it works there. There are a
  few new files to support that better (mostly some string handling
  utilities) and some extra tests, but nothing earth shattering.

Do I have the go ahead? If so I'll upload ASAP.

--- End Message ---
--- Begin Message ---
Hi Wouter,

On 27-02-2023 11:46, Wouter Verhelst wrote:
Most of the changes are small bug fixes, spelling fixes, and a bunch of
reformatting in the python code. What's not:

- olad/www/new/*: this is precompiled in the upstream tarball from
   olad/www/new-src, removed before upload to Debian (hence the
   ".nojsmin" bit in the version -- I refuse to call this a ".dfsg"
   version because I don't agree it's a DFSG issue, but think of it as
   that)
- A number of tests were added (so there's better test coverage)
- Ola was in the midst of a reworking of some code that was still
   Python2-specific; the code that hadn't been ported has been
   (temporarily) disabled in the version that is currently in the
   archive. There are some new python files that are necessary to finish
   the Python3 transition for ola. This is mostly the RDM tester code;
   the package for that is currently disabled in testing and unstable,
   but that is a regression from stable -- it works there. There are a
   few new files to support that better (mostly some string handling
   utilities) and some extra tests, but nothing earth shattering.

I haven't checked the changes myself, so I'll go and trust you on this description. You're right that this is a bit bigger than we'd normally want, but I follow your reasoning that this is probably worth the risk at this moment.

You have my ACK.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---

Reply to: