[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1014705: bullseye-pu: package xtables-addons/3.13-1



On 2022-07-10, at 17:19:16 +0100, Jeremy Sowden wrote:
> Package: release.debian.org
> Severity: normal
> Tags: bullseye
> User: release.debian.org@packages.debian.org
> Usertags: pu
> 
> The related xtables-addons bug is:
> 
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014680
> 
> [ Reason ]
> xtables-addons-dkms and xtables-addons-source contain sources for building
> kernel modules with DKMS and module-assistant, respectively.  The 5.10.0-16
> kernel introduced in the 11.4 point release included a patch back-ported from
> 5.11 to 5.10.121:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/include/net/route.h?h=linux-5.10.y&id=6950ee32c1879818de03f13a9a5de1be41ad2782
> 
> This changes the parameters of the `security_skb_classify_flow` function, which
> is called by one of the xtables-addons kernel modules, xt_ECHO.c.  The calling
> code has been updated to pass the correct argument in a later upstream release.
> However, the version in Bullseye now fails to build:
> 
>   /var/lib/dkms/xtables-addons/3.13/build/extensions/xt_ECHO.c: In function 'echo_tg6':
>   /var/lib/dkms/xtables-addons/3.13/build/extensions/xt_ECHO.c:100:55: error: passing argument 2 of 'security_skb_classify_flow' from incompatible pointer type [-Werror=incompatible-pointer-types]
>     100 |  security_skb_classify_flow((struct sk_buff *)oldskb, flowi6_to_flowi(&fl));
>         |                                                       ^~~~~~~~~~~~~~~~~~~~
>         |                                                       |
>         |                                                       struct flowi *
>   In file included from /usr/src/linux-headers-5.10.0-16-common/include/net/scm.h:8,
>                    from /usr/src/linux-headers-5.10.0-16-common/include/linux/netlink.h:9,
>                    from /usr/src/linux-headers-5.10.0-16-common/include/uapi/linux/neighbour.h:6,
>                    from /usr/src/linux-headers-5.10.0-16-common/include/linux/netdevice.h:46,
>                    from /usr/src/linux-headers-5.10.0-16-common/include/net/inet_sock.h:19,
>                    from /usr/src/linux-headers-5.10.0-16-common/include/linux/udp.h:16,
>                    from /var/lib/dkms/xtables-addons/3.13/build/extensions/xt_ECHO.c:15:
>   /usr/src/linux-headers-5.10.0-16-common/include/linux/security.h:1660:75: note: expected 'struct flowi_common *' but argument is of type 'struct flowi *'
>    1660 | void security_skb_classify_flow(struct sk_buff *skb, struct flowi_common *flic);
>         |                                                      ~~~~~~~~~~~~~~~~~~~~~^~~~

I've uploaded the package.

J.

Attachment: signature.asc
Description: PGP signature


Reply to: