[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1013237: bullseye-pu: package phpmyadmin/4:5.0.4+dfsg2-2+deb11u1



Subject: bullseye-pu: package phpmyadmin/4:5.0.4+dfsg2-2+deb11u1
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: pu
Tags: bullseye
X-Debbugs-Cc: williamdes@wdes.fr
Severity: normal

[ Reason ]

Some users have 500 errors when using some queries.
Previous versions of Debian where not affected.

[ Impact ]

The users will continue to have 500 errors with some queries if it is not fixed, making phpMyAdmin not nice to use.

[ Tests ]

The fix was tested upstream and distributed on multiple versions.

The package has autopkgtests and unit tests are also launched on package build step.
This fix/patch was successfully tested in production by the bug reporter.

[ Risks ]

None. The patch is trivial.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]

I added a type cast using the upstream patch.

[ Other info ]

Closes: #1012847

Salsa CI did build this successfully: https://salsa.debian.org/phpmyadmin-team/phpmyadmin/-/pipelines/390656

diff -Nru phpmyadmin-5.0.4+dfsg2/debian/changelog phpmyadmin-5.0.4+dfsg2/debian/changelog
--- phpmyadmin-5.0.4+dfsg2/debian/changelog	2021-01-23 17:25:13.000000000 +0100
+++ phpmyadmin-5.0.4+dfsg2/debian/changelog	2022-06-19 18:58:24.000000000 +0200
@@ -1,3 +1,9 @@
+phpmyadmin (4:5.0.4+dfsg2-2+deb11u1) bullseye; urgency=medium
+
+  * Add a patch for error 500 with some SQL queries (Closes: #1012847)
+
+ -- William Desportes <williamdes@wdes.fr>  Sun, 19 Jun 2022 18:58:24 +0200
+
 phpmyadmin (4:5.0.4+dfsg2-2) unstable; urgency=medium
 
   * Add a patch for CVE-2021-21252
diff -Nru phpmyadmin-5.0.4+dfsg2/debian/patches/Fix-SQL-query-server-error.patch phpmyadmin-5.0.4+dfsg2/debian/patches/Fix-SQL-query-server-error.patch
--- phpmyadmin-5.0.4+dfsg2/debian/patches/Fix-SQL-query-server-error.patch	1970-01-01 01:00:00.000000000 +0100
+++ phpmyadmin-5.0.4+dfsg2/debian/patches/Fix-SQL-query-server-error.patch	2022-06-19 18:56:52.000000000 +0200
@@ -0,0 +1,24 @@
+From: William Desportes <williamdes@wdes.fr>
+Date: Wed, 15 Jun 2022 19:01:40 +0200
+Subject: Fix - (500 Internal Server Error) with some SQL queries
+
+Origin: upstream
+Applied-Upstream: https://github.com/phpmyadmin/phpmyadmin/commit/16f81e47eab289b13bf39ed2ca6c3c0b0c923845
+Bug-Debian: https://bugs.debian.org/1012847
+---
+ libraries/classes/Display/Results.php | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libraries/classes/Display/Results.php b/libraries/classes/Display/Results.php
+index 42cdc0f..cd79aba 100644
+--- a/libraries/classes/Display/Results.php
++++ b/libraries/classes/Display/Results.php
+@@ -2138,7 +2138,7 @@ class Results
+
+         $draggable_html .= ' class="' . implode(' ', $th_class) . '"';
+
+-        $draggable_html .= ' data-column="' . htmlspecialchars($fields_meta->name)
++        $draggable_html .= ' data-column="' . htmlspecialchars((string) $fields_meta->name)
+             . '">' . $order_link . $comments . '</th>';
+
+         return $draggable_html;
diff -Nru phpmyadmin-5.0.4+dfsg2/debian/patches/series phpmyadmin-5.0.4+dfsg2/debian/patches/series
--- phpmyadmin-5.0.4+dfsg2/debian/patches/series	2021-01-23 17:25:13.000000000 +0100
+++ phpmyadmin-5.0.4+dfsg2/debian/patches/series	2022-06-19 18:56:52.000000000 +0200
@@ -9,3 +9,4 @@
 Remove-dfsg-zxcvbn-js.patch
 CVE-2021-21252.patch
 Remove-metro-fonts.patch
+Fix-SQL-query-server-error.patch

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: