Bug#1008268: bullseye-pu: package tigervnc/1.11.0+dfsg-2
Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: pkg-tigervnc-devel@lists.alioth.debian.org, joachim.falk@gmx.de
[ Reason ]
This proposed update fixes two regressions:
(i) https://bugs.launchpad.net/ubuntu/+source/tigervnc/+bug/1929790
* TigerVNC 1.11.0 contains a (pixel order) regression that causes
vncviewer to display incorrect colors when vncviewer and X11 server
use different endianness
(e.g. when using X11 forwarding via SSH between an amd64 desktop
and a Linux on s390x).
* The regression was originally reported in github issue
https://github.com/TigerVNC/tigervnc/issues/1073
and fixed in github pull request
https://github.com/TigerVNC/tigervnc/pull/1084
* The issue got fixed by a respin of the
ARGB runtime XImage byteorder selection.
(ii) https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1004395
Den tors 20 jan. 2022 14:06code0815 <code0815@mailbox.org> skrev:
Dear Maintainers,
I'm using debian bullseye and facing a bug, that is present inside the
tigervnc-standalone-server packages 1.11.0+dfsg-2, 1.11.0+dfsg-3. The
bug does affect the Gnome environment, so that a gnome-session is not
started properly, when started through tigervncserver@.service. So the
bug makes tigervnc-standalone-server unuseable, if a user does want to
use a Gnome-Session inside TigerVNC.
This bug does not come up anymore, if I do install tigervnc-1.12 from
the TigerVNC developers source packages. The bug does affect Ubuntu
21.10, too. It seems to me, that all 1.11 versions - not debian based
only - are affected.
Thanks in advance!
code0815
In this process, I also fixed two typos in the tigervncserver man page.
[ Impact ]
The first regression is minor. It only triggers in corner cases.
The second regression is more severe if one wants to use tigervncserver@.service.
[ Tests ]
Package has been tested by being used in our lab for two month.
[ Risks ]
First regression is fixed by a backported upstream patch that also has
been applied for Ubuntu 21.04. Second regression is fixed by a one
liner.
[ Checklist ]
[X] *all* changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in (old)stable
[X] the issue is verified as fixed in unstable
[ Changes ]
First regression got fixed by a respin of the ARGB runtime XImage byteorder selection.
Second regression is fixed by switching the PAM session used by
tigervnc-standalone-server to be interactive instead of noninteractive.
diff -Nru tigervnc-1.11.0+dfsg/debian/changelog tigervnc-1.11.0+dfsg/debian/changelog
--- tigervnc-1.11.0+dfsg/debian/changelog 2021-03-22 22:21:28.000000000 +0100
+++ tigervnc-1.11.0+dfsg/debian/changelog 2022-01-26 18:59:24.000000000 +0100
@@ -1,3 +1,17 @@
+tigervnc (1.11.0+dfsg-2+deb11u1) bullseye; urgency=medium
+
+ [ John Martin ]
+ * TigerVNC 1.11.0 contains a regression that causes vncviewer to display
+ incorrect colors when vncviewer and X11 server use different endianness.
+ (LP: #1929790)
+
+ [ Joachim Falk ]
+ * Fixed typo in tigervncserver man page (Closes: #1003715).
+ * Fixed gnome desktop start up when using tigervncserver@.service.
+ (Closes: #1004395)
+
+ -- Joachim Falk <joachim.falk@gmx.de> Wed, 26 Jan 2022 18:59:24 +0100
+
tigervnc (1.11.0+dfsg-2) unstable; urgency=medium
[ Joachim Falk ]
diff -Nru tigervnc-1.11.0+dfsg/debian/helpers/etc/pam.d/tigervnc tigervnc-1.11.0+dfsg/debian/helpers/etc/pam.d/tigervnc
--- tigervnc-1.11.0+dfsg/debian/helpers/etc/pam.d/tigervnc 2020-10-06 21:57:07.000000000 +0200
+++ tigervnc-1.11.0+dfsg/debian/helpers/etc/pam.d/tigervnc 2022-01-26 18:59:24.000000000 +0100
@@ -2,4 +2,4 @@
@include common-auth
@include common-account
-@include common-session-noninteractive
+@include common-session
diff -Nru tigervnc-1.11.0+dfsg/debian/helpers/usr/share/man/man1/tigervncserver.1 tigervnc-1.11.0+dfsg/debian/helpers/usr/share/man/man1/tigervncserver.1
--- tigervnc-1.11.0+dfsg/debian/helpers/usr/share/man/man1/tigervncserver.1 2021-02-22 18:20:50.000000000 +0100
+++ tigervnc-1.11.0+dfsg/debian/helpers/usr/share/man/man1/tigervncserver.1 2022-01-26 18:59:24.000000000 +0100
@@ -11,7 +11,7 @@
.\"
.TH tigervncserver 1 "Jan 13th, 2021" "TigerVNC 1.11.0" "Virtual Network Computing"
.SH NAME
-tigervncserver \- start or stop a TigerVNC standaloe server
+tigervncserver \- start or stop a TigerVNC standalone server
.SH SYNOPSIS
.
.B tigervncserver
@@ -75,7 +75,7 @@
.RB [ \-cleanstale ]
.
.br
-.B x0tigervncserver -version
+.B tigervncserver -version
.
.SH DESCRIPTION
.B tigervncserver\fP is used to start a TigerVNC (Virtual Network Computing)
diff -Nru tigervnc-1.11.0+dfsg/debian/patches/backport/0001-Update-Surface_X11.cxx.patch tigervnc-1.11.0+dfsg/debian/patches/backport/0001-Update-Surface_X11.cxx.patch
--- tigervnc-1.11.0+dfsg/debian/patches/backport/0001-Update-Surface_X11.cxx.patch 1970-01-01 01:00:00.000000000 +0100
+++ tigervnc-1.11.0+dfsg/debian/patches/backport/0001-Update-Surface_X11.cxx.patch 2022-01-26 18:59:24.000000000 +0100
@@ -0,0 +1,46 @@
+From 7ab92639848a6059e2b6b88499b008b9606f3af6 Mon Sep 17 00:00:00 2001
+From: johnmartin-oracle <55413843+johnmartin-oracle@users.noreply.github.com>
+Date: Thu, 27 Aug 2020 22:30:23 -0400
+Subject: [PATCH] Update Surface_X11.cxx
+
+Runtime sellection of ARGB XImage byte order
+---
+ vncviewer/Surface_X11.cxx | 22 +++++++++++-----------
+ 1 file changed, 11 insertions(+), 11 deletions(-)
+
+diff --git a/vncviewer/Surface_X11.cxx b/vncviewer/Surface_X11.cxx
+index 6562634d..8944c3f7 100644
+--- a/vncviewer/Surface_X11.cxx
++++ b/vncviewer/Surface_X11.cxx
+@@ -123,17 +123,17 @@ void Surface::alloc()
+ // we find such a format
+ templ.type = PictTypeDirect;
+ templ.depth = 32;
+-#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
+- templ.direct.alpha = 0;
+- templ.direct.red = 8;
+- templ.direct.green = 16;
+- templ.direct.blue = 24;
+-#else
+- templ.direct.alpha = 24;
+- templ.direct.red = 16;
+- templ.direct.green = 8;
+- templ.direct.blue = 0;
+-#endif
++ if (XImageByteOrder(fl_display) == MSBFirst) {
++ templ.direct.alpha = 0;
++ templ.direct.red = 8;
++ templ.direct.green = 16;
++ templ.direct.blue = 24;
++ } else {
++ templ.direct.alpha = 24;
++ templ.direct.red = 16;
++ templ.direct.green = 8;
++ templ.direct.blue = 0;
++ }
+ templ.direct.alphaMask = 0xff;
+ templ.direct.redMask = 0xff;
+ templ.direct.greenMask = 0xff;
+--
+2.30.2
+
diff -Nru tigervnc-1.11.0+dfsg/debian/patches/series tigervnc-1.11.0+dfsg/debian/patches/series
--- tigervnc-1.11.0+dfsg/debian/patches/series 2021-03-22 13:59:06.000000000 +0100
+++ tigervnc-1.11.0+dfsg/debian/patches/series 2022-01-26 18:59:24.000000000 +0100
@@ -12,6 +12,8 @@
0220-remove-systemd-service-obsolete-syslog-target.patch
0300-fix-Xtigervnc-boolparam-parsing.patch
+backport/0001-Update-Surface_X11.cxx.patch
+
# These patches are lifted from RedHat
rh/0904-Added-RH-patch-tigervnc11-rh588342.patch-which-fixes.patch
# These patches are lifted from RHEL 7.4 (tigervnc-1.8.0-2.el7_4.src.rpm)
Reply to: