[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1008074: bullseye-pu: package s390-dasd/0.0.74~deb11u1



Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: Dipak Zope1 <Dipak.Zope1@ibm.com>

Hi,

Dipak Zope was kind enough to dig into s390x issues, and found s390-dasd
to be the missing piece in bullseye. I'm therefore proposing this change
to unbreak s390-dasd.

[ Reason ]

An option was dropped from a CLI tool that gets called in the installer
context, and we didn't remove it from our execve call.

[ Impact ]

Formatting fails on s390x systems.

[ Tests ]

Dipak Zope did the testing, and has an @ibm.com address, which sounds
good enough for me. :)

[ Risks ]

It cannot work without the fix.

[ Checklist ]

  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in stable
  [x] the issue is verified as fixed in unstable

This is a trivial backport of the package uploaded to unstable a few
days ago.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
diff -Nru s390-dasd-0.0.73/dasd-config.c s390-dasd-0.0.74~deb11u1/dasd-config.c
--- s390-dasd-0.0.73/dasd-config.c	2020-10-24 15:22:32.000000000 +0200
+++ s390-dasd-0.0.74~deb11u1/dasd-config.c	2022-03-18 13:08:33.000000000 +0100
@@ -390,7 +390,7 @@
 	debconf_subst (client, TEMPLATE_PREFIX "formatting", "device", channel_current->name);
 	debconf_progress_start (client, 0, drive_geo.cylinders - 1, TEMPLATE_PREFIX "formatting");
 
-	snprintf (buf, sizeof (buf), "dasdfmt -l LX%04x -b 4096 -m 1 -f %s -y", channel_device (channel_current->name), dev);
+	snprintf (buf, sizeof (buf), "dasdfmt -l LX%04x -b 4096 -m 1 %s -y", channel_device (channel_current->name), dev);
 	ret = di_exec_shell_full (buf, format_handler, NULL, NULL, NULL, NULL, NULL, NULL);
 
 	debconf_progress_stop (client);
diff -Nru s390-dasd-0.0.73/debian/changelog s390-dasd-0.0.74~deb11u1/debian/changelog
--- s390-dasd-0.0.73/debian/changelog	2021-07-23 19:30:21.000000000 +0200
+++ s390-dasd-0.0.74~deb11u1/debian/changelog	2022-03-18 13:15:56.000000000 +0100
@@ -1,3 +1,17 @@
+s390-dasd (0.0.74~deb11u1) bullseye; urgency=medium
+
+  * Rebuild for bullseye.
+
+ -- Cyril Brulebois <kibi@debian.org>  Fri, 18 Mar 2022 13:15:56 +0100
+
+s390-dasd (0.0.74) unstable; urgency=medium
+
+  [ Dipak Zope ]
+  * Stop passing deprecated -f option to dasdfmt, which was dropped in
+    s390-tools 1.37.1-1 (Closes: #1004292).
+
+ -- Cyril Brulebois <kibi@debian.org>  Fri, 18 Mar 2022 13:12:26 +0100
+
 s390-dasd (0.0.73) unstable; urgency=medium
 
   * Team upload

Reply to: