Bug#994622: bullseye-pu: package network-manager/1.30.6-1~deb11u1
Control: tag -1 confirmed
On Mon, Mar 21, 2022 at 03:28:48PM +0100, Michael Biebl wrote:
>
> Hi Julien
>
> Am 18.03.22 um 16:46 schrieb Julien Cristau:
> > Control: tag -1 moreinfo
> >
> > Hi Michael,
> >
> > Sorry it took so long to get to this. I've got a couple of questions
> > from the NEWS file; will keep looking at the actual diff though.
> >
> > On Mon, Sep 20, 2021 at 01:09:00PM +0200, Michael Biebl wrote:
> > > ===============================================
> > > NetworkManager-1.30.6
> > > Overview of changes since NetworkManager-1.30.4
> > > ===============================================
> > >
> > > * By default, don't touch existing traffic control (TC) configuration
> > > on devices.
> >
> > This sounds like it could cause unexpected changes. Unsure about the
> > risk here.
>
> The relevant bug report is
> https://bugzilla.redhat.com/show_bug.cgi?id=1928078
>
> From the git commit
> "
> core,libnm: don't touch device TC configuration by default
>
[...]
>
> So, the new default behavior seems better than the previous one.
>
> "
>
> I'd say the above reasoning makes sense to me.
>
I wasn't arguing that any of these changes were bad, they do sound like
improvements, my question was around the potential for unexpected side
effects, which we try to avoid in stable, even when it means having to
live with known bugs. I'm happy to trust your judgement there, just
wanted to raise this.
[...]
> > > * Enable WPA3 for Wi-Fi connections with key_mgmt=WPA-PSK
> >
> > What's the regression risk here, of things working without WPA3 but not
> > with it enabled?
>
> That one I indeed missed. Thanks for spotting it. It has indeed the
> potential to break existing setups (as evidenced by [1]), although I think
> that would also need a newer wpasupplicant in stable.
>
> The relevant upstream issue is
> https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/638
>
> I think reverting these commits for stable would make sense.
>
> Julien, if I revert the three commits from this MR, would you be ok with the
> upload?
>
Yes. Thanks for the due diligence.
Cheers,
Julien
Reply to: