[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1006187: bullseye-pu: package espeakup/0.80-20+deb11u1



Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian.org@packages.debian.org
Usertags: pu

Hello,

I would like to upload the attached change to bullseye (already uploaded
to the queue).

[ Reason ]
Users have reported that when they are building large packages in
parallel, or generally loading the system a bit, the espeakup screen
reader becomes very laggy. This is because espeakup gets scheduled only
along other the parallel processes. Worse, if the system goes OOM,
espeakup might get killed by the OOM killer.

This is not a regression with respect to previous releases.

In the case of the brltty screen reader, we fixed this by making brltty
niced to -10 and its OOM score set to -900.

[ Impact ]
Users will keep seeing their screen reader potentially harmed by system
overload.

[ Tests ]
This was tested manually, and users reported that they can now load
their system without seeing the screen reader getting laggy.

[ Risks ]
The code is very trivial: two obvious lines of systemd service.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
This just sets the nice level to -10 and the OOM score to -900 for the
espeakup service.
diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog	2021-04-04 14:33:26.000000000 +0200
+++ espeakup-0.80/debian/changelog	2022-01-08 16:59:23.000000000 +0100
@@ -1,3 +1,9 @@
+espeakup (1:0.80-20+deb11u1) stable; urgency=medium
+
+  * debian/espeakup.service: Protect espeakup from system overloads.
+
+ -- Samuel Thibault <sthibault@debian.org>  Sat, 08 Jan 2022 16:59:23 +0100
+
 espeakup (1:0.80-20) unstable; urgency=medium
 
   * espeakup-udeb.finish-install: Carry over the alsa mixer levels into the
diff -Nru espeakup-0.80/debian/espeakup.service espeakup-0.80/debian/espeakup.service
--- espeakup-0.80/debian/espeakup.service	2020-04-29 02:48:49.000000000 +0200
+++ espeakup-0.80/debian/espeakup.service	2022-01-08 16:59:23.000000000 +0100
@@ -12,6 +12,8 @@
 ExecStart=/bin/sh -c 'modprobe speakup_soft && /usr/bin/espeakup -V "${VOICE}"'
 ExecReload=/bin/kill -HUP $MAINPID
 Restart=always
+Nice=-10
+OOMScoreAdjust=-900
 
 [Install]
 WantedBy=sound.target

Reply to: