[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991286: marked as done (unblock: netdiscover/0.7-4)

Your message dated Tue, 20 Jul 2021 07:40:55 +0000
with message-id <E1m5kN5-0001PS-Oj@respighi.debian.org>
and subject line unblock netdiscover
has caused the Debian Bug report #991286,
regarding unblock: netdiscover/0.7-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
991286: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991286
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: eriberto@debian.org

Dear Release Team,

Please unblock package netdiscover.

[ Reason ]

The revision 0.7-4 has a patch (030) to add an important fix from the
upstream[1]. This fix allows netdiscover to use correctly CIDR /24 if
netdiscover is being built with libpcap >= 1.10.

This fix closes #991258

[1] https://github.com/netdiscover-scanner/netdiscover/commit/2de0187c8b6aad3ca5393d96fbc5b00c453c3d23

Short explanation: Older versions of libpcap ignored to_ms on Linux. The
current version captures packets until a buffer a filled or the specified
timeout elapses. The value 0 disables that timeout, so libpcap will only start
delivering packets once the buffer is filled.

[ Impact ]

If the unblock isn't granted, the user will not able to scan a network using
the option '-r <IP>/24', so only /8 and /16 will work.

[ Tests ]

Several tests were made after the fix and it worked fine.

[ Risks ]

This is a trivial fix and it has no risks for the whole source code.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock netdiscover/0.7-4

diff -Nru netdiscover-0.7/debian/changelog netdiscover-0.7/debian/changelog
--- netdiscover-0.7/debian/changelog	2021-02-06 00:05:00.000000000 -0300
+++ netdiscover-0.7/debian/changelog	2021-07-18 17:23:16.000000000 -0300
@@ -1,3 +1,10 @@
+netdiscover (0.7-4) unstable; urgency=medium
+
+  * debian/patches/030_fix_cidr24.patch: created to fix no results with CIDR /24
+    and libpcap >= 1.10. Thanks to Enrico Schmitz. (Closes: #991258)
+
+ -- Joao Eriberto Mota Filho <eriberto@debian.org>  Sun, 18 Jul 2021 17:23:16 -0300
+
 netdiscover (0.7-3) unstable; urgency=medium
 
   * debian/patches/20_update-oui.patch: updated.
diff -Nru netdiscover-0.7/debian/patches/030_fix_cidr24.patch netdiscover-0.7/debian/patches/030_fix_cidr24.patch
--- netdiscover-0.7/debian/patches/030_fix_cidr24.patch	1969-12-31 21:00:00.000000000 -0300
+++ netdiscover-0.7/debian/patches/030_fix_cidr24.patch	2021-07-18 17:23:16.000000000 -0300
@@ -0,0 +1,21 @@
+Description: Fix no results with CIDR /24 and libpcap >= 1.10
+Author: Enrico Schmitz
+Origin: https://github.com/netdiscover-scanner/netdiscover/commit/2de0187c8b6aad3ca5393d96fbc5b00c453c3d23
+Bug: https://github.com/netdiscover-scanner/netdiscover/issues/9
+Bug-Debian: https://bugs.debian.org/991258
+Forwarded: not-needed
+Reviewed-By: Joao Eriberto Mota Filho <eriberto@debian.org>
+Last-Update: 2021-07-18
+Index: netdiscover/src/ifaces.h
+===================================================================
+--- netdiscover.orig/src/ifaces.h
++++ netdiscover/src/ifaces.h
+@@ -45,7 +45,7 @@ extern "C"
+       typedef uint16_t u_int16_t;
+       typedef uint8_t  u_int8_t;
+    #else
+-      #define PCAP_TOUT 0
++      #define PCAP_TOUT 512
+    #endif
+ 
+ 
diff -Nru netdiscover-0.7/debian/patches/series netdiscover-0.7/debian/patches/series
--- netdiscover-0.7/debian/patches/series	2021-02-06 00:04:57.000000000 -0300
+++ netdiscover-0.7/debian/patches/series	2021-07-18 17:23:16.000000000 -0300
@@ -1,2 +1,3 @@
 10_fix-makefile.patch
 20_update-oui.patch
+030_fix_cidr24.patch

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: