[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991179: marked as done (unblock: hamlib/4.0-7)

Your message dated Sat, 17 Jul 2021 13:43:49 +0200
with message-id <CAM8zJQvGpWn7PYs4L+Ss_oGteks9gK8P-9F7TcRuujyvVUmrcQ@mail.gmail.com>
and subject line Re: Bug#991179: unblock: hamlib/4.0-7
has caused the Debian Bug report #991179,
regarding unblock: hamlib/4.0-7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
991179: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991179
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear Release Team,

Please consider an unblock for package hamlib.

[ Reason ]

This upload adds a patch for a bug that causes some programs that use
hamlib to crash upon startup.  See:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980472

[ Impact ]

The severity of bug 980472 impacts all reverse dependencies of hamlib;
its removal would transitively remove several popular Ham Radio packages
from the Bullseye release.  Alternately, the bug could be downgraded and cubicsdr
and any other applications that call rig_load_all_backends() more than
once would remain broken.

[ Tests ]

The reported issue with cubicsdr is trivially reproducible with the
current version.  After verifying the crash, I installed the patched
libhamlib4 and libhamlib-utils packages and manually tested cubicsdr,
wsjtx, and xlog.


[ Risks ]

The patch clears memory in a hash table so repopulating the table
doesn't fail.  Since it is only called when the table is being
reconstructed, it seems quite safe.  (The code works on the first call
because it depends on the memory being initialized to zeros.)

The patch originates (and has been applied) upstream.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]

Thank you, and apologies for the very late unblock request!

Cheers,
tony

unblock hamlib/4.0-7

diff -Nru hamlib-4.0/debian/changelog hamlib-4.0/debian/changelog
--- hamlib-4.0/debian/changelog	2021-05-11 10:03:12.000000000 -0700
+++ hamlib-4.0/debian/changelog	2021-07-15 21:31:14.000000000 -0700
@@ -1,3 +1,11 @@
+hamlib (4.0-7) unstable; urgency=medium
+
+  * Team upload.
+  * Allow rig_load_all_backends to be called more than once.
+    (Closes: #980472)
+
+ -- tony mancill <tmancill@debian.org>  Thu, 15 Jul 2021 21:31:14 -0700
+
 hamlib (4.0-6) unstable; urgency=medium
 
   * Paper over a minor precision difference in dec2dms on i386.
diff -Nru hamlib-4.0/debian/patches/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0 hamlib-4.0/debian/patches/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0
--- hamlib-4.0/debian/patches/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0	1969-12-31 16:00:00.000000000 -0800
+++ hamlib-4.0/debian/patches/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0	2021-07-15 21:31:14.000000000 -0700
@@ -0,0 +1,17 @@
+Comment: Allow rig_load_all_backends to be called more than once
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980472
+Forwarded: not-needed
+Source: https://sourceforge.net/p/hamlib/code/ci/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0/
+Author: Michael Black W9MDB
+
+--- a/src/register.c
++++ b/src/register.c
+@@ -454,6 +454,8 @@
+ {
+     int i;
+ 
++    memset(rig_hash_table, 0 , sizeof(rig_hash_table));
++
+     for (i = 0; i < RIG_BACKEND_MAX && rig_backend_list[i].be_name; i++)
+     {
+         rig_load_backend(rig_backend_list[i].be_name);
diff -Nru hamlib-4.0/debian/patches/series hamlib-4.0/debian/patches/series
--- hamlib-4.0/debian/patches/series	2021-05-11 10:03:12.000000000 -0700
+++ hamlib-4.0/debian/patches/series	2021-07-15 21:31:14.000000000 -0700
@@ -7,3 +7,4 @@
 cf858bfa3c8a36eda749c5078ef6f53a119fb285
 0089964af7fa1f43757083b7bc7db195ba382fe0
 1d74711a00dfa416a171cec87c841db315c5d9f7
+31dedcf4f79d8fc5fcf287360e5d017842c8e4c0

[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .changes but not in first
-----------------------------------------
-rw-r--r--  root/root   /usr/lib/debug/.build-id/37/f26c116c35dc6ce75eab34eec4e51ae09c1e0d.debug

Files in first .changes but not in second
-----------------------------------------
-rw-r--r--  root/root   /usr/lib/debug/.build-id/93/b3059fa0ecb4686b120e91e64e0a2b8e37100c.debug

Control files of package libhamlib++-dev: lines which differ (wdiff format)
---------------------------------------------------------------------------
Depends: libc6-dev, libhamlib++4 (= [-4.0-6),-] {+4.0-7),+} libhamlib-dev (= [-4.0-6),-] {+4.0-7),+} libhamlib4 (= [-4.0-6)-] {+4.0-7)+}
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib++4: lines which differ (wdiff format)
------------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib++4-dbgsym: lines which differ (wdiff format)
-------------------------------------------------------------------------------
Depends: libhamlib++4 (= [-4.0-6)-] {+4.0-7)+}
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib-dev: lines which differ (wdiff format)
-------------------------------------------------------------------------
Depends: libc6-dev, libhamlib4 (= [-4.0-6),-] {+4.0-7),+} libusb-1.0-0-dev
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib-doc: lines which differ (wdiff format)
-------------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib-perl: lines which differ (wdiff format)
--------------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib-perl-dbgsym: lines which differ (wdiff format)
---------------------------------------------------------------------------------
Depends: libhamlib-perl (= [-4.0-6)-] {+4.0-7)+}
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib-utils: lines which differ (wdiff format)
---------------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib-utils-dbgsym: lines which differ (wdiff format)
----------------------------------------------------------------------------------
Depends: libhamlib-utils (= [-4.0-6)-] {+4.0-7)+}
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib2-perl: lines which differ (wdiff format)
---------------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib2-tcl: lines which differ (wdiff format)
--------------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib4: lines which differ (wdiff format)
----------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package libhamlib4-dbgsym: lines which differ (wdiff format)
-----------------------------------------------------------------------------
Build-Ids: [-93b3059fa0ecb4686b120e91e64e0a2b8e37100c-] {+37f26c116c35dc6ce75eab34eec4e51ae09c1e0d+}
Depends: libhamlib4 (= [-4.0-6)-] {+4.0-7)+}
Installed-Size: [-2089-] {+2090+}
Version: [-4.0-6-] {+4.0-7+}

Control files of package lua-hamlib: lines which differ (wdiff format)
----------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package lua-hamlib-dbgsym: lines which differ (wdiff format)
-----------------------------------------------------------------------------
Depends: lua-hamlib (= [-4.0-6)-] {+4.0-7)+}
Version: [-4.0-6-] {+4.0-7+}

Control files of package lua-hamlib2: lines which differ (wdiff format)
-----------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package python3-hamlib: lines which differ (wdiff format)
--------------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package python3-hamlib-dbgsym: lines which differ (wdiff format)
---------------------------------------------------------------------------------
Depends: python3-hamlib (= [-4.0-6)-] {+4.0-7)+}
Version: [-4.0-6-] {+4.0-7+}

Control files of package python3-libhamlib2: lines which differ (wdiff format)
------------------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package tcl-hamlib: lines which differ (wdiff format)
----------------------------------------------------------------------
Version: [-4.0-6-] {+4.0-7+}

Control files of package tcl-hamlib-dbgsym: lines which differ (wdiff format)
-----------------------------------------------------------------------------
Depends: tcl-hamlib (= [-4.0-6)-] {+4.0-7)+}
Version: [-4.0-6-] {+4.0-7+}

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Hi Tony

On Fri, 16 Jul 2021 at 16:45, tony mancill <tmancill@debian.org> wrote:
> Please consider an unblock for package hamlib.

Hamlib is not blocked.  I've aged it so that we can get this fix in sooner.

Regards
Graham

--- End Message ---
Reply to: